From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 901B5A0527; Mon, 9 Nov 2020 14:19:36 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D8AB85AB8; Mon, 9 Nov 2020 14:19:34 +0100 (CET) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 9CCA55AB3 for ; Mon, 9 Nov 2020 14:19:33 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 1171B5C0270; Mon, 9 Nov 2020 08:19:32 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Mon, 09 Nov 2020 08:19:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= uHhBKaz/H3L1sCyJYm1jlGntQcBeyVtEGQAtejnc1cg=; b=TwHHR8BK61dqTi1B Nd/LXSAGh76X6hPJ+WkVPuvBw3s7j7vwhNOkJzMJGQ+vXSCsX/TWM78NFQgQfMHD XNFLbbGNiH+2yTWkeYRxTj4sORR1/fJtxBTWjYUcPnk2rv4V2H3dwDRMkCSTca2s g9KuTlB8POvy+XvtrXC7OMhUiu5Q2D11qbBm6fGTVvqXuxDMKe3ft7ex7JL2G/ed wxJ2oeu84aEryOF6qTvYKlSzn3i72olPved7PDxXQZ65JRrSdHAq37E7lVKt0Rem GiMLTl/BozYWL/iXOAtQzJ5gINrhl4SbLzIlW/jPNgxSV604kT9Cz+WeIGngTKVq pQyEDA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=uHhBKaz/H3L1sCyJYm1jlGntQcBeyVtEGQAtejnc1 cg=; b=XiUcXEODzX2T1aROIIe+euUu0weYTduxQRgxBj7vz9P+Kl8+DU0T5L311 nI9OlURwmWeVZhI7oKVD7bcVmDCemVNIJEslJNS+ys6qnM+XnwFpX1XLKZaynjZe +/KHrBKCncVZYLmVgpwjMDadv1L3LfYdxmwa0dA2/Uzq7KbXw4FO6IVQWtnfBvzF yMSEBNFm175sjzVN7MjkKlgA2vU1YnKZJdWMJCkm6D6CgEFB5VXN/yjgoxl7UFQC hrUXkTSi8a4UDiebY89B7Ap4fzqMLOlbIu/4GeVzaPFazqrVyqzcm/yksMNsa64D c4NkW+pz07HrN5lGz8gMEl9G1uUmg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudduhedghedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id EB2D03063080; Mon, 9 Nov 2020 08:19:30 -0500 (EST) From: Thomas Monjalon To: Ferruh Yigit Cc: dev@dpdk.org, Bruce Richardson , david.marchand@redhat.com Date: Mon, 09 Nov 2020 14:19:29 +0100 Message-ID: <3243789.yRO6XYygMt@thomas> In-Reply-To: <20201109130035.3948462-1-ferruh.yigit@intel.com> References: <20201109130035.3948462-1-ferruh.yigit@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] devtools: fix 32-bits build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 09/11/2020 14:00, Ferruh Yigit: > 32 bit still uses the pkgconfig file for 64-bits libraries, from the > build log: > > " > Using DPDK_TARGET i386-pc-linux-gnu > meson -Dexamples=l3fwd --buildtype=debugoptimized --werror > -Dc_args=-m32 -Dc_link_args=-m32 > /tmp/dpdk_maintain/self/dpdk/devtools/.. ./build-32b > ... > Using 'PKG_CONFIG_PATH' from environment with value: > '/usr/local/lib64/pkgconfig/ > " > > This causes build error when linking with the found libraries. > > Reproduced with 'librte_bpf' which only has 64 bit installed but still > enables building 'af_xdp' and link fails. I think it is a problem in your configuration. PKG_CONFIG_PATH is not empty before starting the script, right? > To fix updating 'PKG_CONFIG_PATH' and preventing 'load_env' overwrite > it. [...] > 'build-32b' check inside the 'load_env' looks ugly but not sure how to > be sure 'PKG_CONFIG_PATH' set correct. [...] > - export PKG_CONFIG_PATH=$default_pkgpath > + if [ "$targetdir" != "build-32b" ] ; then > + export PKG_CONFIG_PATH=$default_pkgpath > + fi You can reset PKG_CONFIG_PATH in your config file. Something like this: if echo $DPDK_TARGET | grep -q '^i[3-6]86' ; then export PKG_CONFIG_PATH=my32bitlibs/pkgconfig fi We can also discuss why inheriting some default values on script start instead of just resetting them.