From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id AC7A01B40B for ; Tue, 6 Feb 2018 21:24:57 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 3987620A5B; Tue, 6 Feb 2018 15:24:57 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Tue, 06 Feb 2018 15:24:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=TdjGUnz7XvKecCML+zKnU+0OeU vTV9jsPHr6xCFe8Dg=; b=O+EX+tRlmhNQo8n7JHXu0NrIbSqxsEIOSYJky/P3l2 MGWCYtzvJw4G6zP0s+nd1IwvkjS55jD4LxGD/Al9K4FVWx9I50qzx9IT89mNgvKS /mhNop+MMiPjjEZg40mYhvW6xS1D8oprOpSTugmj7NBoRyLfKS2cm0+BEbCsP6wu k= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=TdjGUn z7XvKecCML+zKnU+0OeUvTV9jsPHr6xCFe8Dg=; b=mgUP4gpUEmUjitqgXWyEcA lbf3I5B47G9Du+0yqP60z1tyLsjr+OanxlwvIe85NNYjG0OZp3RcxCWlIm1ifK6x zpDrp5YdDrLjHUisnNLLl0VLkbFtY2L7l8hQBTyQ9Su6TjNUfXBWS/WbThW4ltnZ qfL2YvsXYdIME3UiVwRSJ2I31vadZN1uDFTeJptLOHSA6FWyhdFwQ6jxhI3AQLjP Ue+icFSg1A3RGJcs1PJXtBjxQpJ9VjpIJMi2O2RCM71JpAqjNDJIgCOt28lBevOk KzzSY5GsZmfGfcrE9+4RPSj17ediOwmsKL7CyclC1IyItiA5tZlkeRZm5BOeEsLw == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id D423824550; Tue, 6 Feb 2018 15:24:56 -0500 (EST) From: Thomas Monjalon To: Nikhil Rao Cc: dev@dpdk.org, Jerin Jacob , vipin.varghese@intel.com, deepak.k.jain@intel.com Date: Tue, 06 Feb 2018 21:24:53 +0100 Message-ID: <3243913.r7aDMFFJxM@xps> In-Reply-To: <20180206190113.GA5868@jerin> References: <1517352989-11720-1-git-send-email-vipin.varghese@intel.com> <1517768311-827-1-git-send-email-nikhil.rao@intel.com> <20180206190113.GA5868@jerin> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] eventdev: fix unchecked return in default Rx adapter conf cb X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Feb 2018 20:24:57 -0000 > > The default adapter configuration callback is invoked when a Rx > > queue is added to the adapter and the adapter detects that a SW > > service is needed. The adapter needs to re-configure the device > > with an additional port and to do do, it needs to stop the > > device and restart it after it is done reconfiguring it. This > > patch adds code to check the return code of > > rte_event_dev_start() for both when the reconfiguration fails > > and when it succeeds and introduces a new error code (-EIO) > > for the first case. > > > > Fixes: 9c38b704d280 ("eventdev: add eth Rx adapter implementation") > > Coverity issue: 257000 > > > > Signed-off-by: Nikhil Rao > > Cc: stable@dpdk.org > Acked-by: Jerin Jacob Applied, thanks