From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A2CCEA04A4; Tue, 26 May 2020 15:55:14 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 01FC91D66E; Tue, 26 May 2020 15:55:14 +0200 (CEST) Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by dpdk.org (Postfix) with ESMTP id 5A25A1D66C for <dev@dpdk.org>; Tue, 26 May 2020 15:55:12 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id C5F5CA3E; Tue, 26 May 2020 09:55:09 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Tue, 26 May 2020 09:55:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= aG+Ox85jseSexoZ4E0EV9z5evNKQu06EKs4NJj88uWI=; b=XZDz/vvhB/nazgYn laEtcE2DlLsUMnMqvj+sd6y7nfSXIQzZZjTHtYq2dzf3o3X0mG3WMMFWjPDlByl5 K90FHiRXhO8xXP8Vu9Vfif0Otno8OwNrTPTUW2j7bu0tblH3p25hFzqcXf6KRfpi YLp3qSZV5Hsyzbh/aLfFgbh5qrlVwZXDYMmHIscRxfN6HEBGhjLP6tVmnplExUrQ qcinrNFow7RATp9EepJ6svMKLH8lzX14uxxg8e9k1RigysTkR3Y8Lh7wsun7UgtQ dlDaKe7/8YwGimDCVkIoOrx8sS3k73E7dlwVJ8z56GHXZzqc19WaF6Rr8S1e5JHh f4EFKQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=aG+Ox85jseSexoZ4E0EV9z5evNKQu06EKs4NJj88u WI=; b=me9I6pu2S7eg92qBz6QmSWLHoqFO2g1vZJLtmnvOdFTnZPE0gII4LyBSA TIEqa4W/CqpcrQILbEfxxI5p+8C+TbLsjjlegvf3ZscomyGGP9s2AK+uH8Lwaq1S EFn4BtY7OoNF0w6EiZ3D+jltvOn7j45xKxgW+DuYc5Wdk8qc1D9zmsWfhCWWynFW AhrpnW65s+xmbwF6ZLFKuyIevnfPA+oO5XwobQw/3VjWqyv0UDXB+CQJn6+naJaK UwQW0GCRfHnggbIoq9nMY3eD/ZaO5sSjq+AWpU6LiJQUEYWK5D5fBv/Znkkx5wHr NKTzNoa6oCjjuSS5jB08pstw4VKUQ== X-ME-Sender: <xms:ux_NXtHPKmV4wJEMbG83UGX2gIONIVmx3MwyC8d0n0RD8fIcyVoZZg> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedruddvvddgieelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: <xmx:ux_NXiVekqQYGhnDJuiKzwEvik8jXxW2d-MAoyt5GjUH005RIuPtxQ> <xmx:ux_NXvKrY2ofk3eEW5N19pLgiyZTmf3HzJ6I8qWXxJSWf7eSoz-i1w> <xmx:ux_NXjEO53yVc3qB2G0WzygKP14_4U0ZB4hsGnEiQphVhrQD6XGalA> <xmx:vR_NXlLLnzu4CDVocJ7o1uQ90Ds4VsmqTLtKCxuL7q9yTTBCGPZ9Gg> Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id E631530665B4; Tue, 26 May 2020 09:55:05 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: Ferruh Yigit <ferruh.yigit@intel.com> Cc: dev@dpdk.org, Neil Horman <nhorman@tuxdriver.com>, John McNamara <john.mcnamara@intel.com>, Marko Kovacevic <marko.kovacevic@intel.com>, dev@dpdk.org, Jerin Jacob Kollanukkaran <jerinj@marvell.com>, David Marchand <david.marchand@redhat.com>, mdr@ashroe.eu, olivier.matz@6wind.com, Andrew Rybchenko <arybchenko@solarflare.com> Date: Tue, 26 May 2020 15:55:04 +0200 Message-ID: <32460411.7iZ4MHogd9@thomas> In-Reply-To: <c68af930-d3fa-67bf-4d44-6f8d1a96db5e@solarflare.com> References: <20200225124431.4088444-1-ferruh.yigit@intel.com> <4037653.gGmTCM0MZ2@thomas> <c68af930-d3fa-67bf-4d44-6f8d1a96db5e@solarflare.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3] doc: plan splitting the ethdev ops struct X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> 25/05/2020 11:11, Andrew Rybchenko: > On 5/25/20 2:18 AM, Thomas Monjalon wrote: > > 04/03/2020 10:57, Ferruh Yigit: > >> For the ABI compatibility it is better to hide internal data structures > >> from the application as much as possible. But because of some inline > >> functions 'struct eth_dev_ops' can't be hidden completely. > >> > >> Plan is to split the 'struct eth_dev_ops' into two as ones used by > >> inline functions and ones not used, and hide the second part that not > >> used by inline functions completely to the application. > >> > >> Because of ABI break the work will be done in 20.11 > >> > >> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com> > >> --- > >> +* ethdev: Split the ``struct eth_dev_ops`` struct to hide it as much as possible > >> + will be done in 20.11. > >> + Currently the ``struct eth_dev_ops`` struct is accessible by the application > >> + because some inline functions, like ``rte_eth_tx_descriptor_status()``, > >> + access the struct directly. > >> + The struct will be separate in two, the ops used by inline functions will be moved > >> + next to Rx/Tx burst functions, rest of the ``struct eth_dev_ops`` struct will be > >> + moved to header file for drivers to hide it from applications. > > Acked-by: Thomas Monjalon <thomas@monjalon.net> > > Acked-by: Andrew Rybchenko <arybchenko@solarflare.com> Acked-by: David Marchand <david.marchand@redhat.com> Applied, thanks