From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <thomas@monjalon.net> Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 7994811F5 for <dev@dpdk.org>; Wed, 30 May 2018 10:32:27 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id CB68421C08; Wed, 30 May 2018 04:32:26 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 30 May 2018 04:32:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=W+Zic7AepUZiobtzreFvyA415q B6y/dY9FSDGkU0yHk=; b=avY3Ero4fepPcdPtDWP9FZtUk6qEcIoe5zM6HboefB F6zWZo7hYuqNaatRix6P+lEpdHTg9VWfCbcbtzt3VM/usgIz55DuWMw0R52axfaj t8CrQCmOQUBytibDHMNwrEUpH+J5tfkB6X4yJK/X43JbaAnH8m2yhzt6WpsjM3AB 4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=W+Zic7 AepUZiobtzreFvyA415qB6y/dY9FSDGkU0yHk=; b=ZGb+bZbueXy47d0ajEPIZ5 7JsNMEyMmRZZ3eMO/VTwafe9wkiOKj259/xMpEI2xfN7OQ2Ut29zqucf9i9FqgQM XVHXaITb1h/8RQ7tHLD709ncA6M+thzijI5bR0Hw6h98MIdKvzH1wBvCpOLA/82B has0RiYx7qlYiXF+2leOY9xrgbCm0L2omgMOBYNk+kWPAu3F2P5qRlEYIv4aSSGl N3/v+qeXzxQr7H8yyRi36XWi7XHUkaDJIevkbGem1/dsHlFxVwx3GLaoT0XMaypa WkOUPRQw/k9Oz/ga0XuXwG9KcNWA5otwW3pF0FFB5mI65HIMJ3bWI4IZ00Ew26iQ == X-ME-Proxy: <xmx:mmEOW3UUio6eEE_lG7cudnXcvd8vTFjoMIrMkTeQCQsn2qBrynFuRQ> X-ME-Proxy: <xmx:mmEOW7J6GdfENcO1Cm2Nkqi13qHPnWTZq_Dz_2x2AEB3b_RrGGP9XQ> X-ME-Proxy: <xmx:mmEOWzbGJ8C-MwxwzIjLOYhL_AMdkGWi-_TPUi1TaqJkEJQj5Ai8qQ> X-ME-Proxy: <xmx:mmEOW3TcHB0le-VSWNqpd4y-ThnZt2NoTsV007RN8iSGEQdEHrK6aQ> X-ME-Proxy: <xmx:mmEOWzgmdn4Us-Rg_h7eHiACw5P1T3k6RJJY_KTnvMoquOXUjyoTFg> X-ME-Proxy: <xmx:mmEOWxMcY1Ra_Ceb7fk9fhNfa6hOLggf6Kn_fta7WOHHqjSAlPMYLw> X-ME-Sender: <xms:mmEOW_I0r6kmwNwhKc6PLIbZLtwaaphS4X3K-zivmG2ac7ZDVAR8DQ> Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 182F5E4ABA; Wed, 30 May 2018 04:32:25 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: Gavin Hu <Gavin.Hu@arm.com> Cc: Bruce Richardson <bruce.richardson@intel.com>, "dev@dpdk.org" <dev@dpdk.org> Date: Wed, 30 May 2018 10:32:24 +0200 Message-ID: <3248809.BvU3dfXijd@xps> In-Reply-To: <VI1PR08MB316752A4CB8ADB1E2AF5CA958F6C0@VI1PR08MB3167.eurprd08.prod.outlook.com> References: <VI1PR08MB316752A4CB8ADB1E2AF5CA958F6C0@VI1PR08MB3167.eurprd08.prod.outlook.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v5 1/2] mk: fix cross build errors X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Wed, 30 May 2018 08:32:27 -0000 30/05/2018 04:45, Gavin Hu: > From: Bruce Richardson <bruce.richardson@intel.com> > > On Tue, May 29, 2018 at 04:45:55PM +0200, Thomas Monjalon wrote: > > > 28/05/2018 15:24, Bruce Richardson: > > > > Would a simpler solution for this not be to put "-Wno-implicit- > > fallthrough" > > > > for pmdinfogen? GCC will not give a warning for an unrecognised "-Wno" > > > > flag when compiling, unless there are other errors. This means we > > > > can just use the flag without bothering with version checks. > > > > > > No, it does not work. > > > I have this error with clang 5.0.1: > > > error: unknown warning option '-Wno-format-truncation' > > > > > Yes, you still need to check for GCC to use the flag, just not for a specific > > version of GCC. > > > > /Bruce > [Gavin Hu] Hi Thomas, '-Wno-format-truncation' is applied to gcc only, not to clang. > Gcc, icc and clang have their own WERROR_FLAGS, they should not mix up with each other. Now I understand what we missed from the beginning: I am testing with meson. This flag is added unconditionnaly in config/meson.build. > @Bruce, > Yes, in this sense, I am really concerned about to add -Wno-implicit-fallthrough option in the pmdinfogen Makefile, as it impacts not only gcc, but also clang and icc. > Maybe this not a best solution, as maybe it is not supported by all compilers. So should I fall back to the previous patch which check for the gcc version and apply the options for gcc only?