From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7698DA0C46; Mon, 27 Sep 2021 17:47:13 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 49505410DA; Mon, 27 Sep 2021 17:47:13 +0200 (CEST) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by mails.dpdk.org (Postfix) with ESMTP id 01DE240E3C; Mon, 27 Sep 2021 17:47:11 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 37EB85C00CA; Mon, 27 Sep 2021 11:47:10 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 27 Sep 2021 11:47:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= 6oToZn63yzgD9doRDaV5luvhQ8wRM/Z7OJRH2hL/js8=; b=g7wVDA8ynKmfjspO Ag42UyhM03Z8MNsobvx4b+Ym71keGLCatwSHKwgc7ywK0MHzJ41fpGx57npH2+L1 DGJwG+6sB8ikwXmCaeZmrcwZKPCRxoF2AR37g/PtAYy+cKyRI48K84VeBaYK8TmV o8GQubdW9vMOLBNMcTN8F6iq+rJpEGkuWbC8RQjKWd41AFRZnLAbFq9Ek2JdnDyp WHXf5xl6qAAcwr1LzZ4OY1D7ikU4Npm8nQpRLPO7sb2OFay2sbk33KwagThXsiJS mYHxj8qPnjgqrLppLp7Fih3RV/7OOcLGULFe9Kuku/RoG0ksaLcbCEtuOhSNF8m5 YKg/Cw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=6oToZn63yzgD9doRDaV5luvhQ8wRM/Z7OJRH2hL/j s8=; b=mHMVhTX70BbgwVciGnncMPO0Y5zhhO/A1lqNu+/yGTUsmCfi0nqdR6qVc pBFoo1e1OqnvKLoh0WWzP5dk4eYc0EAuGuophfpyG2i9eYUWoZ2s3i7on9MWUJIT XPB/uH9sYE0W+JGykk4tOnEGTIyJnPcqWaZjZT/4mkvti+A5tU/ZKTbkLVwoWBWd zrdB1+DERBe5h+weX7PSLmaLEbqe49Xhmg59wtD8JL+n9pytMLxMlFJngz5ThMyn 34q1B8Qz7zITv2S/ffEtdR6RMvx9tXSiGzaN+Lyqt2wkbUmZ9o9o4P/9itsN58T6 DawK4InVVsZqeO5BgvIltd9LATy3w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrudejkedgledtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 27 Sep 2021 11:47:09 -0400 (EDT) From: Thomas Monjalon To: Julien Meunier Cc: stable@dpdk.org, dev@dpdk.org, Olivier Matz Date: Mon, 27 Sep 2021 17:47:08 +0200 Message-ID: <3254776.WOgDVESeD1@thomas> In-Reply-To: References: <20210819093915.5227-1-julien.meunier@nokia.com> <20210921161724.20860-1-julien.meunier@nokia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2] stack: fix reload head when pop fails X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 24/09/2021 10:57, Olivier Matz: > Hello, > > On Tue, Sep 21, 2021 at 06:17:24PM +0200, Julien Meunier wrote: > > The previous commit 18effad9cfa7 ("stack: reload head when pop fails") > > only changed C11 implementation, not generic implementation. > > > > List head must be loaded right before continue (when failed to find the > > new head). Without this, one thread might keep trying and failing to pop > > items without ever loading the new correct head. > > > > Fixes: 3340202f5954 ("stack: add lock-free implementation") > > Cc: stable@dpdk.org > > > > Signed-off-by: Julien Meunier > > Acked-by: Olivier Matz Applied, thanks.