From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f53.google.com (mail-wm0-f53.google.com [74.125.82.53]) by dpdk.org (Postfix) with ESMTP id DE572A2F for ; Thu, 26 May 2016 08:27:14 +0200 (CEST) Received: by mail-wm0-f53.google.com with SMTP id s131so623772wme.0 for ; Wed, 25 May 2016 23:27:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=FtelxT8b/u9eIERiUoSluHyjVt1CsFsgz/MGZKwSoKI=; b=gkYkHilC4H3t6Xt8HhYjBkfS5VMdEM9MYtvRUt6g0pm44vhRbNOOZ9ZF/wdLclqaUR 2bPHxMTUUvruSF2gSlLMSPr4BvQJw58kAWGgQTN6vUGIIEPNHbvqE7bWaIcQKv4ZduFF +eLpCeuV123GJld8X7GMpBQaAIVXMjrKnVZZO07ZVGir+CkhhMlMC5MP4pcD2Ch2wESk FCQorX5Rgfa2U9ZTDFUtan0wyMa55zFRgf519UqoKjlT2/3H+IICRO7sR/UGtpzrcaLz 24DPQ3BVFBHZGd0Crunu29KFrmTH3O9z01I+GiB1OEYayCGtSgDz2m7/951PS3ramHAi R0Ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=FtelxT8b/u9eIERiUoSluHyjVt1CsFsgz/MGZKwSoKI=; b=Sjqwcizp/teGNWX89xCXpRQBLYAFfyue8qPDM+9/VDA6rJMPcA0dRcEsHWrbx1DVhC /aA7UFFYdOIFuzdM+DNDptrqpiUccBb+k4RKCOAPyoKFFOt4/qPgGFNLe1lcmli3Faha atsyeEc9ZIIjJPY542HcRubq1bu7tvYw5DlqOmv08v+hOpN//NzfkNyHiyfrqp+WVMlP WCoWmZ4lqcPosZEmlFphQUKtFFNW0haukpHtQcKymRhsBIzGsiTPsYH1UiuqGoS3ghYF FGkuXS21dXvE1sKJxX3n4mvd9RUXZjVnjY69Kao9ooMLTrXJo0+wILTYUanTxx3UvDLv D9LA== X-Gm-Message-State: ALyK8tITet9826Bi+stSehMW6Bj8AU5Q661Tk6k80Yys/mm/FNJM1QTX/JZquvqwRFTGjvYI X-Received: by 10.194.171.194 with SMTP id aw2mr8752490wjc.113.1464244034685; Wed, 25 May 2016 23:27:14 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id g3sm12540475wjb.47.2016.05.25.23.27.13 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 25 May 2016 23:27:14 -0700 (PDT) From: Thomas Monjalon To: "Wang, Zhihong" Cc: dev@dpdk.org, "Ananyev, Konstantin" , "Richardson, Bruce" , "De Lara Guarch, Pablo" Date: Thu, 26 May 2016 08:27:13 +0200 Message-ID: <3258601.6MDWRLAuTr@xps13> User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <8F6C2BD409508844A0EFC19955BE09411074370A@SHSMSX103.ccr.corp.intel.com> References: <1462488421-118990-1-git-send-email-zhihong.wang@intel.com> <2292380.hL3i5NyNHm@xps13> <8F6C2BD409508844A0EFC19955BE09411074370A@SHSMSX103.ccr.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 1/6] testpmd: add io_retry forwarding X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 May 2016 06:27:15 -0000 2016-05-26 02:40, Wang, Zhihong: > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > 2016-05-05 18:46, Zhihong Wang: > > > --- a/app/test-pmd/testpmd.h > > > +++ b/app/test-pmd/testpmd.h > > > extern struct fwd_engine io_fwd_engine; > > > +extern struct fwd_engine io_retry_fwd_engine; > > > extern struct fwd_engine mac_fwd_engine; > > > extern struct fwd_engine mac_retry_fwd_engine; > > > extern struct fwd_engine mac_swap_engine; > > > > We now have 2 engines with "retry" behaviour. > > It is maybe the way to go, but I want to ask the question: > > Would it be possible to have "retry" as an engine parameter? > > > > If it's just about the way to write commands there isn't much difference, > like "set fwd io_rety" and "set fwd io retry". > > Do you mean to add the "retry" for all engines, and also implement this > as a parameter in each original engine? So for example, no iofwd-retry.c, > just add this feature inside iofwd.c? Yes, if it makes sense. For engines other than io_fwd and mac_fwd, the retry option can be unsupported (return an error) as a first step.