From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f170.google.com (mail-wr0-f170.google.com [209.85.128.170]) by dpdk.org (Postfix) with ESMTP id CFF16FA7A for ; Mon, 27 Mar 2017 12:01:55 +0200 (CEST) Received: by mail-wr0-f170.google.com with SMTP id w11so35746459wrc.3 for ; Mon, 27 Mar 2017 03:01:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=KqPOTMRv/AflxZKjVZzCIBm9WB4OlB8pDp9uP8SvhOo=; b=Q5SxZ7WzKLGM0sOYfiC0LwXCT4KY1NNHCCFV3NXEIS0hCkipXkiCwEBzHyzj6CZgv2 76ptZS2VPykg6llUIhOZmP9nybr8GYkDR3XS6XRUHbthC1NNJacr8DUAC6Uw4q3WOg9U vYgLAOeWDcYoY5jvq+Da8pv+5VndtU39n+84mmidSY/ChO3qPKAeKjQh50ne5km3Y9Gj Hp9+gwakGpHj0O/b2uwbWCio/3DV+zTUscrfMesqRvZJNCrkhSsght/pgBRMH1lz8NXu DaOu09/T6UnkO/JqoJ7cQUVn8VdVpJE3pSlbYjpNbREGRuAx7l/sLmjkBWFw4jzb1gMf Po/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=KqPOTMRv/AflxZKjVZzCIBm9WB4OlB8pDp9uP8SvhOo=; b=h9QUBMuebnSxYRP0CTJ9IZ7Z61nYCw87f00cveVZAUX7FGv+7sJFzskpcv+E9gTsMy zmLYFuYbUqPuO3NiK6ZSJ4/uw8JhzSPA0r3V0Bmado0BBj+ALeJiEjvi4KEs4gTSKmZA RwVAAydhBXyEFPIwzwUk8GrdwUuKS5Z1F4Djv7bKyksfw3TfctYKF7ljB/kVOE/r3YrV CzHT7rNXEWrgxU9YjRR2nsCHvQmpWlyJ8cc53d6K6lVRm5Sje6BjqHomKnmC0Q/Q/pbt 24XrVRLZtzzk0J3cuapDjG3zs+V33AtqW1C625Os1fepOmPlQsp2YJcXFc8JVbN8G1s6 o4Bg== X-Gm-Message-State: AFeK/H2fUvDjb5B7Ra1PAZ6ucUNfiqgzeDnrldgwolPUyRkNnZXYXwbh8ta7h6THz/YRCjNA X-Received: by 10.28.136.204 with SMTP id k195mr8177063wmd.99.1490608913444; Mon, 27 Mar 2017 03:01:53 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id l138sm206571wmd.7.2017.03.27.03.01.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 27 Mar 2017 03:01:52 -0700 (PDT) From: Thomas Monjalon To: Ben Walker Cc: dev@dpdk.org, Shreyansh Jain Date: Mon, 27 Mar 2017 12:01:51 +0200 Message-ID: <3259292.ro3bpgFpyD@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <0ff897d0-0541-652b-c77b-6369c3e41a67@nxp.com> References: <20170321183215.8357-1-benjamin.walker@intel.com> <0ff897d0-0541-652b-c77b-6369c3e41a67@nxp.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] eal: Fix device registration on FreeBSD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Mar 2017 10:01:56 -0000 2017-03-27 11:34, Shreyansh Jain: > On Wednesday 22 March 2017 12:02 AM, Ben Walker wrote: > > The FreeBSD implementation wasn't registering new devices > > with the device framework on start up. However, common > > code attempts to unregister them on shutdown which causes > > a SEGFAULT. This fix makes the FreeBSD code do the same > > thing as the Linux code for registration. > > > > Signed-off-by: Ben Walker > > --- > > lib/librte_eal/bsdapp/eal/eal_pci.c | 6 ++++-- > > 1 file changed, 4 insertions(+), 2 deletions(-) > > I can't vouch for BSD as I don't have that environment to verify. But, > the patch looks fine to me as compared to Linux changes. > > so, if my Ack makes sense: > > Acked-by: Shreyansh Jain Applied, thanks