From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <thomas.monjalon@6wind.com> Received: from mail-wm0-f41.google.com (mail-wm0-f41.google.com [74.125.82.41]) by dpdk.org (Postfix) with ESMTP id 8D694C33A for <dev@dpdk.org>; Wed, 22 Jun 2016 15:44:25 +0200 (CEST) Received: by mail-wm0-f41.google.com with SMTP id f126so88483073wma.1 for <dev@dpdk.org>; Wed, 22 Jun 2016 06:44:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=gjMu2+r5owLnFmOazrQkbMnjlqqaHZcryXpLkpK9okU=; b=zIptSyxSTAjwpE8XVKAEfryaWX65wN9LMNT1bfQ1ZAy0tjvzL6e6NN3ExeCU3dwgCv 48+m4yDVYWX8DL4OH82C/TcC4lF7XuNvgLEbyUoDl1DDq7zH6FK9iKxp9ikRxdKiaHMA jUCdefY6G0aEHaWXEaNi0MtAYFRfoKI/CiT1PeGfnZ7ZEUkyGNBF4e+7d9wUq2xZfb/F 1ueKXCircTixD88apnOa6dtj9lIvDRULMUWMdD2q0iubjZeAQ43V6vX2KW7lrYs9Iu7k MmcJ6Egi4lIKI0JFroORCRW2BGLNCK5CIEraJuvvRLD7dWLs1aqqVIXS5CUaxoxkCewD H57g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=gjMu2+r5owLnFmOazrQkbMnjlqqaHZcryXpLkpK9okU=; b=RB2jhbM31k+VadvReQC+YCAR5zaxVWh+8vX7h/MuUn9kcCv+6+8kgMz6OUmHkpXrsJ TFaoTCYAOFR/UmgZfTt/Hqr6QFYHnK3o9Yh5HHwgpRKfwxqJ09/4fvMHVQjTv7+muIG7 MBVtkgEPBP7oJVJoaOJCqtLBAIc6Yx/NWPz15J0Sj7ncbAYy6kz5c3Y+CpJBZg4vp4JZ SD06af+Nj4gZQ4u+hvhYdXKZ4f3oHBunMc42u5iaFpK5K+hz70uEseQUNaa28/ByjXj6 5fYPtiL3n0yAGDNeUBRutyy/nrjwRA7kPrRdzsJDA65jkQtBa8G9mQY5V7k2fdD4xVbA kagA== X-Gm-Message-State: ALyK8tJvDq9uQKJz6rMF1EYEQfKu2U2vBsYjXyjFE1RiWU5MwYs/fG4Wmt8hA/1d1hOfllQY X-Received: by 10.28.37.195 with SMTP id l186mr8574906wml.23.1466603065175; Wed, 22 Jun 2016 06:44:25 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id j4sm73263630wjg.20.2016.06.22.06.44.24 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 22 Jun 2016 06:44:24 -0700 (PDT) From: Thomas Monjalon <thomas.monjalon@6wind.com> To: Neil Horman <nhorman@tuxdriver.com> Cc: Shreyansh Jain <shreyansh.jain@nxp.com>, dev@dpdk.org, viktorin@rehivetech.com Date: Wed, 22 Jun 2016 15:44:23 +0200 Message-ID: <3259828.fSm0GhbzkY@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20160622132752.GA6785@hmsreliant.think-freely.org> References: <1466510566-9240-1-git-send-email-shreyansh.jain@nxp.com> <1466586396-22618-10-git-send-email-shreyansh.jain@nxp.com> <20160622132752.GA6785@hmsreliant.think-freely.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v5 09/17] crypto: get rid of crypto driver register callback X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Wed, 22 Jun 2016 13:44:25 -0000 2016-06-22 09:27, Neil Horman: > > +++ b/lib/librte_cryptodev/rte_cryptodev_version.map > > - rte_cryptodev_pmd_driver_register; > NAK, you can't just remove exported symbols without going through the > deprecation process. Better still would be to only expose it for DPDK_16.04 and > hide it in the next release This function is not called by the application. Thus there is no ABI break.