From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 18E52A0A02; Thu, 25 Mar 2021 06:53:12 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 01CA2140E9A; Thu, 25 Mar 2021 06:53:12 +0100 (CET) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 8B352140E9A for ; Thu, 25 Mar 2021 06:53:10 +0100 (CET) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id E49407F40D; Thu, 25 Mar 2021 08:53:09 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru E49407F40D DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1616651590; bh=yAC5v51ve8Y5iSvZcvDCtKxnEwQoOqexUiNqcd0PFdQ=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=Ed+i1lHENWS/1xUftO0aS1S2fKAzYI63YVWYBo2J8/3GtZSovN1Xn4nQdGDMUu/Ww teZK89lZhGtnBfN4T35QI2YW19gwzeJcA/qjq4qy5Kkp/wxcFjTTrjZWIHKJYuaA+F fBgdXRiCz0lvmmSuNkjKxzDuloWXdJp7XqivjYgo= To: Thomas Monjalon , Ferruh Yigit Cc: dev@dpdk.org, Rosen Xu , Hemant Agrawal , Sachin Saxena , Jingjing Wu , Beilei Xing , Qiming Yang , Qi Zhang , Jeff Guo , Haiyue Wang References: <20210311221742.3750589-1-thomas@monjalon.net> <20210321090002.595744-3-thomas@monjalon.net> <6076825.RBgRJtLnUj@thomas> From: Andrew Rybchenko Organization: OKTET Labs Message-ID: <325e1d27-3729-0768-fc0d-ef89c1db9cf5@oktetlabs.ru> Date: Thu, 25 Mar 2021 08:53:09 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <6076825.RBgRJtLnUj@thomas> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 2/2] drivers/net: remove explicit include of legacy filtering X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 3/24/21 11:00 PM, Thomas Monjalon wrote: > 24/03/2021 19:08, Ferruh Yigit: >> On 3/21/2021 9:00 AM, Thomas Monjalon wrote: >>> The header file rte_eth_ctrl.h should not be needed because >>> this legacy filtering API is completely replaced with the rte_flow API. >>> However some definitions from this file are still used by some drivers, >>> but such usage is already covered by an implicit include via rte_ethdev.h. >>> >>> Signed-off-by: Thomas Monjalon >>> Acked-by: Rosen Xu >>> Acked-by: Hemant Agrawal >>> --- >>> drivers/net/dpaa2/dpaa2_ptp.c | 1 - >>> drivers/net/iavf/iavf_hash.c | 1 - >>> drivers/net/ice/ice_acl_filter.c | 1 - >>> drivers/net/ice/ice_hash.c | 1 - >>> drivers/net/ice/ice_switch_filter.c | 1 - >>> drivers/net/igc/igc_filter.h | 1 - >>> drivers/net/ipn3ke/ipn3ke_flow.c | 1 - >> >> Although this will work, if the above drives are using the defines from the >> header file, isn't it better to include it explicitly? >> >> What is the benefit of including the header implicitly? > > The benefit is to progressively remove rte_eth_ctrl.h. > I want it to disappear. > +1