From: Thomas Monjalon <thomas@monjalon.net>
To: David Harton <dharton@cisco.com>
Cc: dev@dpdk.org, harry.van.haaren@intel.com,
christian.ehrhardt@canonical.com
Subject: Re: [dpdk-dev] [PATCH v4 1/2] ethdev: add return code to rte_eth_stats_reset()
Date: Fri, 01 Sep 2017 00:16:57 +0200 [thread overview]
Message-ID: <3262696.ZUUiVqul2m@xps> (raw)
In-Reply-To: <20170810132952.26974-1-dharton@cisco.com>
10/08/2017 15:29, David Harton:
> Some devices do not support reset of eth stats. An application may
> need to know not to clear shadow stats if the device cannot.
Yes, thanks for improving this old API.
> rte_eth_stats_reset is updated to provide a return code to share
> whether the device supports reset or not.
You need to change also this line:
typedef void (*eth_stats_reset_t)(struct rte_eth_dev *dev);
And while at it, you could apply the same change to stats_get.
A device can be in a state where it is impossible to read stats.
The same kind of update could be needed for promiscuous and allmulticast
functions but they are out of the scope of this patch.
next prev parent reply other threads:[~2017-08-31 22:16 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-07 17:39 [dpdk-dev] [PATCH v3] " David Harton
2017-08-08 9:02 ` Van Haaren, Harry
2017-08-08 11:01 ` David Harton (dharton)
2017-08-08 11:03 ` Christian Ehrhardt
2017-08-08 13:13 ` Thomas Monjalon
2017-08-10 13:29 ` [dpdk-dev] [PATCH v4 1/2] " David Harton
2017-08-10 13:29 ` [dpdk-dev] [PATCH v4 2/2] doc: Update ABI Change for rte_eth_stats_reset David Harton
2017-08-31 22:10 ` Thomas Monjalon
2017-08-31 22:10 ` Thomas Monjalon
2017-08-31 22:16 ` Thomas Monjalon [this message]
2017-09-01 2:26 ` [dpdk-dev] [PATCH v5] ethdev: add return code to rte_eth_stats_reset() David Harton
2017-09-01 7:47 ` Hemant Agrawal
2017-09-19 17:14 ` Ferruh Yigit
2017-09-20 14:01 ` David Harton (dharton)
2017-09-20 16:55 ` Ferruh Yigit
2017-09-20 14:11 ` [dpdk-dev] [PATCH v6] " David C Harton
2017-09-20 16:56 ` Ferruh Yigit
2017-10-09 23:02 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3262696.ZUUiVqul2m@xps \
--to=thomas@monjalon.net \
--cc=christian.ehrhardt@canonical.com \
--cc=dev@dpdk.org \
--cc=dharton@cisco.com \
--cc=harry.van.haaren@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).