From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 4D4235689
 for <dev@dpdk.org>; Fri,  1 Sep 2017 00:16:59 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id 031FD21345;
 Thu, 31 Aug 2017 18:16:59 -0400 (EDT)
Received: from frontend1 ([10.202.2.160])
 by compute1.internal (MEProxy); Thu, 31 Aug 2017 18:16:59 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=1FlJACN3h/YWumr
 /vcaaYIXc8euPUPUlA01XNKDh8PQ=; b=VakxsRbn5htTOuDxcYnjEL2yxM+X7p2
 G6z4OGhreV1DB+jWRM+RQunK2MDCu5zkdfeISwiI5mDdxbAy2t16BjLrXsl5qyIE
 OqyX48KlKFI9Ew4uctOQeyNDGZWHBVWTJ7c9oA8YWCFvDsENYNW6DVduSmEDefUR
 L04pL+fklQZk=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s=
 fm1; bh=1FlJACN3h/YWumr/vcaaYIXc8euPUPUlA01XNKDh8PQ=; b=ONi+Ee1y
 UrAxiqcU1ymMUgLGFKkzZLHSp4wJ//yyhrNvL4j94bX8nNnaBR58r5F92yZvLDnP
 dtTdVnHvA8CGu8Vy6J2NidrvKeijvfVnryzUIfjkWySbAp0XRciNTbFKvnfGZ+KR
 cax65GHGCnT3ClbMbNOTeeqLKqueBCbBAd1EhEDLc2NaJBmNpWR3vDOHmSdzTl2U
 MzQMlECO0cCIF7FXTg6zgOHE/dnhhV3UNOJYGWDxSALY/nOUONHlMvkcFlNeUugp
 YrlV9gyXY11ZYLWNdZCwRz3dzVDFJWzQM4Q4gzwM2iXIhO0Nz8DDSpFZ+3tVPH96
 oSCZeZa5itfXkg==
X-ME-Sender: <xms:2oqoWVyJK-d1K1Map1Rl2ZY6_Sp1t0-nAkvQ4NuYwPoH_LjFECfBeA>
X-Sasl-enc: Dx3hDoX6HTc8z0FUhYM50ZqzzszCCdMXjERx3zxZArE9 1504217818
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id AA88F7F018;
 Thu, 31 Aug 2017 18:16:58 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: David Harton <dharton@cisco.com>
Cc: dev@dpdk.org, harry.van.haaren@intel.com, christian.ehrhardt@canonical.com
Date: Fri, 01 Sep 2017 00:16:57 +0200
Message-ID: <3262696.ZUUiVqul2m@xps>
In-Reply-To: <20170810132952.26974-1-dharton@cisco.com>
References: <20170807173914.36750-1-dharton@cisco.com>
 <20170810132952.26974-1-dharton@cisco.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v4 1/2] ethdev: add return code to
	rte_eth_stats_reset()
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 31 Aug 2017 22:16:59 -0000

10/08/2017 15:29, David Harton:
> Some devices do not support reset of eth stats.  An application may
> need to know not to clear shadow stats if the device cannot.

Yes, thanks for improving this old API.

> rte_eth_stats_reset is updated to provide a return code to share
> whether the device supports reset or not.

You need to change also this line:
typedef void (*eth_stats_reset_t)(struct rte_eth_dev *dev);

And while at it, you could apply the same change to stats_get.
A device can be in a state where it is impossible to read stats.

The same kind of update could be needed for promiscuous and allmulticast
functions but they are out of the scope of this patch.