* [dpdk-dev] [PATCH v1] testpmd: fix incorrect port_id word size
@ 2018-01-19 13:27 Remy Horton
2018-01-20 13:33 ` Ferruh Yigit
0 siblings, 1 reply; 3+ messages in thread
From: Remy Horton @ 2018-01-19 13:27 UTC (permalink / raw)
To: dev; +Cc: Wenzhuo Lu, Jingjing Wu
The word size of port_id is now 16 bits, but there were parsing directives
that assumed it was still of type UINT8, resulting in incorrect commandline
parse results.
Fixes: f14a210a65fe ("app: fix port id type")
Signed-off-by: Remy Horton <remy.horton@intel.com>
---
app/test-pmd/cmdline.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index f7d5bb0..14005d8 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -5837,7 +5837,7 @@ cmdline_parse_token_string_t cmd_setpromisc_portall =
"all");
cmdline_parse_token_num_t cmd_setpromisc_portnum =
TOKEN_NUM_INITIALIZER(struct cmd_set_promisc_mode_result, port_num,
- UINT8);
+ UINT16);
cmdline_parse_token_string_t cmd_setpromisc_mode =
TOKEN_STRING_INITIALIZER(struct cmd_set_promisc_mode_result, mode,
"on#off");
--
2.9.5
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH v1] testpmd: fix incorrect port_id word size
2018-01-19 13:27 [dpdk-dev] [PATCH v1] testpmd: fix incorrect port_id word size Remy Horton
@ 2018-01-20 13:33 ` Ferruh Yigit
2018-01-31 22:22 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Ferruh Yigit @ 2018-01-20 13:33 UTC (permalink / raw)
To: Remy Horton, dev; +Cc: Wenzhuo Lu, Jingjing Wu
On 1/19/2018 1:27 PM, Remy Horton wrote:
"app/testpmd: fix incorrect port id word size" ?
> The word size of port_id is now 16 bits, but there were parsing directives
> that assumed it was still of type UINT8, resulting in incorrect commandline
> parse results.
>
> Fixes: f14a210a65fe ("app: fix port id type")
Cc: stable@dpdk.org
> Signed-off-by: Remy Horton <remy.horton@intel.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH v1] testpmd: fix incorrect port_id word size
2018-01-20 13:33 ` Ferruh Yigit
@ 2018-01-31 22:22 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2018-01-31 22:22 UTC (permalink / raw)
To: Remy Horton; +Cc: dev, Ferruh Yigit, Wenzhuo Lu, Jingjing Wu
20/01/2018 14:33, Ferruh Yigit:
> On 1/19/2018 1:27 PM, Remy Horton wrote:
>
> "app/testpmd: fix incorrect port id word size" ?
>
> > The word size of port_id is now 16 bits, but there were parsing directives
> > that assumed it was still of type UINT8, resulting in incorrect commandline
> > parse results.
> >
> > Fixes: f14a210a65fe ("app: fix port id type")
>
> Cc: stable@dpdk.org
>
> > Signed-off-by: Remy Horton <remy.horton@intel.com>
>
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-01-31 22:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-19 13:27 [dpdk-dev] [PATCH v1] testpmd: fix incorrect port_id word size Remy Horton
2018-01-20 13:33 ` Ferruh Yigit
2018-01-31 22:22 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).