From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B6B7A4330F; Sun, 12 Nov 2023 15:05:25 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3CDE64021F; Sun, 12 Nov 2023 15:05:25 +0100 (CET) Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by mails.dpdk.org (Postfix) with ESMTP id 5460D4021E for ; Sun, 12 Nov 2023 15:05:23 +0100 (CET) Received: from compute7.internal (compute7.nyi.internal [10.202.2.48]) by mailout.west.internal (Postfix) with ESMTP id 03A6832002B6; Sun, 12 Nov 2023 09:05:21 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Sun, 12 Nov 2023 09:05:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1699797921; x=1699884321; bh=FR+EU03hSvHubO7cvJVmt5OkmdM+xXD4IsZ FJZfhKaE=; b=Jtw4mdj9ELPUp/ZyUD0XcbGtCrXNr4d4SN2wlNkCuKF0FYoVGW1 XvLiD4n+wyC0x9j/nlQx8BR2BuZETAdfc42GD7Eb8Zd5TyoZ88VrvJzbcckVDWtG xCg0I+LvHBVgeleIW2V4of9pOH7O8lD47vvhodktnWAOmt6ZF0wwYnvmE3CoBm9m iVIiiiEn3x8bELVRWbdRDr7+d/KaOSSPlM9k71gW6V/coPEaDExefADQ/cWvu4bF 4/tdm5tPdvRNWG9dHkC2nilMFmCdloJmHhnHuOIYa78wbhuI7BPQk92MJSs2mOHN 1SX2Q4l7IEkLEu8CPMwv8TN5J0YcBQ7Cn7g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1699797921; x=1699884321; bh=FR+EU03hSvHubO7cvJVmt5OkmdM+xXD4IsZ FJZfhKaE=; b=DbvZd6e4MqIgVk0xn2pMzys3rkovRI85f6+0MVpWnIHqG3XwJJ0 HVDHKPFhynv7sp78XzdyjzxZROv3E5UjWyz2lPyzvLWjqYbZ1bpWvPQ1RwHWPCQN 1J/j5CRPlVArUBxLD4y9YSVvjGxB5Lt4qfmZ1Q3hnVWxVjHVMMy1ZnG2MIa+TO/J qd8N75A48F2H9QhMYLJvq9AGVFCfr0wiQwn5+hprTM3KWhGDdB4L9175TvuP8zsf yKzOkqcTZ6WWL3zz1UAyzshr426izjAviUasN7jojU1Qb2OukapVAMVBayZI591A 0K3N/XejjG3ICLxg6d3bxr18pmyiFp9fdRw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedruddvkedgieduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthhqredttddtudenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpeefhfejleeuvdevtddutdeutdevhfeijeethfffueejhfetuddu vedtkedtieekffenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 12 Nov 2023 09:05:20 -0500 (EST) From: Thomas Monjalon To: Stephen Hemminger Cc: dev@dpdk.org, Morten =?ISO-8859-1?Q?Br=F8rup?= Subject: Re: [PATCH v3 ] dumpcap: fix mbuf pool ring type Date: Sun, 12 Nov 2023 15:05:18 +0100 Message-ID: <3264333.44csPzL39Z@thomas> In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35E9EFF8@smartserver.smartshare.dk> References: <20230804161604.61050-1-stephen@networkplumber.org> <20231108174738.185933-1-stephen@networkplumber.org> <98CBD80474FA8B44BF855DF32C47DC35E9EFF8@smartserver.smartshare.dk> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 09/11/2023 08:21, Morten Br=F8rup: > > From: Stephen Hemminger [mailto:stephen@networkplumber.org] > > Sent: Wednesday, 8 November 2023 18.48 > >=20 > > The internal buffer pool used for copies of mbufs captured > > needs to be thread safe. If capturing on multiple interfaces > > or multiple queues, the same pool will be used (consumers). > > And if the capture ring gets full, the queues will need > > to put back the capture buffer which leads to multiple producers. > >=20 > > Bugzilla ID: 1271 > > Fixes: cbb44143be74 ("app/dumpcap: add new packet capture application") > > Signed-off-by: Stephen Hemminger >=20 > Reviewed-by: Morten Br=F8rup Applied, thanks.