DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: dev@dpdk.org
Cc: declan.doherty@intel.com, ferruh.yigit@intel.com,
	arybchenko@solarflare.com, bruce.richardson@intel.com,
	olivier.matz@6wind.com
Subject: [dpdk-dev] ethdev flags and capabilities
Date: Tue, 01 May 2018 22:41:09 +0200	[thread overview]
Message-ID: <3264503.09g30QS5gu@xps> (raw)

Since DPDK 18.05-rc1, we have 2 new fields in rte_eth_dev_info:
	const uint32_t *dev_flags;
	uint64_t dev_capa;

The field dev_flags (http://dpdk.org/commit/736b30ebf2)
is a pointer to rte_eth_dev_data.dev_flags for these bits:
	RTE_ETH_DEV_INTR_LSC
	RTE_ETH_DEV_BONDED_SLAVE
	RTE_ETH_DEV_INTR_RMV
	RTE_ETH_DEV_REPRESENTOR

The field dev_capa (http://dpdk.org/commit/cac923cfea)
is an integer for these bits:
	RTE_ETH_DEV_CAPA_RUNTIME_RX_QUEUE_SETUP
	RTE_ETH_DEV_CAPA_RUNTIME_TX_QUEUE_SETUP

How can we merge them?
Should we move the capabilities in rte_eth_dev_data.dev_flags?
Or do we want to keep the capabilities in rte_eth_dev_info?
Is it OK to use pointers in rte_eth_dev_info or should we make a copy
of rte_eth_dev_data fields?

We need to take a decision before RC3. Thanks

             reply	other threads:[~2018-05-01 20:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-01 20:41 Thomas Monjalon [this message]
2018-05-02  5:28 ` Shahaf Shuler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3264503.09g30QS5gu@xps \
    --to=thomas@monjalon.net \
    --cc=arybchenko@solarflare.com \
    --cc=bruce.richardson@intel.com \
    --cc=declan.doherty@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=olivier.matz@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).