From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-f54.google.com (mail-lf0-f54.google.com [209.85.215.54]) by dpdk.org (Postfix) with ESMTP id EE5412B86 for ; Wed, 19 Oct 2016 14:26:21 +0200 (CEST) Received: by mail-lf0-f54.google.com with SMTP id b81so21879301lfe.1 for ; Wed, 19 Oct 2016 05:26:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=JEWSWcD/mV5EOvxFe9MmZXpxYSPk6CecNag9P9+rmqI=; b=wPh/zVCRwRRFGZqjLCW1Uoi9jPDgbOL84MsC9jMqhiQNheet5FXW4sDVyPEFCDexKq V2ZKcct1OFh8nzaMnYvplYk8GM0qHZlKPA5w+fKxzKjaYTGkXyfg8aBfBiNeVSXIfn6i JbmgGzgW/R0QoqaHvZm2E5z26eUIhOKA693qmj1DGnrlPd9JApSmZJNxXs74j6RKu3E/ 1A7rD8qJR6va+QKm34fS0EL7ylw/h9f595RevMC/T0VWQjavE+gtzEzxdOeaHyua/sd9 SJ726C208UER0YnWQV5nGARKpUQ3fIm9PCJiNtcPMXtcC7R4Gjq2TT7XVfrmh0Um7qFr YuVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=JEWSWcD/mV5EOvxFe9MmZXpxYSPk6CecNag9P9+rmqI=; b=NJuuMj627qENIshlPNCdcP8O8Vrb4xxpZBhjt0PeGCGksy1iyqVuvSI5NaGM1p3Noo Xp1ecAXdIFxdIUa60YERWy71xWRtZ14syfETJNfzDam0hE/8RKn+fywcp2uHdA7/JLdi kuBxXtUCA5XqrQDNNZn4m61LV1V9QtEeZKElRMbJy0ceY9qbcbGDhugTUNGg6hV4ESWS Xx0t3SEoP8PULNlSwBDn9uOzX4snlb/sObb0RK/m1EzrU/Fx8mUd4dLRFUBjArydah9r Jb4em9j1fcSlBsdEFYBKFN6plFkJpcnThpUrvpKCZjgdEOFBhprsQtCMSdRkvAiY7NNh T7iQ== X-Gm-Message-State: AA6/9Rk8sNEWpF4REG/10gdmu0RgU1MBFpWDWDETE5wsbiCrdjmPu7uwd2Vp04T280rU1pBJ X-Received: by 10.25.208.137 with SMTP id h131mr5174410lfg.94.1476879980646; Wed, 19 Oct 2016 05:26:20 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id m63sm10524769lfm.25.2016.10.19.05.26.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 19 Oct 2016 05:26:19 -0700 (PDT) From: Thomas Monjalon To: Yuanhan Liu Cc: Jan Blunck , "De Lara Guarch, Pablo" , dev@dpdk.org, "Mcnamara, John" Date: Wed, 19 Oct 2016 14:26:18 +0200 Message-ID: <3275371.bJj3maL3jb@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20161019100543.GQ16751@yliu-dev.sh.intel.com> References: <1472077494-164532-1-git-send-email-pablo.de.lara.guarch@intel.com> <7993435.bReMuqSN60@xps13> <20161019100543.GQ16751@yliu-dev.sh.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] drivers: make driver names consistent X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Oct 2016 12:26:22 -0000 2016-10-19 18:05, Yuanhan Liu: > On Tue, Oct 18, 2016 at 06:46:40PM +0200, Thomas Monjalon wrote: > > 2016-10-18 22:18, Yuanhan Liu: > > > On Tue, Oct 18, 2016 at 03:42:54PM +0200, Thomas Monjalon wrote: > > > > 2016-10-18 21:06, Yuanhan Liu: > > > > > On Tue, Oct 18, 2016 at 02:50:16PM +0200, Jan Blunck wrote: > > > > > > >From my understanding this is a massive API breakage. This forces all > > > > > > existing users of the virtual PMDs to change with zero benefit. Even > > > > > > if that isn't enough it also makes it impossible to switch between > > > > > > releases by recompiling. > > > > > > > > > > > > Can we please revert these changes and work on some aliasing support > > > > > > for the PMDs to fix it long term? > > > > > > > > > > +1. Aliasing is also something I would suggest before making such renames. > > > > > > > > It is a brutal change, yes. > > > > It was announced in 16.07 release notes though. > > > > > > Yes, but it still took me a while (by running git bisect) to figure out > > > what went wrong: I wasn't aware of such note, that I was thinking maybe > > > something is broken. > > > > > > Later I also got quite few same complains. It may also took them a while > > > to know what's happened. > > > > > > Anyway, my point is, for this kind of change, we should have added the > > > alias support firstly. > > > > Yes. > > > > > If that's been done, then the announcement is not > > > needed at all? > > > > The announcement would be needed to remove the aliases, later. > > Why do you have to remove an aliase? What's wrong if they stay there > forever. I think the naming will be switched (maybe slowly) when we > haved updated the doc (whereas it states "net_vhost" but not "eth_vhost" > only). > > After few releases, the name should have been switched fluently. And > we should not care about those alias. Yes I was just thinking removing dead code later. And it's generally simpler to end with only one way of doing things.