From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wg0-f46.google.com (mail-wg0-f46.google.com [74.125.82.46])
 by dpdk.org (Postfix) with ESMTP id 1DE865946
 for <dev@dpdk.org>; Thu, 28 Aug 2014 12:56:31 +0200 (CEST)
Received: by mail-wg0-f46.google.com with SMTP id x13so558849wgg.29
 for <dev@dpdk.org>; Thu, 28 Aug 2014 04:00:39 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=DbRyUfD5h/aQyn3IcCodZdz9U20z41JBGtJt6S0W97g=;
 b=KgthdCxp2iFsWeH7Vp0/pxaWj88h9lhKPx9sUz+K9HfYdCg0h9NoPWNfXy56lyw+Gp
 cK2CMoLH6OMfipX5pszBYYMOn3GgotP6cCAIrojb23tXoxKHdJplhNWfQuLMwWRcO7d1
 LjV2cDUtCELlO6cFpmbf2iCJYYpVZCLfOvEuR0DaOIJdziYYghHAG5an2t3H4C0dFOBs
 gPH28LXPTxuI2AUi8KWhOtSV8wK5gNAGinn8Ooit8906xIfTvAkXXcjthZ7M/J43qRde
 MHirKnkGvPMQ3Xtij/tcNqr4hAvC91K3zMGgiIZzFrDPZIaA4Dc/KVkiiWXl85ZMpl4r
 8Heg==
X-Gm-Message-State: ALoCoQkngxa+2G0IIaq+2P18NaHMtSnkPropzlmzt2cWeA+b8tZw4eVPOwn0WcGD3JLJMB3v5hr9
X-Received: by 10.180.186.98 with SMTP id fj2mr5740331wic.32.1409223639287;
 Thu, 28 Aug 2014 04:00:39 -0700 (PDT)
Received: from xps13.localnet (guy78-3-82-239-227-177.fbx.proxad.net.
 [82.239.227.177])
 by mx.google.com with ESMTPSA id l1sm13585033wia.8.2014.08.28.04.00.38
 for <multiple recipients>
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Thu, 28 Aug 2014 04:00:38 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Wu, Jingjing" <jingjing.wu@intel.com>
Date: Thu, 28 Aug 2014 13:00:33 +0200
Message-ID: <32773310.iMGaa2PpNO@xps13>
Organization: 6WIND
User-Agent: KMail/4.13.3 (Linux/3.15.8-1-ARCH; KDE/4.13.3; x86_64; ; )
In-Reply-To: <9BB6961774997848B5B42BEC655768F8ADC10D@SHSMSX104.ccr.corp.intel.com>
References: <1409105634-29980-1-git-send-email-jingjing.wu@intel.com>
 <6406194.6E43HquPHH@xps13>
 <9BB6961774997848B5B42BEC655768F8ADC10D@SHSMSX104.ccr.corp.intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2 7/7]app/testpmd: add commands and config
	functions for i40e flow director support
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 28 Aug 2014 10:56:31 -0000

2014-08-28 09:01, Wu, Jingjing:
> I have another question:
> If we use the way 'rx_classification_filter_ctl' works, the specific
> structures defined in rte_i40e.h will be visible in user's application,
> such as testpmd.
> I know I shouldn't make commands linked with i40e like what I did before.
> But will the i40e specific structures become visible be acceptable?

I think testpmd should be limited to generic API.
So it wouldn't be acceptable to be dependent of i40e files.
But having some specific i40e tests in examples or app/test is OK.

-- 
Thomas