DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Yangchao Zhou <zhouyates@gmail.com>
Cc: dev@dpdk.org, "De Lara Guarch,
	Pablo" <pablo.de.lara.guarch@intel.com>,
	Vladimir Medvedkin <medvedkinv@gmail.com>
Subject: Re: [dpdk-dev] [PATCH] hash: optimize the softrss computation
Date: Sat, 07 Oct 2017 00:31:24 +0200	[thread overview]
Message-ID: <32775928.OAvXbfsJxg@xps> (raw)
In-Reply-To: <E115CCD9D858EF4F90C690B0DCB4D8976CC23277@IRSMSX108.ger.corp.intel.com>

22/09/2017 17:33, De Lara Guarch, Pablo:
> From: Vladimir Medvedkin
> > 2017-08-22 15:02 GMT+03:00 Yangchao Zhou <zhouyates@gmail.com>:
> > 
> > > Use rte_bsf32 and fast bit unset operation to optimize the softrss
> > > computation.
> > > The following measurements shows improvement over the default softrss
> > > computation function.
> > >
> > > tuple lens old(cycles) new(cycles)
> > >     3        1225         337
> > >     9        3743         992
> > >
> > > Signed-off-by: Yangchao Zhou <zhouyates@gmail.com>
> 
> Commit message is a bit long. Could you wrap it to have less than 75 characters per line?
> Although, the patch itself has lines with more than 90 characters, which should be avoided:
> 
> http://dpdk.org/ml/archives/test-report/2017-August/027283.html
> 
> Last thing, the "Reviewed-by" has an extra space, before the name.

Applied, thanks

      reply	other threads:[~2017-10-06 22:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-22 12:02 Yangchao Zhou
2017-08-22 15:57 ` Vladimir Medvedkin
2017-09-22 15:33   ` De Lara Guarch, Pablo
2017-10-06 22:31     ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=32775928.OAvXbfsJxg@xps \
    --to=thomas@monjalon.net \
    --cc=dev@dpdk.org \
    --cc=medvedkinv@gmail.com \
    --cc=pablo.de.lara.guarch@intel.com \
    --cc=zhouyates@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).