From: Thomas Monjalon <thomas@monjalon.net>
To: Suanming Mou <suanmingm@nvidia.com>
Cc: ferruh.yigit@amd.com, Ori Kam <orika@nvidia.com>,
Aman Singh <aman.deep.singh@intel.com>,
Yuying Zhang <yuying.zhang@intel.com>,
Dariusz Sosnowski <dsosnowski@nvidia.com>,
Viacheslav Ovsiienko <viacheslavo@nvidia.com>,
Matan Azrad <matan@nvidia.com>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
dev@dpdk.org
Subject: Re: [PATCH v6 1/3] ethdev: rename action modify field data structure
Date: Mon, 05 Feb 2024 12:23:16 +0100 [thread overview]
Message-ID: <3279240.44csPzL39Z@thomas> (raw)
In-Reply-To: <20240202004234.503097-2-suanmingm@nvidia.com>
02/02/2024 01:42, Suanming Mou:
> --- a/doc/guides/rel_notes/release_24_03.rst
> +++ b/doc/guides/rel_notes/release_24_03.rst
> @@ -124,6 +124,8 @@ ABI Changes
>
> * No ABI change that would break compatibility with 23.11.
>
> +* ethdev: Rename the experimental ``struct rte_flow_action_modify_data`` to be ``struct rte_flow_field_data``
It should be in API change section.
Please us past tense as recommened in comments in the file.
> --- a/lib/ethdev/rte_flow.h
> +++ b/lib/ethdev/rte_flow.h
> @@ -3894,6 +3894,7 @@ struct rte_flow_action_ethdev {
>
> /**
> * Field IDs for MODIFY_FIELD action.
> + * e.g. the packet field IDs used in RTE_FLOW_ACTION_TYPE_MODIFY_FIELD.
Better to give the full name in the first line,
so no need to add a second line of comment.
[...]
> - * Field description for MODIFY_FIELD action.
> + * Field description for packet field.
> + * e.g. the packet fields used in RTE_FLOW_ACTION_TYPE_MODIFY_FIELD.
Same here, can be one simple line with full name.
next prev parent reply other threads:[~2024-02-05 11:23 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-14 3:12 [PATCH 0/2] ethdev: add RTE_FLOW_ITEM_TYPE_COMPARE Suanming Mou
2023-12-14 3:12 ` [PATCH 1/2] " Suanming Mou
2023-12-14 3:12 ` [PATCH 2/2] net/mlx5: add compare item support Suanming Mou
2023-12-19 1:33 ` [PATCH v2 0/3] [PATCH 0/2] ethdev: add RTE_FLOW_ITEM_TYPE_COMPARE Suanming Mou
2023-12-19 1:33 ` [PATCH v2 1/3] ethdev: rename action modify field data structure Suanming Mou
2024-01-09 14:07 ` Ori Kam
2024-01-12 8:03 ` Andrew Rybchenko
2023-12-19 1:33 ` [PATCH v2 2/3] ethdev: add compare item Suanming Mou
2024-01-09 14:26 ` Ori Kam
2024-01-12 8:11 ` Andrew Rybchenko
2024-01-15 8:14 ` Suanming Mou
2023-12-19 1:33 ` [PATCH v2 3/3] net/mlx5: add compare item support Suanming Mou
2024-01-09 14:28 ` Ori Kam
2024-01-15 9:13 ` [PATCH v3 0/3] ethdev: add RTE_FLOW_ITEM_TYPE_COMPARE Suanming Mou
2024-01-15 9:13 ` [PATCH v3 1/3] ethdev: rename action modify field data structure Suanming Mou
2024-01-30 17:19 ` Ferruh Yigit
2024-01-31 2:57 ` Suanming Mou
2024-02-01 10:56 ` Ferruh Yigit
2024-02-01 11:09 ` Suanming Mou
2024-02-01 11:20 ` Ferruh Yigit
2024-02-01 11:39 ` Suanming Mou
2024-01-15 9:13 ` [PATCH v3 2/3] ethdev: add compare item Suanming Mou
2024-01-30 17:33 ` Ferruh Yigit
2024-01-31 2:47 ` Suanming Mou
2024-01-31 15:56 ` Ori Kam
2024-01-31 16:46 ` Ferruh Yigit
2024-01-31 17:43 ` Ori Kam
2024-01-31 17:54 ` Ferruh Yigit
2024-02-01 6:51 ` Ori Kam
2024-02-01 0:31 ` Suanming Mou
2024-01-15 9:13 ` [PATCH v3 3/3] net/mlx5: add compare item support Suanming Mou
2024-02-01 2:30 ` [PATCH v4 0/3] ethdev: add RTE_FLOW_ITEM_TYPE_COMPARE Suanming Mou
2024-02-01 2:30 ` [PATCH v4 1/3] ethdev: rename action modify field data structure Suanming Mou
2024-02-01 2:30 ` [PATCH v4 2/3] ethdev: add compare item Suanming Mou
2024-02-01 2:30 ` [PATCH v4 3/3] net/mlx5: add compare item support Suanming Mou
2024-02-01 12:29 ` [PATCH v5 0/3] ethdev: add RTE_FLOW_ITEM_TYPE_COMPARE Suanming Mou
2024-02-01 12:29 ` [PATCH v5 1/3] ethdev: rename action modify field data structure Suanming Mou
2024-02-01 18:57 ` Ferruh Yigit
2024-02-01 12:29 ` [PATCH v5 2/3] ethdev: add compare item Suanming Mou
2024-02-01 18:57 ` Ferruh Yigit
2024-02-01 12:29 ` [PATCH v5 3/3] net/mlx5: add compare item support Suanming Mou
2024-02-01 18:57 ` Ferruh Yigit
2024-02-01 18:56 ` [PATCH v5 0/3] ethdev: add RTE_FLOW_ITEM_TYPE_COMPARE Ferruh Yigit
2024-02-02 0:32 ` Suanming Mou
2024-02-02 0:42 ` [PATCH v6 " Suanming Mou
2024-02-02 0:42 ` [PATCH v6 1/3] ethdev: rename action modify field data structure Suanming Mou
2024-02-05 11:23 ` Thomas Monjalon [this message]
2024-02-05 11:49 ` Suanming Mou
2024-02-05 12:39 ` Thomas Monjalon
2024-02-05 12:53 ` Suanming Mou
2024-02-02 0:42 ` [PATCH v6 2/3] ethdev: add compare item Suanming Mou
2024-02-05 13:00 ` Thomas Monjalon
2024-02-05 13:28 ` Suanming Mou
2024-02-05 14:09 ` Thomas Monjalon
2024-02-06 1:26 ` Suanming Mou
2024-02-02 0:42 ` [PATCH v6 3/3] net/mlx5: add compare item support Suanming Mou
2024-02-06 2:06 ` [PATCH v7 0/4] ethdev: add RTE_FLOW_ITEM_TYPE_COMPARE Suanming Mou
2024-02-06 2:06 ` [PATCH v7 1/4] ethdev: rename action modify field data structure Suanming Mou
2024-02-06 21:23 ` Ferruh Yigit
2024-02-06 2:06 ` [PATCH v7 2/4] ethdev: move flow field data structures Suanming Mou
2024-02-06 21:23 ` Ferruh Yigit
2024-02-06 2:06 ` [PATCH v7 3/4] ethdev: add compare item Suanming Mou
2024-02-06 21:24 ` Ferruh Yigit
2024-02-06 2:06 ` [PATCH v7 4/4] net/mlx5: add compare item support Suanming Mou
2024-02-06 21:23 ` Ferruh Yigit
2024-02-06 21:24 ` [PATCH v7 0/4] ethdev: add RTE_FLOW_ITEM_TYPE_COMPARE Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3279240.44csPzL39Z@thomas \
--to=thomas@monjalon.net \
--cc=aman.deep.singh@intel.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=dsosnowski@nvidia.com \
--cc=ferruh.yigit@amd.com \
--cc=matan@nvidia.com \
--cc=orika@nvidia.com \
--cc=suanmingm@nvidia.com \
--cc=viacheslavo@nvidia.com \
--cc=yuying.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).