From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8CEB543A77; Mon, 5 Feb 2024 12:23:25 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 109F2402BE; Mon, 5 Feb 2024 12:23:25 +0100 (CET) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id DDCC0402A2 for ; Mon, 5 Feb 2024 12:23:23 +0100 (CET) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 2342F5C006C; Mon, 5 Feb 2024 06:23:23 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Mon, 05 Feb 2024 06:23:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1707132203; x=1707218603; bh=IRBi19FfwDAz6joHnuET31KaWXZEDH4or9T4uVchgFU=; b= N2q88amt33o3d5bJ3W3xlapx36VYMbSQG/E8qtDl75IXIaFD8Sd/RQ308z1eJ9Cm s5J3Xopmd/FY3q2HKEL3w47rIQeU8Odoo9Fb1/9ADl8sxyh8a+wfCSmYEH3mKHGa iSBMd1qaJsuMpqTYmKLxkXKQ/UD8coS8Hlh2XF5AhRQ2FyeYMcFmIhfxbVb5us5A tnaSVqNZ0/v+th3CJEVQQl0J4VPTwvdrGDicKiIgzJzRnFiqDZg1xgAEETuc1GtG 6bHOGqSqGxF38QvL/InOVp4DBBDKG0DHDciLmeDyF6Uh6svFa7HYIJf+MS6oi7pr vlMRhIrgiZCEqbVI+zE0HQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1707132203; x= 1707218603; bh=IRBi19FfwDAz6joHnuET31KaWXZEDH4or9T4uVchgFU=; b=A 3TYrijHkT1fpR0/YGZ92ssnv4w94VZPw+aXA7gQCGhlUPektMeHTxg+7agjtv82e sOBL3YskIHAlRNoWQbfZRoDGlwV9tmbm+Ny2SG3CGI83VzpWugc7W8mlpK9E9wMQ ORXfcLK1mM5Am+wUpzpGVPwsK3a+ER6VbKo5obf7rZ0lDKCE8uOxv2x6F1TOSfUh DtbZZsli1TDrD1pVKntooDlDCokDLCU0gZWlQrxMykQhIJYvqA0ITAk2JmIx5L3T 7FKEX6ye15mRkhq1XvOtrs5MhuEkfaF724yN+eZAgzNvxxu4h64+Zdrpr4+0bbdh N71tv1W5qagolOOpMnO1w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrfedvtddgvdekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 5 Feb 2024 06:23:20 -0500 (EST) From: Thomas Monjalon To: Suanming Mou Cc: ferruh.yigit@amd.com, Ori Kam , Aman Singh , Yuying Zhang , Dariusz Sosnowski , Viacheslav Ovsiienko , Matan Azrad , Andrew Rybchenko , dev@dpdk.org Subject: Re: [PATCH v6 1/3] ethdev: rename action modify field data structure Date: Mon, 05 Feb 2024 12:23:16 +0100 Message-ID: <3279240.44csPzL39Z@thomas> In-Reply-To: <20240202004234.503097-2-suanmingm@nvidia.com> References: <20231214031227.363911-1-suanmingm@nvidia.com> <20240202004234.503097-1-suanmingm@nvidia.com> <20240202004234.503097-2-suanmingm@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 02/02/2024 01:42, Suanming Mou: > --- a/doc/guides/rel_notes/release_24_03.rst > +++ b/doc/guides/rel_notes/release_24_03.rst > @@ -124,6 +124,8 @@ ABI Changes > > * No ABI change that would break compatibility with 23.11. > > +* ethdev: Rename the experimental ``struct rte_flow_action_modify_data`` to be ``struct rte_flow_field_data`` It should be in API change section. Please us past tense as recommened in comments in the file. > --- a/lib/ethdev/rte_flow.h > +++ b/lib/ethdev/rte_flow.h > @@ -3894,6 +3894,7 @@ struct rte_flow_action_ethdev { > > /** > * Field IDs for MODIFY_FIELD action. > + * e.g. the packet field IDs used in RTE_FLOW_ACTION_TYPE_MODIFY_FIELD. Better to give the full name in the first line, so no need to add a second line of comment. [...] > - * Field description for MODIFY_FIELD action. > + * Field description for packet field. > + * e.g. the packet fields used in RTE_FLOW_ACTION_TYPE_MODIFY_FIELD. Same here, can be one simple line with full name.