From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6AFD845B52; Wed, 16 Oct 2024 18:00:18 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 46D8740150; Wed, 16 Oct 2024 18:00:18 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) by mails.dpdk.org (Postfix) with ESMTP id B4BB1400D6 for ; Wed, 16 Oct 2024 18:00:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1729094417; x=1760630417; h=message-id:date:subject:to:cc:references:from: in-reply-to:mime-version; bh=25levLJ7S1PNV35KOfVRcMvscBIsJnBCEkC+d27F7RA=; b=cR1E776S5mSSuRdt1y+hzx2H9zRibvN/VitY7sCkfrhpbyhhKcs/WiBY VLWpvkFypNMmRJ9jRT8mwGTBnHx4As0U9LxEQ2fFGzFIIhNDMkt4LWtta 1vjOtJdBVW0zE2h8Wh6UM0oofCTZEDjG0RW6p1TnWpPSwGE5gOI1bs/j6 I355pB5sPrtfVPH1ZJUz4HBQTgosaJaFAsKeybkFFFjHvGe4Pj1saj23Y gs9mm+a10i0w12YWr6RFWmZVeekNR7tSH0FthFXSk1gAinzYFSx5QJg6B 5WjlGm7WPTtBqyyn2Jejz3ZWjN4AZi109k6trmXcvtJN2AkyeDtK7+Piz Q==; X-CSE-ConnectionGUID: WbhPLXfdScCUyc/9SqBl3g== X-CSE-MsgGUID: bcqaDDcpQS2iGdqMEFNTqA== X-IronPort-AV: E=McAfee;i="6700,10204,11226"; a="32475451" X-IronPort-AV: E=Sophos;i="6.11,208,1725346800"; d="scan'208,217";a="32475451" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Oct 2024 09:00:05 -0700 X-CSE-ConnectionGUID: U3PUP2lsRrCAvU6jpCBg6A== X-CSE-MsgGUID: oZKx7YNIT6euPw8MgbgwtQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,208,1725346800"; d="scan'208,217";a="109068278" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orviesa002.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 16 Oct 2024 08:59:59 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 16 Oct 2024 08:59:56 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Wed, 16 Oct 2024 08:59:56 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.175) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Wed, 16 Oct 2024 08:59:56 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=g+IQDPEEYZKmmBCpZrs45MpzYO6d53BW6tCGFZCVfGQXbH8nuL0hcVeijAn3A/YOYfIAs3yoQupXVzpuqE5iQjfG/d7Bx/tco4bQf8ksTWE9D3HSQEhJmodrDq8nEEukH1lrxiHP5+5LzQbQraDFULusyOR0KeBdrG16fvUgw66F1RZcIZWYQ6Y1C4orhE2njjN3Qw44qw5BZHw4PdTQ1E97z9vyzA1sX7kG+iPZeV68tJcVX92LCct6dgIYSxdXZgI5YRoMXxbqYpTeKjEAVjUaIRrxAFKjmCo5f8Hu30E93hTSzPaFmB+F+47mjiWnlImfWTDlgpzb0jBsAYby1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=n2QPdq6fbzjQSGOMxognj2+LhxfEWlYS2dAM/PUQjFU=; b=wHVh9cYoVSTR6qCFmXbsCLwNUON4irsoI8TBGheRYDxhssOR2U7B0cVjMSQXQhDdcQdqKoD/ZF3/DG7fdXwa1bD8YIBfTdAHKOAM1N32eg3VyIfDeAekSnBZTVtxz4rdtNKVPI3iNQrtOQkCGHN9m1x1k+zLw7EWporPWTRO8FGcCsAPYgabhqXwNjAFkHb/YEMb1a27MdlHCSBPK2YXLbv49UEkYIAEs5uGF2ugt99Z//+bueQqlaAxT5D+RRPluSll1g57++V63qDV6ehJMJr+90MYoS3/ffx0zL5wLqQMC94QACcWrWQj7mn+VNiJvkpzNjIuplB1TS5xDKdDKw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH7PR11MB5765.namprd11.prod.outlook.com (2603:10b6:510:139::7) by DS0PR11MB7444.namprd11.prod.outlook.com (2603:10b6:8:146::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8048.25; Wed, 16 Oct 2024 15:59:53 +0000 Received: from PH7PR11MB5765.namprd11.prod.outlook.com ([fe80::fcf5:d65c:4fdd:4a2a]) by PH7PR11MB5765.namprd11.prod.outlook.com ([fe80::fcf5:d65c:4fdd:4a2a%3]) with mapi id 15.20.8048.020; Wed, 16 Oct 2024 15:59:53 +0000 Content-Type: multipart/alternative; boundary="------------qvUzj7ZxECI7VS409ZJ5y2v6" Message-ID: <32794ecc-51f7-49db-af7f-0dd0c612448e@intel.com> Date: Wed, 16 Oct 2024 16:59:48 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] fib: fix return value behavior To: Stephen Hemminger CC: , References: <20241015171143.497709-1-vladimir.medvedkin@intel.com> <20241015222938.359f7193@hermes.local> Content-Language: en-US From: "Medvedkin, Vladimir" In-Reply-To: <20241015222938.359f7193@hermes.local> X-ClientProxiedBy: WA0P291CA0002.POLP291.PROD.OUTLOOK.COM (2603:10a6:1d0:1::29) To PH7PR11MB5765.namprd11.prod.outlook.com (2603:10b6:510:139::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH7PR11MB5765:EE_|DS0PR11MB7444:EE_ X-MS-Office365-Filtering-Correlation-Id: a533bc5b-dc34-4a43-9565-08dcedfb9286 X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|366016|8096899003; X-Microsoft-Antispam-Message-Info: =?utf-8?B?VGQrWnZOTlBpMENtNDBMeFcxZWJ0US9BdythUTgrQWdqSnA4NVpGVUR0VXRx?= =?utf-8?B?ak9rRG1mMnhUTkxhNGd0Uk1QcWRRVUFrWWhRWXdMaWtCc251RFhNUEhGUnEy?= =?utf-8?B?NVdoVmcvTzlYd1N5L3FYdGF0b1lyWHhtaVl4aEZVdkpmaWJaWFYvT3Z4azht?= =?utf-8?B?NUVaWm5Gb0RhREcyT1BsdlF5a3psdVlWR254STEwNnFmbWhyVkIxVlB5a3ZV?= =?utf-8?B?Mm1BdjZoNUpHWXZGMkVxdlJTT0FmRXhTS0JTMTE3dUxLbVk0Rmt3K3R0aDBB?= =?utf-8?B?Z3E4S2hvMEJKSUVaaU9uOHVnTWV4WVc5MlBWYkpKc1A2UlBoWFU0UUZuRDZJ?= =?utf-8?B?eEU2dkRDM3FxKzlFMnJXSXY3US9ZSXRnSFRwTmdxT09vY2FWbXRLWVl0S05E?= =?utf-8?B?YVRsS2E0VWxMS25kRzcvMEpxOEtKMUJWK01ueXN6cFdtTmdXMGRkR3Z4NlJB?= =?utf-8?B?aHdBSDJlS0JvbmdRNGdWaGVmbkR5UHExbVoxeVEzZ2JLblFJd0xvU2FFTXF1?= =?utf-8?B?OGdPT2xjWXFnWDc5eldoQ0o1MWVsaUJ0NWl6V1JVNGhBNFhsZStHeFl5ZU9D?= =?utf-8?B?bHFweXZrT09NdkYwTERINmRyd3h5U2xYNHppL1JNY2g3ZUg0cTRkd3M4cFI3?= =?utf-8?B?b0VWclV1Y283d1B0MEhtU2JCcUZiU2ZuYUtmZUNuMnBKa2J1TFkvMEhGUERO?= =?utf-8?B?c0YvYitibEdxVi9OMWYvNjhia21yN25mVzc3SjJDOEpmR3R1cGNWMjY3V2d4?= =?utf-8?B?SDNjVEplcmRqUWVDWCtCeSswMy9iejVJSGhFL09aMWlDWjdvSmJ5QldsdUN1?= =?utf-8?B?aTVkZHRKcDJsNU1wTGIzQzBKeFpKem5nd2VVcjE2N3VSRGZvbk5LMUc5cGpD?= =?utf-8?B?SmpSNG9mNXBHaURXbXUvSU1xd25NVXpWMnRWMmcwbWJJRlN2S2ZYd1hrV3NE?= =?utf-8?B?NzlyRFl4bzh3QlI1ajBZeGx2S09oUGw0bDV2aTBrbFJka2FEcUxzYXNNZGl6?= =?utf-8?B?bEJEVGZGNGhMY0VLdk9nczZQSEpBUmZSeDRxeVJmbHluMHpSRFpnY3FxRUVS?= =?utf-8?B?bGUrTmMxMzE1K1lBOWI1dnBpQ1ErYUc4RkdUQkwydmVrNkNRVHY5NlhFOWJR?= =?utf-8?B?enZwb2x0M3c3bXdOOVVCdi9IS3pYdTBWVVRXaExNcFNMclNUZ01CMFVldVFw?= =?utf-8?B?WDZ1akFTSURqa3FGUFJ0M2xWRVdLZVExNnRXOWI4M3l5UENuWXFkTXVXMDBy?= =?utf-8?B?TnZHS3lvRFJNUldvK2pGTExKUHJqc0hVK2V1RDBnTEdNak1JUHI3cC9VTTlv?= =?utf-8?B?TjJ4V2ZINGFDWll0ZHNXL3gzTW1PeU96NCtySExad3BnMUJRYnFRdWxiZERX?= =?utf-8?B?YWZ5a2hNemFRQS9MNW1yVHJTU25FMW1qSVp4anlKZzFCTnpUMzRPTVVNN3BI?= =?utf-8?B?ejRZaTNIeGw3QUlvQndRcWpvRFNFcU5lOGRlVHJRRUYyMEhvRTVQY1M1TWdz?= =?utf-8?B?aVo2bkFoZEx0WGxSU2hxQ0U4aU5UVWpXMnNwdWNNRUZ2K1lnRDFCa0RUekN6?= =?utf-8?B?emJybUlZQW1BVEQ2bUN2eVVkQ1QvZUZYYVc5Q0srdGhXNWxzNHpnWUV1UUt5?= =?utf-8?B?YlFiTlIyRzVSbiszRjg1V3M5VmdzV0gyVUNxMnl6Rkdrc1p5RVB4a3c2NVNG?= =?utf-8?B?WnI3aEczNTF0RWJmSW9yZ1dHS3d2TVFnV1prSUhNaDhkMXNrN3h1Y1p3PT0=?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH7PR11MB5765.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(366016)(8096899003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TkV3SExwTDVkU0FmNmg1ZGsweEY0ZGduVWZtWk9meHppU0VZOExuaXAvS1FU?= =?utf-8?B?UUdKY1Z2dGM3VENPNkZMS2dCNWI4K3YyL2RvT29XYVdud0hGdXZGQlozR0lJ?= =?utf-8?B?bjNsR0VxM0VQZW4xVnF0dEl6U0tLTmVpOFR0QVlCbWhWMkFJTGh6c0ZYc2Jy?= =?utf-8?B?UWZ2N3BnYmxCWmViZUFMZDIyMjhhQ0VEbGV6OENma0FteURCWVVMOXFrL2lO?= =?utf-8?B?bGRJak9nNXdmT0xVNHgrWXRtMGNwcEI0VkRpVEJUVWNsWWlpNG1FVDNYaVlS?= =?utf-8?B?a3pmOTFmem8vaXVWQjBKWEpsSHZnWG5VMzc3U0lwTHByWjgvVVR0VXBDOHVQ?= =?utf-8?B?b2x4dE5NK3gwMG5sQ0QwTHJ1VHN4UWpZN0NhSVZ1eXdZQXRQRERqSVhOSkJG?= =?utf-8?B?d2xUTmt3SGdRYktBUGNDSHM1WThDRWgzU2RkcnVmOHBsTFEwbzRRSFppWHJ0?= =?utf-8?B?Z29jNmhnYWNzNlpXUm9mdHBnYlR2UkpyeUtBRkRtU3JidnhxK3RCM05vZjNZ?= =?utf-8?B?eDc0RHZKbjFnVDNEcFhoenl4dDN1cTYrRWg2MWxVZ2RNZ2VNN2hLR1RwRjhs?= =?utf-8?B?U1BObkRqbytDUEtWTWgybGl6d1VaVUxwc0hvYXBxaHllbEJLNkVleXkyQUlL?= =?utf-8?B?QnRuSWJ0YUZnM2pRY0JyanlEQ2FObVB6SmFpNTN4dXdBdjBBZUtlRUNzSjF5?= =?utf-8?B?M0FteWc5ZUJEckdGT1hOTE55b0U5Z2hUNTVTbStKOGliVGZ5cy85OHFoV3BU?= =?utf-8?B?Q2YvcC9jV2pGREJ3d1M2OWJ0MGJGK0xZam5xNm9OcWNxemJiV1RtOWlpMWpt?= =?utf-8?B?MlA3OUJwWTJRTGhLd2hWUjBzVUVPcVRMRmF1aEZmL2E4Tm9NYkIzV3NGQmhz?= =?utf-8?B?UXpSUWNFU3o2U1lNVmtJT0t5MjZGWStWRUJ2K2FmdzlFQ2FUN0RoVXFTeEJz?= =?utf-8?B?TzhSSlJhUGduRnhNN3hSZTgyekZ6ZFpCU0lsaEZiU0RTNTFRTmdCak1kRWt2?= =?utf-8?B?Tld3RmRpVmp1bHVRUzJCc1FzRUpQUzZVa0J4a2tLdG9qU0xCZjRrM0pRY1Js?= =?utf-8?B?VEVBTVB6RGdRZm5BK1N2L3VMTms4OVE4WVFKYUJlTzBUd3ZoRDh0bUhBQ3Rs?= =?utf-8?B?K21XZjIzenpPZGFrek5LY2psNTluaFhuU0tUYktTOFFEME5qblo1cW54ckZI?= =?utf-8?B?a2h4c2tFQmkzRGZpenpHVm4rVloxRXZuMFIwN0tnQ1psV1VzTTFzU0dHVmtM?= =?utf-8?B?SDY0RVlOcHJWRGV4SXBYL3hSK28zL3dsOUpNM1NxNzhYRjhUTDc3aGRNdi9F?= =?utf-8?B?UUxXeTQvK3NFdC8rVFB3d1diSUZ2VmdNMG1FWUcycnVYdGx2R2FZaGM0T1lZ?= =?utf-8?B?cVI0TjdySDZJRlB1clY0WnBxVWZzOEpNVlM3TzFkdlJZekxjbGxDVFNha0hY?= =?utf-8?B?ZGthRmVxSHhieWwxU3V4WUFUeWVHUFZlZUpSU2IrdWdXbEVaNFcwNW9hOEZo?= =?utf-8?B?NnhHSEMyTmpLeE04ajk1VjVTNXMwWHQvQTdzYXFHSVVIOERIQ20wNVl6K2hl?= =?utf-8?B?TmdURk9rcFFtbUtGTEZQT3ZpbU5KZXRKcGFpbjhsaTliczJsYmVGMWZUS29S?= =?utf-8?B?dkVlTFBMV2Z3ck9qTE1ZUXlTdEROdFljUzBudGg0NWZyakhxYlF0TFdqZ21F?= =?utf-8?B?ZnZQSmdOVDdSNjZRNGQ5NnAwVHBXMERQR09BMm9jNFZjRyt0ejdaei9XdDQ3?= =?utf-8?B?bzdLRkY3bWtmS0FqL0Q3VWFkNUVZcDVUQlRlZzNFa0tmVWc3Y1JSaXpvUzVw?= =?utf-8?B?NzEzUlFEc1RMQmRmN294c1hGRUphRGpEd0h2T3Y2TVM0N3loakRMUVV4QkEz?= =?utf-8?B?WjVSNlBXOXM2OWFnWW1ELytiQVBxM0NuWDV3S2dudlVRekNtaE0ybkszdWhr?= =?utf-8?B?Q2hxNG5SZzNOeDB1WWtUK003ekVndlAvSHkwNHRGOG5UdmM0RWJQUS9MMFlC?= =?utf-8?B?T3ZUaFd0SVRmcXdTU0xsM0xhS3RXY3drV0JkT1FUWkhORDNGYmhXMmVVSVVw?= =?utf-8?B?aWNkckZjWEtRZFlIQ2V2MXFMbVB1NEFoV1YvL3dEVFdBNXlDU2dOQzlCb1VO?= =?utf-8?B?c1p0NHlrVmw2TUJsL0x3cnRQdWZjYWw1TXY1MjVNeXV6OXRDS3JsaG1PYUZ6?= =?utf-8?B?a0E9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: a533bc5b-dc34-4a43-9565-08dcedfb9286 X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB5765.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2024 15:59:53.3351 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3gyTXxUoofuOJegnxvfAtpQGIHt0WjK27rdixedJChDxZGwvydD7VzCYqaNboOjF9lFMPHcJa8BjI4SaNQqfhRsWRwEh/HrHJWDaqoF3X6M= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7444 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --------------qvUzj7ZxECI7VS409ZJ5y2v6 Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit Hi Stephen, On 16/10/2024 06:29, Stephen Hemminger wrote: > On Tue, 15 Oct 2024 17:11:43 +0000 > Vladimir Medvedkin wrote: > >> Fixes the behavior of the rte_fib_rcu_qsbr_add() function regarding its >> return value to align with the existing rte_fib API. >> >> Fixes: 96c3d06a3547 ("fib: implement RCU rule reclamation") >> >> Signed-off-by: Vladimir Medvedkin >> --- > Looks good, although DPDK often uses rte_errno, it is better for this part > in fib to be consistent across rcu and non-rcu variants. Iwouldpreferit tobeconsistentwith the restof the FIBAPI. > PS: there don't seem to be any negative tests on this function in test_fib.c > would be good to hit some of the basics. maybeIdidn'tquiteunderstandyou,butthere is basic negative teston thisfunction (plz see test_invalid_rcu() test) > > Reviewed-by: Stephen Hemminger -- Regards, Vladimir --------------qvUzj7ZxECI7VS409ZJ5y2v6 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Hi Stephen,

On 16/10/2024 06:29, Stephen Hemminger wrote:
On Tue, 15 Oct 2024 17:11:43 +=
0000
Vladimir Medvedkin <vladimir.medvedkin@intel.com> wrote:


Fixes the behavior of the rt=
e_fib_rcu_qsbr_add() function regarding its
return value to align with the existing rte_fib API.

Fixes: 96c3d06a3547 ("fib: implement RCU rule reclamation")

Signed-off-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com&g=
t;
---

Looks good, although DPDK often uses rte_errno, it is better for this part
in fib to be consistent across rcu and non-rcu variants.
I would prefer = it tobeconsistent with the rest of the FIB API. 
PS: there don't seem to be any negative tests on this function in test_fib.=
c
would be good to hit some of the basics.
maybe <= /span>I di= dn't quite understand you, but there is basic negative test on this function (plz see test_invalid_rcu() test)

Reviewed-by: Stephen Hemminger <stephen@networkplumber.org>

--=20
Regards,
Vladimir
--------------qvUzj7ZxECI7VS409ZJ5y2v6--