* [dpdk-dev] [PATCH] pmdinfogen: fix clang build error
@ 2016-09-28 10:05 Ferruh Yigit
2016-09-28 11:35 ` Neil Horman
2016-10-04 9:48 ` Thomas Monjalon
0 siblings, 2 replies; 4+ messages in thread
From: Ferruh Yigit @ 2016-09-28 10:05 UTC (permalink / raw)
To: dev; +Cc: Neil Horman
Compile error:
CC mlx5.o.pmd.o
mlx5.o.pmd.c:1:227:
error: no newline at end of file [-Werror,-Wnewline-eof]
...__attribute__((used)) = "PMD_INFO_STRING= {...}";
^
Produced with clang 3.8.0 and MLX5_PMD and MLX5_DEBUG
config options enabled.
Fixes: 98b0fdb0ffc6 ("pmdinfogen: add buildtools and pmdinfogen utility")
Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
buildtools/pmdinfogen/pmdinfogen.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/buildtools/pmdinfogen/pmdinfogen.c b/buildtools/pmdinfogen/pmdinfogen.c
index e1bf2e4..59ab956 100644
--- a/buildtools/pmdinfogen/pmdinfogen.c
+++ b/buildtools/pmdinfogen/pmdinfogen.c
@@ -386,7 +386,7 @@ static void output_pmd_info_string(struct elf_info *info, char *outfile)
else
fprintf(ofd, " ");
}
- fprintf(ofd, "]}\";");
+ fprintf(ofd, "]}\";\n");
drv = drv->next;
}
--
2.7.4
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH] pmdinfogen: fix clang build error
2016-09-28 10:05 [dpdk-dev] [PATCH] pmdinfogen: fix clang build error Ferruh Yigit
@ 2016-09-28 11:35 ` Neil Horman
2016-09-28 12:15 ` Ferruh Yigit
2016-10-04 9:48 ` Thomas Monjalon
1 sibling, 1 reply; 4+ messages in thread
From: Neil Horman @ 2016-09-28 11:35 UTC (permalink / raw)
To: Ferruh Yigit; +Cc: dev
On Wed, Sep 28, 2016 at 11:05:19AM +0100, Ferruh Yigit wrote:
> Compile error:
> CC mlx5.o.pmd.o
> mlx5.o.pmd.c:1:227:
> error: no newline at end of file [-Werror,-Wnewline-eof]
> ...__attribute__((used)) = "PMD_INFO_STRING= {...}";
> ^
>
> Produced with clang 3.8.0 and MLX5_PMD and MLX5_DEBUG
> config options enabled.
>
> Fixes: 98b0fdb0ffc6 ("pmdinfogen: add buildtools and pmdinfogen utility")
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
> buildtools/pmdinfogen/pmdinfogen.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/buildtools/pmdinfogen/pmdinfogen.c b/buildtools/pmdinfogen/pmdinfogen.c
> index e1bf2e4..59ab956 100644
> --- a/buildtools/pmdinfogen/pmdinfogen.c
> +++ b/buildtools/pmdinfogen/pmdinfogen.c
> @@ -386,7 +386,7 @@ static void output_pmd_info_string(struct elf_info *info, char *outfile)
> else
> fprintf(ofd, " ");
> }
> - fprintf(ofd, "]}\";");
> + fprintf(ofd, "]}\";\n");
> drv = drv->next;
> }
>
> --
> 2.7.4
>
>
What was the error this produced? It seems like a false positive to me to
require a newline at the end of a string, and it certainly doesn't provide any
benefit when pmdinfo reads it back later.
Neil
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH] pmdinfogen: fix clang build error
2016-09-28 11:35 ` Neil Horman
@ 2016-09-28 12:15 ` Ferruh Yigit
0 siblings, 0 replies; 4+ messages in thread
From: Ferruh Yigit @ 2016-09-28 12:15 UTC (permalink / raw)
To: Neil Horman; +Cc: dev
On 9/28/2016 12:35 PM, Neil Horman wrote:
> On Wed, Sep 28, 2016 at 11:05:19AM +0100, Ferruh Yigit wrote:
>> Compile error:
>> CC mlx5.o.pmd.o
>> mlx5.o.pmd.c:1:227:
>> error: no newline at end of file [-Werror,-Wnewline-eof]
>> ...__attribute__((used)) = "PMD_INFO_STRING= {...}";
>> ^
>>
>> Produced with clang 3.8.0 and MLX5_PMD and MLX5_DEBUG
>> config options enabled.
>>
>> Fixes: 98b0fdb0ffc6 ("pmdinfogen: add buildtools and pmdinfogen utility")
>>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>> ---
>> buildtools/pmdinfogen/pmdinfogen.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/buildtools/pmdinfogen/pmdinfogen.c b/buildtools/pmdinfogen/pmdinfogen.c
>> index e1bf2e4..59ab956 100644
>> --- a/buildtools/pmdinfogen/pmdinfogen.c
>> +++ b/buildtools/pmdinfogen/pmdinfogen.c
>> @@ -386,7 +386,7 @@ static void output_pmd_info_string(struct elf_info *info, char *outfile)
>> else
>> fprintf(ofd, " ");
>> }
>> - fprintf(ofd, "]}\";");
>> + fprintf(ofd, "]}\";\n");
>> drv = drv->next;
>> }
>>
>> --
>> 2.7.4
>>
>>
>
> What was the error this produced? It seems like a false positive to me to
> require a newline at the end of a string, and it certainly doesn't provide any
> benefit when pmdinfo reads it back later.
clang is complaining about missing newline while compiling autogenerated
file, build error is on commit log.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] pmdinfogen: fix clang build error
2016-09-28 10:05 [dpdk-dev] [PATCH] pmdinfogen: fix clang build error Ferruh Yigit
2016-09-28 11:35 ` Neil Horman
@ 2016-10-04 9:48 ` Thomas Monjalon
1 sibling, 0 replies; 4+ messages in thread
From: Thomas Monjalon @ 2016-10-04 9:48 UTC (permalink / raw)
To: Ferruh Yigit; +Cc: dev, Neil Horman
2016-09-28 11:05, Ferruh Yigit:
> Compile error:
> CC mlx5.o.pmd.o
> mlx5.o.pmd.c:1:227:
> error: no newline at end of file [-Werror,-Wnewline-eof]
> ...__attribute__((used)) = "PMD_INFO_STRING= {...}";
> ^
>
> Produced with clang 3.8.0 and MLX5_PMD and MLX5_DEBUG
> config options enabled.
>
> Fixes: 98b0fdb0ffc6 ("pmdinfogen: add buildtools and pmdinfogen utility")
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-10-04 9:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-28 10:05 [dpdk-dev] [PATCH] pmdinfogen: fix clang build error Ferruh Yigit
2016-09-28 11:35 ` Neil Horman
2016-09-28 12:15 ` Ferruh Yigit
2016-10-04 9:48 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).