From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A69B1A057B; Tue, 14 Apr 2020 12:32:17 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 17BFC1C21C; Tue, 14 Apr 2020 12:32:17 +0200 (CEST) Received: from new3-smtp.messagingengine.com (new3-smtp.messagingengine.com [66.111.4.229]) by dpdk.org (Postfix) with ESMTP id 402CF1C215 for ; Tue, 14 Apr 2020 12:32:16 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailnew.nyi.internal (Postfix) with ESMTP id 88BBA58036D; Tue, 14 Apr 2020 06:32:15 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Tue, 14 Apr 2020 06:32:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=WNCUGYU/dolvkJcQbAzVY45m0OPQWI1u84ajRvTA0cY=; b=HviRWZKzOaiC IIz0mFzQz55rLbtoon0NKl25cSwSARTBHRkHURhjRtFcghlbNjZ6qbWnWxUHTIvH ms3SP05HyadgDVYlKDuPqweoNrEAsBHW35U89ykmDNFi9QXsw+2LyrBS176sGDaV DFzVQry/tZnIlI3lBek6qgIwVFqA7qM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=WNCUGYU/dolvkJcQbAzVY45m0OPQWI1u84ajRvTA0 cY=; b=RPKnoIRmvy/suhsQT0QeQ8a8Ca1HBPXJHQqTqYGzZUHlj9uGnWQwI27If j3r/mb3F8mCQRQD/tvm4PA9S1+E5QR6eDynIJgqVRexvp008LopHrKMmDcwqi835 9Nf5QhV8i66PPLLu8HUvaePPe7E4WC57EH5QLR/AV3OENmQkdEtZdmARAStwJQQJ hHvMFboO2kcBERwsknamx1XSZUa7xz+YdX13W9mjxi2i+kEkHKTllAsLMeTjKcZ5 2etwjJHSWeuiPf9Dd/juO2ZkJa9Hd4taMdQKuwZV1UeTufibzOBSBQHTHDr6PVU7 xDxzaVH5MM27DqDuGPOk00sTDF6Ow== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrfedugddvlecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucffoh hmrghinhepughpughkrdhorhhgnecukfhppeejjedrudefgedrvddtfedrudekgeenucev lhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrsh esmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id DFDAB3060076; Tue, 14 Apr 2020 06:32:11 -0400 (EDT) From: Thomas Monjalon To: Ferruh Yigit Cc: David Coyle , dev@dpdk.org, declan.doherty@intel.com, fiona.trahe@intel.com, pablo.de.lara.guarch@intel.com, brendan.ryan@intel.com, shreyansh.jain@nxp.com, hemant.agrawal@nxp.com, akhil.goyal@nxp.com, Anoob Joseph , Ruifeng Wang , Liron Himi , Nagadheeraj Rottela , Srikanth Jampala , Gagandeep Singh , Jay Zhou , Ravi Kumar , bruce.richardson@intel.com Date: Tue, 14 Apr 2020 12:32:10 +0200 Message-ID: <3280198.8hb0ThOEGa@thomas> In-Reply-To: References: <20200410142757.31508-1-david.coyle@intel.com> <4478083.44csPzL39Z@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 0/4] add AESNI-MB rawdev for multi-function processing X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 14/04/2020 12:21, Ferruh Yigit: > On 4/10/2020 11:55 PM, Thomas Monjalon wrote: > > Hi, > > > > Adding more people (crypto PMD maintainers) as Cc. > > > > 10/04/2020 16:27, David Coyle: > >> Introduction > >> ============ > >> > >> This patchset adds a new AESNI-MB Multi-Function raw device PMD for > >> utilizing multi-function capabilities of the Intel IPSec Multi Buffer > >> library. > >> > >> The aim of this rawdev PMD is to provide a way of combining one or more > >> common packet-processing functions into a single operation, focused on > >> DOCSIS and GPON MAC workloads. This allows these functions to be performed > >> in parallel by the Intel IPSec Multi Buffer library. These functions > >> include cryptography and CRC/BIP calculations. Performing these functions > >> in parallel as a single operation can enable a significant performance > >> improvement. > > > > I don't know crypto but I don't think using rawdev for crypto operations > > is an API improvement. > > > > Repeating the initial comments from v1 (because got no reply): > > " > > As a first impression, I feel it is not the right API. > > DPDK is based on classes: ethdev, crypto, compress, baseband, regex > > I want to understand why your features cannot fit in a class. > > Hi Thomas, > > I asked similar question, and there is already a detailed answer with some > background of the issue: Good to see that you get some reply, Ferruh. > http://inbox.dpdk.org/dev/MN2PR11MB35507D4B96677A41E66440C5E3C30@MN2PR11MB3550.namprd11.prod.outlook.com/ I am not convinced. I don't like rawdev in general. Rawdev is good only for hardware support which cannot be generic like SoC, FPGA management or DMA engine. Here the intent is to use rawdev because we don't find a good API. API defeat is a no-go. > > I feel we will need a lot of time to discuss the design. > > If you don't see any consensus on the design in the mailing list, > > you should request an opinion from the Technical Board. > > > > This feature is not a priority for 20.05 release. > > By the way, it has not been announced in any roadmap. > > " > > Is it an issue to not have it in the roadmap? No roadmap is not mandatory. But having it in the roadmap helps to remind something new will require long review effort.