From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id CAB29A0A02;
	Tue,  4 May 2021 19:17:05 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 498FD4014D;
	Tue,  4 May 2021 19:17:05 +0200 (CEST)
Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com
 [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id DF37C40147
 for <dev@dpdk.org>; Tue,  4 May 2021 19:17:03 +0200 (CEST)
Received: from compute3.internal (compute3.nyi.internal [10.202.2.43])
 by mailout.nyi.internal (Postfix) with ESMTP id 7D0B55C0067;
 Tue,  4 May 2021 13:17:03 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute3.internal (MEProxy); Tue, 04 May 2021 13:17:03 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding:content-type; s=fm1; bh=
 diTQqF/M+qXH7mOW2Ix1NoLDNgo3QsnQYYSCZWTHFUU=; b=cESb8/Sn+/ZFuCNx
 2vsATMJMv8m2c7AY0nkS8wrKTHJitiTqvfHA4n0wTdhjpZMN9CIGyZ8+xszITpcU
 JYe4MorAd6TD8185NWwR5pPV5AUj3ARFaoO3F1VPkPDlOGEu4flq40s8nu9bH6ZZ
 olv70KcgzD03LpFc4ZunkZs3qj+vn3kjVU2HzZEuzL9kJtexj7oVZ9qxTP0wOXyR
 MWTeX79qX/uvRgp+mW9LVz1Q6WRA00YRVCrlNFH+dotzfegBV9mhVK08YqnVpO8S
 ucX8n2e6CWDReSvWcStUGFppiY/rdcWV5XCkOjDTGdGGHvex8fuQnKhVIuXCa/Pw
 3VjEjQ==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
 :x-sasl-enc; s=fm2; bh=diTQqF/M+qXH7mOW2Ix1NoLDNgo3QsnQYYSCZWTHF
 UU=; b=aBZw1eCrwAqKDSpWBSousyMdmiqOm1MyI6dYgb5yoii8VWHIAO8VpKQ10
 iMS6+eXh4FtztWkR6Ew1lgwZQVLrxfB9gpKxnp7Rt9m+RhoVW5NMpYbutXiqOzlj
 7r3GPm4K/qKoeBrZ3qU/usT1xsu5sk9/w8qnq4QZkTGx4hQZdel4ldwcrAJD+/ql
 IAMXrVGgQyYOLRdbmSBt21SIrL5xyTQk/K/GkscJG4PiryjQ7935YRfXppFM4S1q
 VgvehVtGsLHSUlptt1eAsyWrUIas/T9Wi8iqEXsA0nHsflM+WwJmoCKhj4TFoCX3
 54ImM0eeIQdIQARenxYhKDSmxavXQ==
X-ME-Sender: <xms:j4GRYJlYQoNwpcYm-T2WxD7Uyx6siW9lrH0tvZTtTslubMt8Ra5TMw>
 <xme:j4GRYE1L2yHIWD05CHSD-AnFSoc89zmr7N6LJl5pHxDP8ANYUYTjqfxyNKRkkZTWx
 8ZJqt6lSk7xgJm1iA>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdefiedgudduvdcutefuodetggdotefrod
 ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh
 necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd
 enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm
 rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc
 ggtffrrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdej
 ueeiiedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrh
 fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgr
 lhhonhdrnhgvth
X-ME-Proxy: <xmx:j4GRYPqVYpgU9V2aJCWLQrM_ARzpoL-OpW4WRGrOLaa69Mgwi990Vg>
 <xmx:j4GRYJnjE8hKmCDVta80ljIq9CrX86SGc3NzKabHBaSn5I72eF5vHg>
 <xmx:j4GRYH0iQ8pNPLM_ArTcKeQJuXEABOwZjjPpFE8qe_N8qJOcb-P4tA>
 <xmx:j4GRYIyFZO9z1vK96DQ9u96zZ9xN0fSlNgcSZaPmX1KXQ_J55qW23w>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA;
 Tue,  4 May 2021 13:17:02 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Tal Shnaiderman <talshn@nvidia.com>
Cc: dev@dpdk.org, pallavi.kadam@intel.com, navasile@linux.microsoft.com,
 dmitrym@microsoft.com, Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Date: Tue, 04 May 2021 19:17:01 +0200
Message-ID: <3287565.MObxxFLoxm@thomas>
In-Reply-To: <20210426185853.092e098e@sovereign>
References: <20210418170803.15684-1-talshn@nvidia.com>
 <20210421160942.17700-1-talshn@nvidia.com>
 <20210426185853.092e098e@sovereign>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v2] eal/windows: fix build warnings in MinGW
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

26/04/2021 17:58, Dmitry Kozlyuk:
> 2021-04-21 19:09 (UTC+0300), Tal Shnaiderman:
> > the strncasecmp macro defined in rte_os_shim.h is already
> > defined in MinGW-w64, as a result the compiler prints out
> > the warning below on function redefinition whenever compiling
> > a file including the header in debug mode.
> > 
> > ..\lib/librte_eal/windows/include/rte_os_shim.h:21:
> > warning: "strncasecmp" redefined
> > #define strncasecmp(s1, s2, count) _strnicmp(s1, s2, count)
> > 
> > Fixed by defining the macro only to the clang compiler.
> > 
> > Fixes: 45d62067c237 ("eal: make OS shims internal")
> > 
> > Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>
> 
> With librte_eal -> eal fixup,
> Acked-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>

Applied, thanks.