From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Anatoly Burakov <anatoly.burakov@intel.com>
Cc: dev@dpdk.org, david.verbeiren@gmail.com
Subject: Re: [dpdk-dev] [PATCH] ivshmem: avoid infinite loop when concatenating adjacent segments
Date: Fri, 01 Apr 2016 16:12:34 +0200 [thread overview]
Message-ID: <3289545.8FCtugvDy0@xps13> (raw)
In-Reply-To: <1450564772-20000-1-git-send-email-david.verbeiren@intel.com>
Please Anatoly,
What do you think of this patch?
2015-12-19 23:39, David Verbeiren:
> This patch aligns the logic used to check for the presence of
> adjacent segments in has_adjacent_segments() with the logic used
> in cleanup_segments() when actually deciding to concatenate or
> not a pair of segments.
>
> This fixes an infinite loop that happened when segments where
> adjacent in their physical or virtual addresses but not in their
> ioremap addresses: has_adjacent_segments() reported the presence
> of adjacent segments while cleanup_segments() was not considering
> them for concatenation, resulting in an infinite loop since the
> result of has_adjacent_segments() is used in the decision to
> continue looping in cleanup_segments().
>
> Signed-off-by: David Verbeiren <david.verbeiren@intel.com>
next prev parent reply other threads:[~2016-04-01 14:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-19 22:39 David Verbeiren
2016-04-01 14:12 ` Thomas Monjalon [this message]
2016-04-01 14:46 ` Burakov, Anatoly
2016-04-01 15:59 ` Burakov, Anatoly
2016-04-07 11:00 ` [dpdk-dev] [PATCH v2] " Anatoly Burakov
2016-04-07 17:18 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3289545.8FCtugvDy0@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=anatoly.burakov@intel.com \
--cc=david.verbeiren@gmail.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).