From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49]) by dpdk.org (Postfix) with ESMTP id 008D42BDD for ; Fri, 1 Apr 2016 16:14:30 +0200 (CEST) Received: by mail-wm0-f49.google.com with SMTP id f198so27878687wme.0 for ; Fri, 01 Apr 2016 07:14:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=qlVKqP8UylcoGX/D2LMNbxOP8Mtoqbhw1C+FuNXAd6Y=; b=eE2RljNvIjf34oJwu0y5xBNMACwrtLnpzA9aiY0OdbP5dBT1NymcT8QBWwALT7rltP EQvdvF0NVKgX6YMVHjt65h2nwYNducAktvM/rjRxGqpMCxx41F/cAuoErf7jShqToYTI ETv2gZznqoKq2c40xI96MXWanrQja2MGHSfpTD6Iy1ePscExupkhZvVecOR6v4K5wseA 4+rQSr06IzXLN1FK3GPjSn8lcUu4LS0n3v6jXF3/CrpUcGNCGLXkRP0r3lz3OQWwNM04 L4byZflbnDfoK6y6Y4hZUYdEmeNDB4Y+bHIFb1/PXsNFZVNC/OPn3qO+UjFhNrXPOAmv CL7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding; bh=qlVKqP8UylcoGX/D2LMNbxOP8Mtoqbhw1C+FuNXAd6Y=; b=SqqWxw7r5GiFa0V7x8jtkWB9IJ8LyLzYohnrYkkXEVgpbujSzOxvpnWMzj3BBI7QMM TYchcsZkAfFRGWzU1j7kv33pI8kjyehZ7hyXPsFjivtD/8aP4bS8iNqOv6Jl86rgVQ3U xK0D3nYcX8kEzLgBIuVXIDxdUioSbs/fvsXm/slcT+X94e4qGBuRp43bbha3gRgGa0H3 d7BG0MgiTS0JwcaXhFKC3vkdG60EHFApE9+jQFNc/zfgI+s+7AicIT5Ptq+0LR49WqKm TzWCAdhY8mlX/4F5vjNQNvQdsiC+KrGU/bFeRf2TeTQSkJc7UcmVI994nStfsn8+feW9 eEmg== X-Gm-Message-State: AD7BkJL2GnIIcjwAjcaeCjyQYs1RAKVr13XbPFdAOreaOrV8S0ugA4hRSZnIIf9ApYurY3Lv X-Received: by 10.194.185.237 with SMTP id ff13mr11062498wjc.129.1459520069829; Fri, 01 Apr 2016 07:14:29 -0700 (PDT) Received: from xps13.localnet (91.111.75.86.rev.sfr.net. [86.75.111.91]) by smtp.gmail.com with ESMTPSA id m130sm30130748wmf.18.2016.04.01.07.14.28 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 01 Apr 2016 07:14:29 -0700 (PDT) From: Thomas Monjalon To: Anatoly Burakov Cc: dev@dpdk.org, david.verbeiren@gmail.com Date: Fri, 01 Apr 2016 16:12:34 +0200 Message-ID: <3289545.8FCtugvDy0@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1450564772-20000-1-git-send-email-david.verbeiren@intel.com> References: <1450564772-20000-1-git-send-email-david.verbeiren@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] ivshmem: avoid infinite loop when concatenating adjacent segments X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Apr 2016 14:14:30 -0000 Please Anatoly, What do you think of this patch? 2015-12-19 23:39, David Verbeiren: > This patch aligns the logic used to check for the presence of > adjacent segments in has_adjacent_segments() with the logic used > in cleanup_segments() when actually deciding to concatenate or > not a pair of segments. > > This fixes an infinite loop that happened when segments where > adjacent in their physical or virtual addresses but not in their > ioremap addresses: has_adjacent_segments() reported the presence > of adjacent segments while cleanup_segments() was not considering > them for concatenation, resulting in an infinite loop since the > result of has_adjacent_segments() is used in the decision to > continue looping in cleanup_segments(). > > Signed-off-by: David Verbeiren