DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: "Van Haaren, Harry" <harry.van.haaren@intel.com>
Cc: dev@dpdk.org, "Mcnamara, John" <john.mcnamara@intel.com>
Subject: Re: [dpdk-dev] [PATCH] doc: add author on cc to git fixline alias
Date: Thu, 03 Aug 2017 15:29:36 +0200	[thread overview]
Message-ID: <3294755.LIHlXguKSE@xps> (raw)
In-Reply-To: <B27915DBBA3421428155699D51E4CFE23ED59338@IRSMSX103.ger.corp.intel.com>

> > With this commit, the correct method to use git fixline to indicate a fix
> > of a previous commit has changed. The new rules require the author of the
> > original code that is being fixed to be on CC.
> > 
> > The logic behind this improvement is that if there is a genuine bug, one
> > of the ideal people to review is the author of the original code being
> > fixed. Adding them on Cc makes them aware of the patch, avoiding it from
> > being passed by accidentally while reading the mailing-list.
> > 
> > Given that the original author (now on Cc:) might not actually review,
> > there is no value in keeping the Cc: in git commit history. If the
> > original author performs a review, their Reviewed-by: or Acked-by: is
> > stored in git history (same as now).
> > 
> > Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>
> 
> Acked-by: John McNamara <john.mcnamara@intel.com>

Acked-by: Thomas Monjalon <thomas@monjalon.net>

Applied, thanks

Please update also the alias on the website.

  reply	other threads:[~2017-08-03 13:29 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-12  8:40 [dpdk-dev] [Process] Git Fixline Suggestion Van Haaren, Harry
2017-07-12 10:49 ` Thomas Monjalon
2017-07-12 13:32   ` Van Haaren, Harry
2017-07-12 13:38     ` [dpdk-dev] [PATCH] doc: add author on cc to git fixline alias Harry van Haaren
2017-07-24 15:07       ` Adrien Mazarguil
2017-08-03 10:55       ` Mcnamara, John
2017-08-03 13:29         ` Thomas Monjalon [this message]
2017-08-03 13:42           ` [dpdk-dev] [PATCH] dev: update " Harry van Haaren
2017-08-03 13:58             ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3294755.LIHlXguKSE@xps \
    --to=thomas@monjalon.net \
    --cc=dev@dpdk.org \
    --cc=harry.van.haaren@intel.com \
    --cc=john.mcnamara@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).