From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 8C48C2BC9 for ; Thu, 3 Aug 2017 15:29:39 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id B254B20ADA; Thu, 3 Aug 2017 09:29:38 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Thu, 03 Aug 2017 09:29:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=IfJEtTj2Zm5e4tq 5YteEpKBPEHo63jgT+jha48l91H0=; b=KsCfkigEYfUVZcOo959N5xawtRW7v7B wK0l11+Djm9TS8K/4jKGFMROfgvYAaBYBE9YoRTIxYbGp25QFXQpRB/i8cqV5t4X raENJqM7SJv4ylnkSLjGSjr+L91EIe82TeXKmWim2G1NYcfcclnf+MG3d3nmOPhb qQHTqlc43/n0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=IfJEtTj2Zm5e4tq5YteEpKBPEHo63jgT+jha48l91H0=; b=NgmfOLVN lAOx1xSOY6p2q30/Xk0L84z1rM73Nw1lunHoE7OJnLcQ9nMhNuDad3kxpTlfvI4x vqzwPgSDQTlrELRb870M1mM+UP+Qi705KzjvqUEiB4eIX682k1jOxtuaXVB7Tatf Ep+pGFQS7CEtFUlmD6Bd0+aByxlz/nFtG0VD+w0UD0bwem5Nz9Rq5rpBeoGD60YX p75DYvxtGIJqfjK5tODjnhSADFd56gRSlugwSCumRQHuI1Rn9d8eP8GYhSUsZnKk jTfEzQoZKNpW5qAZzBDtiffsxLTTHInRITMDRsDB+B3u65zKlGFEW2NiuPSV0kao ubGuAadFb1WswQ== X-ME-Sender: X-Sasl-enc: xS0ER4TmJybdkT7BY/se0pv+K94Tk9dBfPmtQIWfKmWB 1501766978 Received: from xps.localnet (196.114.118.80.rev.sfr.net [80.118.114.196]) by mail.messagingengine.com (Postfix) with ESMTPA id 49CB27E4A9; Thu, 3 Aug 2017 09:29:38 -0400 (EDT) From: Thomas Monjalon To: "Van Haaren, Harry" Cc: dev@dpdk.org, "Mcnamara, John" Date: Thu, 03 Aug 2017 15:29:36 +0200 Message-ID: <3294755.LIHlXguKSE@xps> In-Reply-To: References: <1499866732-17085-1-git-send-email-harry.van.haaren@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] doc: add author on cc to git fixline alias X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Aug 2017 13:29:39 -0000 > > With this commit, the correct method to use git fixline to indicate a fix > > of a previous commit has changed. The new rules require the author of the > > original code that is being fixed to be on CC. > > > > The logic behind this improvement is that if there is a genuine bug, one > > of the ideal people to review is the author of the original code being > > fixed. Adding them on Cc makes them aware of the patch, avoiding it from > > being passed by accidentally while reading the mailing-list. > > > > Given that the original author (now on Cc:) might not actually review, > > there is no value in keeping the Cc: in git commit history. If the > > original author performs a review, their Reviewed-by: or Acked-by: is > > stored in git history (same as now). > > > > Signed-off-by: Harry van Haaren > > Acked-by: John McNamara Acked-by: Thomas Monjalon Applied, thanks Please update also the alias on the website.