From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <thomas@monjalon.net> Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id AF93E1B79A for <dev@dpdk.org>; Tue, 24 Oct 2017 12:25:42 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 2CD7420DDD; Tue, 24 Oct 2017 06:25:42 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Tue, 24 Oct 2017 06:25:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=+hb9rDHhwnddGRk0aSqj7ZV9BR 6AJ5X36GFRElS30xg=; b=pjlVFzunLJH4yNFS/THRtMeS17OWkZCbZ0VEuZWhj1 ZKZNlU4D7O/IaqnnCQDkOdHEgC5AyVH6e+K4zofKV1igP7jlBy/S86KuygeDaC4M CCpfdC9caA8yF/eUrXRjPRxeKQlPQTGj2MUkSdR1SkIaBS1bndEji7jD+t7ShNy6 I= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=+hb9rD HhwnddGRk0aSqj7ZV9BR6AJ5X36GFRElS30xg=; b=NwetnIB+yXWrn7Nc/PaaXx vprzHx/dvKfwJprczNfN4QGmT9mPbxgA1LfA5WYBXgU/cAsctlV6GefYHZtESzhl SaB0SLqF9Llyt5OqLZ5lZdcOV+cie5anZdYi5sKk2xJf6uBMA38PQpT48FeJ9RfJ 5rVgTQQ9WC8S1BOKQs0hCIF56imgdfVZGG7Dn4yYFg49UpWYe4I/Y/vmTLYMXiv8 EfSSV/r4uYE16BIobLidez/rygP53E/Ii3Odd9JqufiGyPgVazOo6w35dOOGrS1w mu6X360A3ij/MdBircHt+3rG0c3aVtdwsjkr7dJInuIgtWsHTPWPd9yiT5SXxZ9w == X-ME-Sender: <xms:JhXvWelURABG9hbK0yZztHenI2pcM5bpIX1vrFd1lpcEpd2DekvGBg> Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id D87317F94E; Tue, 24 Oct 2017 06:25:41 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: "Iremonger, Bernard" <bernard.iremonger@intel.com> Cc: "Mcnamara, John" <john.mcnamara@intel.com>, dev@dpdk.org, "Yigit, Ferruh" <ferruh.yigit@intel.com>, "Ananyev, Konstantin" <konstantin.ananyev@intel.com>, "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>, "adrien.mazarguil@6wind.com" <adrien.mazarguil@6wind.com>, "Singh, Jasvinder" <jasvinder.singh@intel.com> Date: Tue, 24 Oct 2017 12:25:40 +0200 Message-ID: <3296589.AMX0ntvRpg@xps> In-Reply-To: <8CEF83825BEC744B83065625E567D7C24E055671@IRSMSX108.ger.corp.intel.com> References: <1508679124-5922-1-git-send-email-bernard.iremonger@intel.com> <2419109.dR6RbCMRoY@xps> <8CEF83825BEC744B83065625E567D7C24E055671@IRSMSX108.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v10 0/4] flow classification library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Tue, 24 Oct 2017 10:25:43 -0000 24/10/2017 11:53, Iremonger, Bernard: > Hi Thomas, > > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > 24/10/2017 11:23, Mcnamara, John: > > > From: Iremonger, Bernard > > > > > > > > Hi Thomas, > > > > > > > > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > > > > > > > > I suppose you are OK to wait one more release and call for more > > > > reviewers? > > > > > > > > This library was not ready for 17.11.RC1 having received some > > > > comments just before the RC1 deadline. > > > > It was then targeted for RC2 and we have pulled out all the stops to > > > > get it ready for RC2. > > > > > > > > It is now at v10 of the patch set, there have been no review > > > > comments from the community (apart from Intel), since RFC v3. > > > > > > > > I think that there has been ample time for the community to review > > > > this patch set, calling for more reviewers at this point is not helpful. > > > > I have to review some basic things in your series. > > I did not take time to review it because I thought John told me it would not > > make 17.11. > > > > > > The API's of the library are marked as experimental, so there will > > > > be no issues with ABI breakage, if there are requests for changes later. > > > > It is not marked EXPERIMENTAL in the MAINTAINERS file. > > My mistake, it is marked as experimental in rte_flow_classify_version.map > I can send a v11 patch set if needed. > > > > > I am not OK to wait one more release, I believe we have followed the > > > > process correctly. > > > > Yes, you followed the process. > > > > > +1 for inclusion in RC2. > > > > It is not common to add a new library in RC2. > > > > When doing the RC1 announce, I did not mention this library as a possible > > inclusion exception in RC2, and I had no feedback: > > http://dpdk.org/ml/archives/announce/2017-October/000153.html > > I probably should have replied to this email. > > > I was really sure you were not targetting 17.11. > > We have always been targeting 17.11 > > > So I did not do the last pass review. Probably my mistake. > > > > We are having a hard time with 17.11 release, so I would prefer avoiding > > adding one more new library at this stage. > > This is a new library and should not impact anyone. > > I believe we have followed the process, so I think it should not be deferred to 18.02. OK, let's make a deal: If you can address my comments in v11 and if there is no compilation issue, then I will take it in RC2.