From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 13388A0577; Tue, 14 Apr 2020 11:07:01 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 610751C295; Tue, 14 Apr 2020 11:06:59 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 894F61C25A for ; Tue, 14 Apr 2020 11:06:57 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 1D7535C0255; Tue, 14 Apr 2020 05:06:55 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Tue, 14 Apr 2020 05:06:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=+6WKdH6eo3eFrbu9sc4zeXKttpK7fY09mylfeniJ7ok=; b=rNFefhwpQbpk XNGSF2JqqSQ/zHsCHmUf2mP+/n4VPLrIY2EpCYuXFhp7s9KcKJDEaFeQuJxuGICv q1ZwUT53JE3yPG6BWSNIYSLa/A8Z0tP9ULcVkeB3n5srrG/nKpzlf/ixokwZGwNy tMYfQ4pa036RugzFdNjhQneOkY5O4Bo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=+6WKdH6eo3eFrbu9sc4zeXKttpK7fY09mylfeniJ7 ok=; b=vM/1AcPmFiocGkdVgx4hOOlOcDAM2JX8S79Wz3j1Mvf8gQxuvSaH8p5OL +b02Kec9oFBm3Ad/OjCi3KAEjDY3YVRncUGDMaNW1QyCYTd0ieX00nsIcJV+auid PeZhjY410zHLT4NSxtV3qTlo95CIsM5c+Fz9go9w/CmIKatt5yPlOFBh1ZnI1UHa m/hzKTXGtnd6c9i6u7mjd5jlIoF2eRbB6cBo9yTXICwzmE0Rh7Pt0DR+18iMysd+ 92iPRu2+3wxomwHbzlAqZl/McJ722DmVBanfK9b24TjfvJ8qHpOmtlxmTuwzC6LB 5dnv19ln4ZHX+WXu9e2XIAdLnE+8A== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrfedugdduvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghr rghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id E4D6B3060064; Tue, 14 Apr 2020 05:06:53 -0400 (EDT) From: Thomas Monjalon To: "akhil.goyal@nxp.com" , "De Lara Guarch, Pablo" Cc: "dev@dpdk.org" , "O'loingsigh, Mairtin" , "Doherty, Declan" , "Dybkowski, AdamX" , "Trahe, Fiona" Date: Tue, 14 Apr 2020 11:06:52 +0200 Message-ID: <3299752.PIDvDuAF1L@thomas> In-Reply-To: References: <1586354671-25703-1-git-send-email-mairtin.oloingsigh@intel.com> <9210853.NyiUUSuA9g@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4 2/2] test/crypto: Add AES-256 DOCSIS test vectors X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 14/04/2020 10:49, De Lara Guarch, Pablo: > From: Thomas Monjalon > > 10/04/2020 17:03, Mairtin o Loingsigh: > > > This patch adds test vectors for AES-256 and sets AESNI-MB as the > > > target PMD > > > > There is really something wrong in the cryptodev API. > > Why the PMD must be selected in the tests? > > Isn't there some capabilities in cryptodev? > > Whitelisting PMD in the test prevents testing capabilities API. > > > > It looks the required refactoring is not progressing enough. > > I suggest blocking all crypto-related patches until is is fixed. > > > > You are right, but Mairtin was following the same approach as it was taken previously. I know. His patch was accepted. > I agree that this approach is not the best one and we are currently working > on a better solution. Now that's clear, let's not merge any new crypto patch until the capabilities are working and tested.