From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 36449201 for ; Tue, 19 Mar 2019 13:58:08 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 77214821E2; Tue, 19 Mar 2019 12:58:07 +0000 (UTC) Received: from [10.36.112.48] (ovpn-112-48.ams2.redhat.com [10.36.112.48]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 926E961352; Tue, 19 Mar 2019 12:58:06 +0000 (UTC) To: Tiwei Bie , zhihong.wang@intel.com, dev@dpdk.org References: <20190319064312.13743-1-tiwei.bie@intel.com> <20190319064312.13743-5-tiwei.bie@intel.com> From: Maxime Coquelin Message-ID: <32b35241-0d88-1145-073a-4b8ba24522f3@redhat.com> Date: Tue, 19 Mar 2019 13:58:04 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <20190319064312.13743-5-tiwei.bie@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Tue, 19 Mar 2019 12:58:07 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH 04/10] net/virtio: optimize flags update for packed ring X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Mar 2019 12:58:08 -0000 On 3/19/19 7:43 AM, Tiwei Bie wrote: > Cache the AVAIL, USED and WRITE bits to avoid calculating > them as much as possible. Note that, the WRITE bit isn't > cached for control queue. > > Signed-off-by: Tiwei Bie > --- > drivers/net/virtio/virtio_ethdev.c | 35 ++++++++++++++---------------- > drivers/net/virtio/virtio_rxtx.c | 31 ++++++++++---------------- > drivers/net/virtio/virtqueue.h | 8 +++---- > 3 files changed, 32 insertions(+), 42 deletions(-) > Nice patch! Reviewed-by: Maxime Coquelin Thanks, Maxime From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 2BC02A00E6 for ; Tue, 19 Mar 2019 13:58:11 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0BA9F1B19; Tue, 19 Mar 2019 13:58:10 +0100 (CET) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 36449201 for ; Tue, 19 Mar 2019 13:58:08 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 77214821E2; Tue, 19 Mar 2019 12:58:07 +0000 (UTC) Received: from [10.36.112.48] (ovpn-112-48.ams2.redhat.com [10.36.112.48]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 926E961352; Tue, 19 Mar 2019 12:58:06 +0000 (UTC) To: Tiwei Bie , zhihong.wang@intel.com, dev@dpdk.org References: <20190319064312.13743-1-tiwei.bie@intel.com> <20190319064312.13743-5-tiwei.bie@intel.com> From: Maxime Coquelin Message-ID: <32b35241-0d88-1145-073a-4b8ba24522f3@redhat.com> Date: Tue, 19 Mar 2019 13:58:04 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <20190319064312.13743-5-tiwei.bie@intel.com> Content-Type: text/plain; charset="UTF-8"; format="flowed" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Tue, 19 Mar 2019 12:58:07 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH 04/10] net/virtio: optimize flags update for packed ring X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190319125804.i-0LvcMphRFNqkwOJ-nRcsOpIJixPTlMBj4aGtLw4j0@z> On 3/19/19 7:43 AM, Tiwei Bie wrote: > Cache the AVAIL, USED and WRITE bits to avoid calculating > them as much as possible. Note that, the WRITE bit isn't > cached for control queue. > > Signed-off-by: Tiwei Bie > --- > drivers/net/virtio/virtio_ethdev.c | 35 ++++++++++++++---------------- > drivers/net/virtio/virtio_rxtx.c | 31 ++++++++++---------------- > drivers/net/virtio/virtqueue.h | 8 +++---- > 3 files changed, 32 insertions(+), 42 deletions(-) > Nice patch! Reviewed-by: Maxime Coquelin Thanks, Maxime