From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 35D23316B; Fri, 14 Apr 2017 10:31:38 +0200 (CEST) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Apr 2017 01:31:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,197,1488873600"; d="scan'208";a="88933695" Received: from dwdohert-dpdk.ir.intel.com ([163.33.210.152]) by fmsmga005.fm.intel.com with ESMTP; 14 Apr 2017 01:31:36 -0700 To: Eric Kinzie , Ilya Maximets References: <1491577632-31289-1-git-send-email-i.maximets@samsung.com> <20170410022225.GA5162@roosta> Cc: dev@dpdk.org, Heetae Ahn , Bernard Iremonger , stable@dpdk.org From: Declan Doherty Message-ID: <32c66606-95aa-3187-a4f6-89563d290793@intel.com> Date: Fri, 14 Apr 2017 09:31:03 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170410022225.GA5162@roosta> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] net/bonding: allow configuring jumbo frames without slaves X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Apr 2017 08:31:40 -0000 On 10/04/17 03:22, Eric Kinzie wrote: > On Fri Apr 07 18:07:12 +0300 2017, Ilya Maximets wrote: >> Currently, 'rte_eth_dev_configure' fails on attempt to setup >> max_rx_pkt_len > 2048 if no slaves was added to bonded device. >> >> For example: >> >> rte_eth_dev_attach("eth_bond0,slave=05:00.0,mode=l34", &id) >> conf.rxmode.jumbo_frame = 1; >> conf.rxmode.max_rx_pkt_len = 9000; >> rte_eth_dev_configure(id, 1, 1, &conf) >> >> Result: >> EAL: Initializing pmd_bond for eth_bond0 >> EAL: Create bonded device eth_bond0 on port 4 in mode 2 on socket 0. >> rte_eth_dev_configure: ethdev port_id=4 \ >> max_rx_pkt_len 9018 > max valid value 2048 >> >> It's expected that slaves will be added to bonded device inside >> 'rte_eth_dev_configure' and proper 'max_rx_pktlen' configured >> for all of them. >> >> Failure happens because of hardcoded low value of 'max_rx_pktlen'. >> Increasing of this value to ETHER_MAX_JUMBO_FRAME_LEN will allow >> above scenario (attach + configure). >> >> It is important because it is the way OVS wants to work with >> all DPDK devices (including virtual). >> Changing the default hardcoded value makes no harm because >> all the slaves' related code uses only 'candidate_max_rx_pktlen' >> variable. >> >> CC: stable@dpdk.org >> Fixes: 6cfc6a4f0d61 ("net/bonding: inherit maximum Rx packet length") >> Signed-off-by: Ilya Maximets >> --- ... > > Reviewed-by: Eric Kinzie > Acked-by: Declan Doherty