DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Medvedkin, Vladimir" <vladimir.medvedkin@intel.com>
To: Jan Viktorin <viktorin@cesnet.cz>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 2/2] fib: announce experimental tag removal of the fib API
Date: Thu, 5 Aug 2021 15:27:15 +0200	[thread overview]
Message-ID: <32cb2d90-2a08-ec06-0c71-031b6187c472@intel.com> (raw)
In-Reply-To: <20210805151451.59932409@coaster.localdomain>

Hi Jan,

The RIB is always used as a control plane struct intended to maintain 
the correct content of the dataplane struct, such as DIR24_8 for 
example. So it is always used on _add()/_delete(). For simplicity you 
can consider it as an LPM's rule_info. But instead of keeping routes in 
a plane array as it is in LPM, FIB uses RIB which is more suitable 
binary tree.


On 05/08/2021 15:14, Jan Viktorin wrote:
> On Thu, 5 Aug 2021 15:08:13 +0200
> Vladimir Medvedkin <vladimir.medvedkin@intel.com> wrote:
> 
>> This patch announces the experimental tag removal of all fib APIs,
>> which have been experimental for 2 years.
>> API will be promoted to stable in DPDK 21.11
> 
> Hi Vladimir,
> 
> I have a question related to FIB. I am just learning how to use it and
> I found that each FIB always creates a new RIB internally. There is no doc
> about this topic...
> 
> If I understand correctly, the underlying RIB is only used when
> dummy_lookup() and dummy_modify() are used. But they are only used when the
> configured mode is RTE_FIB_DUMMY. Is there any reason to create the RIB with
> RTE_FIB_DIR24_8?
> 
> The issue with this is that each RIB allocates a new mempool internally which
> can waste quite a lot of never used memory that would be unused with DIR24_8
> implementation.
> 
> Regards
> Jan
> 
>>
>>
>> Signed-off-by: Vladimir Medvedkin <vladimir.medved...@intel.com>
>> ---
>>   doc/guides/rel_notes/deprecation.rst | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/doc/guides/rel_notes/deprecation.rst
>> b/doc/guides/rel_notes/deprecation.rst
>> index afb599a..58826a8 100644
>> --- a/doc/guides/rel_notes/deprecation.rst
>> +++ b/doc/guides/rel_notes/deprecation.rst
>> @@ -195,3 +195,5 @@ Deprecation Notices
>>     communicate events such as soft expiry with IPsec in lookaside
>> mode.
>>   * rib: The ``rib`` library will be promoted from experimental to
>> stable. +
>> +* fib: The ``fib`` library will be promoted from experimental to
>> stable.

-- 
Regards,
Vladimir

       reply	other threads:[~2021-08-05 13:27 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20210805151451.59932409@coaster.localdomain>
2021-08-05 13:27 ` Medvedkin, Vladimir [this message]
2021-08-05 13:32   ` Jan Viktorin
2021-08-05 13:57     ` Medvedkin, Vladimir
2021-08-05 14:07       ` Jan Viktorin
2021-08-05 14:29         ` Medvedkin, Vladimir
2021-08-05 14:34           ` Jan Viktorin
2021-08-05 14:38             ` Medvedkin, Vladimir
2021-08-05 11:26 [dpdk-dev] [PATCH 1/2] rib: announce experimental tag removal of the rib API Vladimir Medvedkin
2021-08-05 11:26 ` [dpdk-dev] [PATCH 2/2] fib: announce experimental tag removal of the fib API Vladimir Medvedkin
2021-08-05 13:52   ` Walsh, Conor
2021-08-07 13:35     ` Jerin Jacob

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=32cb2d90-2a08-ec06-0c71-031b6187c472@intel.com \
    --to=vladimir.medvedkin@intel.com \
    --cc=dev@dpdk.org \
    --cc=viktorin@cesnet.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).