From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BDD3A41B71; Sun, 8 Oct 2023 08:46:22 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8A90E402B1; Sun, 8 Oct 2023 08:46:22 +0200 (CEST) Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by mails.dpdk.org (Postfix) with ESMTP id 20F9740263 for ; Sun, 8 Oct 2023 08:46:20 +0200 (CEST) Received: from dggpeml500011.china.huawei.com (unknown [172.30.72.57]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4S3CHn0V5DztT38; Sun, 8 Oct 2023 14:41:41 +0800 (CST) Received: from [10.67.121.193] (10.67.121.193) by dggpeml500011.china.huawei.com (7.185.36.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Sun, 8 Oct 2023 14:46:14 +0800 Message-ID: <32d7f57b-0db0-42ca-9ac8-064e9aed2c6a@huawei.com> Date: Sun, 8 Oct 2023 14:46:14 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/2] app/testpmd: fix help string Content-Language: en-US To: fengchengwen , CC: , , , , , References: <20230801024304.2187484-1-huangdengdui@huawei.com> <20231008015630.406378-1-huangdengdui@huawei.com> <20231008015630.406378-2-huangdengdui@huawei.com> From: huangdengdui In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.121.193] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggpeml500011.china.huawei.com (7.185.36.84) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2023/10/8 10:47, fengchengwen wrote: > Hi Dengdui, > > On 2023/10/8 9:56, Dengdui Huang wrote: >> Command help string is missing 'mcast_addr add|remove'. >> This patch add it. >> >> Fixes: 8fff667578a7 ("app/testpmd: new command to add/remove multicast MAC addresses") >> Cc: stable@dpdk.org >> >> Signed-off-by: Dengdui Huang >> --- >> app/test-pmd/cmdline.c | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c >> index a0e97719b3..3165347a05 100644 >> --- a/app/test-pmd/cmdline.c >> +++ b/app/test-pmd/cmdline.c >> @@ -516,6 +516,12 @@ static void cmd_help_long_parsed(void *parsed_result, >> "set allmulti (port_id|all) (on|off)\n" >> " Set the allmulti mode on port_id, or all.\n\n" >> >> + "mcast_addr add (port_id) (mcast_addr)\n" >> + " Add a multicast MAC addresses on port_id.\n\n" >> + >> + "mcast_addr remove (port_id) (mcast_addr)" > > Please add '\n' at last. > > with above fixed, > Acked-by: Chengwen Feng > OK, thanks >> + " Remove a multicast MAC address from port_id.\n\n" >> + >> "set flow_ctrl rx (on|off) tx (on|off) (high_water)" >> " (low_water) (pause_time) (send_xon) mac_ctrl_frame_fwd" >> " (on|off) autoneg (on|off) (port_id)\n" >>