* [dpdk-dev] [PATCH] lib/cryptodev: remove RTE_LIBRTE_CRYPTODEV_DEBUG
@ 2018-06-12 6:38 Jananee Parthasarathy
2018-06-21 14:11 ` Akhil Goyal
2018-07-02 12:30 ` [dpdk-dev] [PATCH v2] cryptodev: " Jananee Parthasarathy
0 siblings, 2 replies; 6+ messages in thread
From: Jananee Parthasarathy @ 2018-06-12 6:38 UTC (permalink / raw)
To: dev; +Cc: pablo.de.lara.guarch, reshma.pattan, Jananee Parthasarathy
For librte_cryptodev dynamic logging,
conditional compilation of debug logs would not be required anymore.
Signed-off-by: Jananee Parthasarathy <jananeex.m.parthasarathy@intel.com>
Reviewed-by: Reshma Pattan <reshma.pattan@intel.com>
---
lib/librte_cryptodev/rte_cryptodev.h | 8 --------
1 file changed, 8 deletions(-)
diff --git a/lib/librte_cryptodev/rte_cryptodev.h b/lib/librte_cryptodev/rte_cryptodev.h
index 92ce6d49a..229712ebf 100644
--- a/lib/librte_cryptodev/rte_cryptodev.h
+++ b/lib/librte_cryptodev/rte_cryptodev.h
@@ -65,7 +65,6 @@ extern const char **rte_cyptodev_names;
RTE_FMT(RTE_FMT_HEAD(__VA_ARGS__,) "\n", \
RTE_FMT_TAIL(__VA_ARGS__,)))
-#ifdef RTE_LIBRTE_CRYPTODEV_DEBUG
#define CDEV_LOG_DEBUG(...) \
RTE_LOG(DEBUG, CRYPTODEV, \
RTE_FMT("%s() line %u: " RTE_FMT_HEAD(__VA_ARGS__,) "\n", \
@@ -76,13 +75,6 @@ extern const char **rte_cyptodev_names;
RTE_FMT("[%s] %s: " RTE_FMT_HEAD(__VA_ARGS__,) "\n", \
dev, __func__, RTE_FMT_TAIL(__VA_ARGS__,)))
-#else
-#define CDEV_LOG_DEBUG(...) (void)0
-#define CDEV_PMD_TRACE(...) (void)0
-#endif
-
-
-
/**
* A macro that points to an offset from the start
* of the crypto operation structure (rte_crypto_op)
--
2.13.6
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] lib/cryptodev: remove RTE_LIBRTE_CRYPTODEV_DEBUG
2018-06-12 6:38 [dpdk-dev] [PATCH] lib/cryptodev: remove RTE_LIBRTE_CRYPTODEV_DEBUG Jananee Parthasarathy
@ 2018-06-21 14:11 ` Akhil Goyal
2018-06-21 14:12 ` Akhil Goyal
2018-07-02 12:30 ` [dpdk-dev] [PATCH v2] cryptodev: " Jananee Parthasarathy
1 sibling, 1 reply; 6+ messages in thread
From: Akhil Goyal @ 2018-06-21 14:11 UTC (permalink / raw)
To: Jananee Parthasarathy, dev; +Cc: pablo.de.lara.guarch, reshma.pattan
Hi Jananee,
On 6/12/2018 12:08 PM, Jananee Parthasarathy wrote:
> For librte_cryptodev dynamic logging,
> conditional compilation of debug logs would not be required anymore.
I believe this shall also be removed from config/common_base and
lib/librte_eal/common/include/rte_dev.h as nobody is using it.
-Akhil
>
> Signed-off-by: Jananee Parthasarathy <jananeex.m.parthasarathy@intel.com>
> Reviewed-by: Reshma Pattan <reshma.pattan@intel.com>
> ---
> lib/librte_cryptodev/rte_cryptodev.h | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/lib/librte_cryptodev/rte_cryptodev.h b/lib/librte_cryptodev/rte_cryptodev.h
> index 92ce6d49a..229712ebf 100644
> --- a/lib/librte_cryptodev/rte_cryptodev.h
> +++ b/lib/librte_cryptodev/rte_cryptodev.h
> @@ -65,7 +65,6 @@ extern const char **rte_cyptodev_names;
> RTE_FMT(RTE_FMT_HEAD(__VA_ARGS__,) "\n", \
> RTE_FMT_TAIL(__VA_ARGS__,)))
>
> -#ifdef RTE_LIBRTE_CRYPTODEV_DEBUG
> #define CDEV_LOG_DEBUG(...) \
> RTE_LOG(DEBUG, CRYPTODEV, \
> RTE_FMT("%s() line %u: " RTE_FMT_HEAD(__VA_ARGS__,) "\n", \
> @@ -76,13 +75,6 @@ extern const char **rte_cyptodev_names;
> RTE_FMT("[%s] %s: " RTE_FMT_HEAD(__VA_ARGS__,) "\n", \
> dev, __func__, RTE_FMT_TAIL(__VA_ARGS__,)))
>
> -#else
> -#define CDEV_LOG_DEBUG(...) (void)0
> -#define CDEV_PMD_TRACE(...) (void)0
> -#endif
> -
> -
> -
> /**
> * A macro that points to an offset from the start
> * of the crypto operation structure (rte_crypto_op)
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] lib/cryptodev: remove RTE_LIBRTE_CRYPTODEV_DEBUG
2018-06-21 14:11 ` Akhil Goyal
@ 2018-06-21 14:12 ` Akhil Goyal
2018-06-27 16:36 ` De Lara Guarch, Pablo
0 siblings, 1 reply; 6+ messages in thread
From: Akhil Goyal @ 2018-06-21 14:12 UTC (permalink / raw)
To: Jananee Parthasarathy, dev; +Cc: pablo.de.lara.guarch, reshma.pattan
Please remove lib from subject also.
On 6/21/2018 7:41 PM, Akhil Goyal wrote:
> Hi Jananee,
>
>
> On 6/12/2018 12:08 PM, Jananee Parthasarathy wrote:
>> For librte_cryptodev dynamic logging,
>> conditional compilation of debug logs would not be required anymore.
>
> I believe this shall also be removed from config/common_base and
> lib/librte_eal/common/include/rte_dev.h as nobody is using it.
>
> -Akhil
>
>>
>> Signed-off-by: Jananee Parthasarathy
>> <jananeex.m.parthasarathy@intel.com>
>> Reviewed-by: Reshma Pattan <reshma.pattan@intel.com>
>> ---
>> lib/librte_cryptodev/rte_cryptodev.h | 8 --------
>> 1 file changed, 8 deletions(-)
>>
>> diff --git a/lib/librte_cryptodev/rte_cryptodev.h
>> b/lib/librte_cryptodev/rte_cryptodev.h
>> index 92ce6d49a..229712ebf 100644
>> --- a/lib/librte_cryptodev/rte_cryptodev.h
>> +++ b/lib/librte_cryptodev/rte_cryptodev.h
>> @@ -65,7 +65,6 @@ extern const char **rte_cyptodev_names;
>> RTE_FMT(RTE_FMT_HEAD(__VA_ARGS__,) "\n", \
>> RTE_FMT_TAIL(__VA_ARGS__,)))
>> -#ifdef RTE_LIBRTE_CRYPTODEV_DEBUG
>> #define CDEV_LOG_DEBUG(...) \
>> RTE_LOG(DEBUG, CRYPTODEV, \
>> RTE_FMT("%s() line %u: " RTE_FMT_HEAD(__VA_ARGS__,) "\n", \
>> @@ -76,13 +75,6 @@ extern const char **rte_cyptodev_names;
>> RTE_FMT("[%s] %s: " RTE_FMT_HEAD(__VA_ARGS__,) "\n", \
>> dev, __func__, RTE_FMT_TAIL(__VA_ARGS__,)))
>> -#else
>> -#define CDEV_LOG_DEBUG(...) (void)0
>> -#define CDEV_PMD_TRACE(...) (void)0
>> -#endif
>> -
>> -
>> -
>> /**
>> * A macro that points to an offset from the start
>> * of the crypto operation structure (rte_crypto_op)
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] lib/cryptodev: remove RTE_LIBRTE_CRYPTODEV_DEBUG
2018-06-21 14:12 ` Akhil Goyal
@ 2018-06-27 16:36 ` De Lara Guarch, Pablo
0 siblings, 0 replies; 6+ messages in thread
From: De Lara Guarch, Pablo @ 2018-06-27 16:36 UTC (permalink / raw)
To: Akhil Goyal, Parthasarathy, JananeeX M, dev; +Cc: Pattan, Reshma
Hi Jananee,
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Akhil Goyal
> Sent: Thursday, June 21, 2018 3:13 PM
> To: Parthasarathy, JananeeX M <jananeex.m.parthasarathy@intel.com>;
> dev@dpdk.org
> Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Pattan, Reshma
> <reshma.pattan@intel.com>
> Subject: Re: [dpdk-dev] [PATCH] lib/cryptodev: remove
> RTE_LIBRTE_CRYPTODEV_DEBUG
>
> Please remove lib from subject also.
>
>
> On 6/21/2018 7:41 PM, Akhil Goyal wrote:
> > Hi Jananee,
> >
> >
> > On 6/12/2018 12:08 PM, Jananee Parthasarathy wrote:
> >> For librte_cryptodev dynamic logging, conditional compilation of
> >> debug logs would not be required anymore.
> >
> > I believe this shall also be removed from config/common_base and
> > lib/librte_eal/common/include/rte_dev.h as nobody is using it.
> >
Could you make these changes soon?
Thanks,
Pablo
^ permalink raw reply [flat|nested] 6+ messages in thread
* [dpdk-dev] [PATCH v2] cryptodev: remove RTE_LIBRTE_CRYPTODEV_DEBUG
2018-06-12 6:38 [dpdk-dev] [PATCH] lib/cryptodev: remove RTE_LIBRTE_CRYPTODEV_DEBUG Jananee Parthasarathy
2018-06-21 14:11 ` Akhil Goyal
@ 2018-07-02 12:30 ` Jananee Parthasarathy
2018-07-02 15:51 ` De Lara Guarch, Pablo
1 sibling, 1 reply; 6+ messages in thread
From: Jananee Parthasarathy @ 2018-07-02 12:30 UTC (permalink / raw)
To: dev; +Cc: pablo.de.lara.guarch, reshma.pattan, Jananee Parthasarathy
From: Jananee Parthasarathy <jananeex.m.parthasarathy@intel.com>
For librte_cryptodev dynamic logging, conditional compilation of
debug logs would not be required anymore.
Signed-off-by: Jananee Parthasarathy <jananeex.m.parthasarathy@intel.com>
Reviewed-by: Reshma Pattan <reshma.pattan@intel.com>
Reviewed-by: Pablo de Lara Guarch <pablo.de.lara.guarch@intel.com>
---
v2: unused macro removed from config/common_base and rte_dev.h
---
config/common_base | 1 -
lib/librte_cryptodev/rte_cryptodev.h | 8 --------
lib/librte_eal/common/include/rte_dev.h | 1 -
3 files changed, 10 deletions(-)
diff --git a/config/common_base b/config/common_base
index 6541ad5b2..84317a9bd 100644
--- a/config/common_base
+++ b/config/common_base
@@ -460,7 +460,6 @@ CONFIG_RTE_LIBRTE_PMD_BBDEV_TURBO_SW=n
# Compile generic crypto device library
#
CONFIG_RTE_LIBRTE_CRYPTODEV=y
-CONFIG_RTE_LIBRTE_CRYPTODEV_DEBUG=n
CONFIG_RTE_CRYPTO_MAX_DEVS=64
#
diff --git a/lib/librte_cryptodev/rte_cryptodev.h b/lib/librte_cryptodev/rte_cryptodev.h
index b7a4cf0a2..ccc0f73fd 100644
--- a/lib/librte_cryptodev/rte_cryptodev.h
+++ b/lib/librte_cryptodev/rte_cryptodev.h
@@ -38,7 +38,6 @@ extern const char **rte_cyptodev_names;
RTE_FMT(RTE_FMT_HEAD(__VA_ARGS__,) "\n", \
RTE_FMT_TAIL(__VA_ARGS__,)))
-#ifdef RTE_LIBRTE_CRYPTODEV_DEBUG
#define CDEV_LOG_DEBUG(...) \
RTE_LOG(DEBUG, CRYPTODEV, \
RTE_FMT("%s() line %u: " RTE_FMT_HEAD(__VA_ARGS__,) "\n", \
@@ -49,13 +48,6 @@ extern const char **rte_cyptodev_names;
RTE_FMT("[%s] %s: " RTE_FMT_HEAD(__VA_ARGS__,) "\n", \
dev, __func__, RTE_FMT_TAIL(__VA_ARGS__,)))
-#else
-#define CDEV_LOG_DEBUG(...) (void)0
-#define CDEV_PMD_TRACE(...) (void)0
-#endif
-
-
-
/**
* A macro that points to an offset from the start
* of the crypto operation structure (rte_crypto_op)
diff --git a/lib/librte_eal/common/include/rte_dev.h b/lib/librte_eal/common/include/rte_dev.h
index 3879ff3ca..d4b43512c 100644
--- a/lib/librte_eal/common/include/rte_dev.h
+++ b/lib/librte_eal/common/include/rte_dev.h
@@ -70,7 +70,6 @@ rte_pmd_debug_trace(const char *func_name, const char *fmt, ...)
* RTE_*_RET() macros defined below is compiled in debug mode.
*/
#if defined(RTE_LIBRTE_ETHDEV_DEBUG) || \
- defined(RTE_LIBRTE_CRYPTODEV_DEBUG) || \
defined(RTE_LIBRTE_EVENTDEV_DEBUG)
#define RTE_PMD_DEBUG_TRACE(...) \
rte_pmd_debug_trace(__func__, __VA_ARGS__)
--
2.16.3
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH v2] cryptodev: remove RTE_LIBRTE_CRYPTODEV_DEBUG
2018-07-02 12:30 ` [dpdk-dev] [PATCH v2] cryptodev: " Jananee Parthasarathy
@ 2018-07-02 15:51 ` De Lara Guarch, Pablo
0 siblings, 0 replies; 6+ messages in thread
From: De Lara Guarch, Pablo @ 2018-07-02 15:51 UTC (permalink / raw)
To: Parthasarathy, JananeeX M, dev; +Cc: Pattan, Reshma
> -----Original Message-----
> From: Parthasarathy, JananeeX M
> Sent: Monday, July 2, 2018 1:31 PM
> To: dev@dpdk.org
> Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Pattan, Reshma
> <reshma.pattan@intel.com>; Parthasarathy, JananeeX M
> <jananeex.m.parthasarathy@intel.com>
> Subject: [PATCH v2] cryptodev: remove RTE_LIBRTE_CRYPTODEV_DEBUG
>
> From: Jananee Parthasarathy <jananeex.m.parthasarathy@intel.com>
>
> For librte_cryptodev dynamic logging, conditional compilation of debug logs
> would not be required anymore.
>
> Signed-off-by: Jananee Parthasarathy <jananeex.m.parthasarathy@intel.com>
> Reviewed-by: Reshma Pattan <reshma.pattan@intel.com>
> Reviewed-by: Pablo de Lara Guarch <pablo.de.lara.guarch@intel.com>
> ---
> v2: unused macro removed from config/common_base and rte_dev.h
Applied to dpdk-next-crypto.
Thanks,
Pablo
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-07-02 15:51 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-12 6:38 [dpdk-dev] [PATCH] lib/cryptodev: remove RTE_LIBRTE_CRYPTODEV_DEBUG Jananee Parthasarathy
2018-06-21 14:11 ` Akhil Goyal
2018-06-21 14:12 ` Akhil Goyal
2018-06-27 16:36 ` De Lara Guarch, Pablo
2018-07-02 12:30 ` [dpdk-dev] [PATCH v2] cryptodev: " Jananee Parthasarathy
2018-07-02 15:51 ` De Lara Guarch, Pablo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).