From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-eopbgr40067.outbound.protection.outlook.com [40.107.4.67]) by dpdk.org (Postfix) with ESMTP id 1E8761BB0B for ; Thu, 21 Jun 2018 16:11:26 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/6Ia9cVQ+TUBav1bd2x3oLvgfEDWr7niUFIr7GiwzJ8=; b=ovOFIIKtIvqavPEHaz1Cmhso9P4sJlUGLa5FMGxIjwInB9r/rqYEPjJNP4Esx+q8xMQde4OaxNuxerSgSigQpEqwr89Y9lIbAljghPy08WPTU0MC4z1LirdHcAMZjfeTV5y+TNqEyrPjOCP/CUagOXO1uNLFHOv+N5BJmwsUZG0= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=akhil.goyal@nxp.com; Received: from [10.232.134.144] (14.142.187.166) by AM3PR04MB1378.eurprd04.prod.outlook.com (2a01:111:e400:536a::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.884.20; Thu, 21 Jun 2018 14:11:22 +0000 To: Jananee Parthasarathy , dev@dpdk.org Cc: pablo.de.lara.guarch@intel.com, reshma.pattan@intel.com References: <1528785534-23425-1-git-send-email-jananeex.m.parthasarathy@intel.com> From: Akhil Goyal Message-ID: <32f96244-0b7f-17ff-9cc0-8e8955b8904e@nxp.com> Date: Thu, 21 Jun 2018 19:41:04 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <1528785534-23425-1-git-send-email-jananeex.m.parthasarathy@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [14.142.187.166] X-ClientProxiedBy: PN1PR0101CA0021.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c00:e::31) To AM3PR04MB1378.eurprd04.prod.outlook.com (2a01:111:e400:536a::16) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 427f900e-1b5a-42ba-8968-08d5d780dea2 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(5600026)(711020)(48565401081)(2017052603328)(7153060)(7193020); SRVR:AM3PR04MB1378; X-Microsoft-Exchange-Diagnostics: 1; AM3PR04MB1378; 3:IKkFj/D7nIrCSceR8qoFEhBMGi/9LTWnLy+3GSRbC/09XyHktO+21b7aUAjHfDZWSuRKdfoEASjIqHetaWeoSyAcpLKCZkSw/MGlGFEUdnyrVqN1RWxlrxiA3GTJ08mtcE52MVsI4dK7cW245e1is5j/suACDGYalFcFN2dtB/BUnDVm27DxlJuCcrbIu3UEwTRHWQPOJzT2sk57pHJTtt04+z4qakdKAJz4k7O6tag5le6OTB/TDLLE1Dj8AISr; 25:Hy3PZ4WQ6Wa6qtNjvCxZ+2Xq1wyBoCHMmZrC5bSbEhfDNX3KCbeScZLJ+dFCRtj9IFV1nIvj0Sk1f/fHqhXfwIUfBH0gxZnR8LLALLMGV2bxOfh/DZCjbHDhcDxINXeIsLhnNe0xn3cVVe5RCHWixFfMdehJ5HaUMxbftbbdXkRiMiWz0w1Kk0JNDub7yskNwlf/YnCjiRZWktt9dE2elmaR1Acbk+5okEKuaw1hy8gD1nvzchF4DeubgBFHYbJe/igeWBUxStWib/gqRFLbde9TOUa0itE2J26+kH7HLEAzoaSlhqd3JSdydkZ7bRRmKkhO8dUke7tTY6yLMSuKVw==; 31:LWm1IAFTJGtjd3payLdzT838XlqfYuPpLm97Xzk1I3JqtjXG/WEIvHLq0zDYPKMNg3dbBLG5sS80KCWTAr6vV5JdHKlwr5gb7kfnXfeqOlPFccezK7m05E/bCY2Uq9lYWzbAnfLJ191Q8ZCkEKKi3sgJUjpLqVYeK+rzAqOrHDvuM4XGiCXKAQ29yyCrAiENeGxETlTsDG9HbmpTbx4LwAP2kdVfs81RnzZStmLHMfo= X-MS-TrafficTypeDiagnostic: AM3PR04MB1378: X-Microsoft-Exchange-Diagnostics: 1; AM3PR04MB1378; 20:UXfWdd4v0N68IIPPthmJbrAQGgJ5EZTyxe8I0aegW8SJuX3wE0ztNpx/Jh7Dy/u1dW210IT/ACyLrmuqO52f7b7x2I6tl9yptXkQUr7EMZ8mXkfqlbdqPQ7BOx8KOid0dNeaGVVg/dF2L5r8eFyrq55wvhrzHcBrclUZNvsh57lPsz6YuzomO0NjciIhLdXtImn0sWwRmEy30Sdq1MeylCuzrP2M+E6WsYdNjsBsQazcAwcc4RhWabjzscdPSqrhFmZroIgaPAh75Ej7X88J0l8qDoe0jj0jxy21wKx3g7DltDFppBkNVn9moRJIBgmPz/WiWxqXeGv7cY9X0qkSLeN4efCohQkji+BbkFAzKcqKM5KcaTxpfoGULxZ0A2zARk+rkpdDM1zlBhuCQfqPVLpWrd5D/Auk88wc4SRNx10pWcoiR/hvG/WNnhvzvJe8bYtsUxIEMdp63IfQ+wP3QIJkV3lBdE41uOPDPs2bEcz2k0CbooRpr+GaXsKTzwHA; 4:YL+XJiu3aWCU72jVcgVxmRmMuuwmszyTP0ctv4+146rLmHej2SpWhzr6WcirECLsPFz4CwgPG6mWze1CJQY1I/u3FUkbF8lX1v3778kSOtcjFbi7EXi5b96hv2LzCisUlWJixJj20rQA9LCPB1+oHarP3Hg0Cgqvt/uUKGD3u8EzY1om3SNR5qXW42rd/3fbMHvgeL+7e/tMkklqelnN3mBi758DVk64YyBWa5dJwN/rYxwYwzA/rXMBiP15IQZuXGvmH1NBoqLSnZNeYjrATPJ5yANHPpIpPCwxhRFMNuOVH5KDhiBWyBNiVx23Myvn X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(228905959029699); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(3231254)(944501410)(52105095)(10201501046)(3002001)(6055026)(149027)(150027)(6041310)(20161123558120)(20161123562045)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016); SRVR:AM3PR04MB1378; BCL:0; PCL:0; RULEID:; SRVR:AM3PR04MB1378; X-Forefront-PRVS: 07106EF9B9 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6049001)(346002)(376002)(396003)(39860400002)(39380400002)(366004)(199004)(189003)(64126003)(6486002)(8936002)(229853002)(11346002)(16526019)(5009440100003)(230700001)(446003)(186003)(77096007)(956004)(2616005)(26005)(476003)(81166006)(53936002)(8676002)(58126008)(16576012)(486006)(81156014)(53546011)(6116002)(386003)(3846002)(55236004)(50466002)(67846002)(36756003)(316002)(6246003)(2906002)(44832011)(25786009)(86362001)(52116002)(97736004)(31696002)(76176011)(68736007)(2486003)(3260700006)(52146003)(23676004)(305945005)(31686004)(7736002)(4326008)(47776003)(5660300001)(65956001)(65826007)(65806001)(66066001)(6666003)(105586002)(478600001)(106356001)(110426005); DIR:OUT; SFP:1101; SCL:1; SRVR:AM3PR04MB1378; H:[10.232.134.144]; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:3; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtBTTNQUjA0TUIxMzc4OzIzOmZrZVdXWWlHTmE4SWV1S0hld0phWDRGcjd2?= =?utf-8?B?WU0xNTNqRmQ4V3VFYzg4TW1DTFFCWkEwZHNocEg4VS9EdGR2YlgwUmMwdHdm?= =?utf-8?B?WFBiVnJtNzhpSGg4ZXNBMjh3dStuU3JpWlQ4NjVWVkFxekpVbVNZeHNFVFJS?= =?utf-8?B?ZGs0V2hNYml3ODFwSFp1Q0FGUjdCWGcvOW9kaEY2dmNTN282ZXhDZHpLOCtL?= =?utf-8?B?VEt3T3Nmb1NMNmluK0RkYitUeFp0OUwzazVQekxTM3lObWFrWUJhWGxrTUNI?= =?utf-8?B?eUtMcDQzQWJmdldoWEtOMEFmVkhQeG8yeDJZWWRkY3ZSU1R4ZW9zN3Zrb1ox?= =?utf-8?B?WmVZenphTXNhdEoweVJ4RHBJU2pxWXVlQU4xK0lPWnBMQUNFT2JlWUkyWlNu?= =?utf-8?B?dVhDQXM5ZTJNcHhPRThIbU9adVZzMWhZbVp2L1pDS3lXQUtMVStWc0huS3Zn?= =?utf-8?B?Rk00Mkc4ZnBEalFvY2pnTHJmYVd1VFdZcjZ3Q1Q2SzRHeEl3dkZLUXFtVVFm?= =?utf-8?B?UkFIL3BBTWtOWGtFdzdxSHNEZ2JxdXhoelFNZTgwSWd3M1NyUEwyZFo2WEJW?= =?utf-8?B?eEFvVldyMnJJMG5nYzc4QkV6NWFvcnVFdVlxT2ozbWZlNEJYZmxoWkxlREYv?= =?utf-8?B?dHQ2VXNFYzlDZmxKVzdrRElSeHpZN1VFVEVxNkxwS1dqMnZCQ05Hb2xMOUZM?= =?utf-8?B?UWdMMFhFajRrVHpTRWZWaFRORDBRWWRmZEpxQjFuK0VpY2ZkNlJyMUFhQzB5?= =?utf-8?B?OUtJSzgwMmdiMzdEdXcxaUVNR3ZPQXVscElMWjJVaXBzcVZmaUFUQy9BNDdh?= =?utf-8?B?b2tjRDJGSzNpK3R1VncxSVM1a3RlKzV3MGZhdWwrUFZLM2lidjNaRWRWcFcz?= =?utf-8?B?ZnBMZVdPakF5WVh5aGJaREJxd1UxZ1BKTXVMVUFtSWZEa2puR1k2SWlUSnZN?= =?utf-8?B?VWZiNVpnUlNlbVA2YVg4S2lpSy9ZWE1yWms1cDNLSnh0ZE8rc2VDQ1dVTnRm?= =?utf-8?B?R1ZUNVRhWU9Kd0ovdEp5U3JsTWo5Mnl4NHBXRW9rdms0NVN1K1A2eFVuQ3Vr?= =?utf-8?B?aUtKMU5zNEhabUtERDFacUE0cmptemdvTlM1OE4vM0VlWWlZZGFpWUZZM3BK?= =?utf-8?B?WlBPUm9oa3dna1RSVXd2Nm9zMy9Mb1BmZ2xiMmxCa0J2U0F4V1BCMVVJUWI2?= =?utf-8?B?WEhDK1pWVTVzLzVMQzN4NnpWU1lROHRvSWpKY0FhcG1Rdnl6TzdzZ1dhdGtw?= =?utf-8?B?ZlRiN3ZTVjNRRklOL3grK3hkeFdjbzhjdWFjTHpIbG11VndjY0tRa29JUk1p?= =?utf-8?B?cWR0SHBNRzQ1V1hSNjBqRTF1aHN1V2dBaGFmcVNNY3RSTWNlM1RNcVJNS05T?= =?utf-8?B?UGlQcWtWUzRZNmQ0SncyKzZ0a1JrRmJFL25QM2YydXJqLzZqdDA5WDFBbWdK?= =?utf-8?B?WDVTV3YyWGE2OGg2WXRqWDhFT05xczU1eVdOa2hLMnM4ZGNzd3J5Z3Y1QjZv?= =?utf-8?B?VEpaY0lOOTVkblhnZFhzcXAwQW43UVVvclBna0I5RU5uaWdYbTZkVjViWDR4?= =?utf-8?B?Y2tSZ2liUWRRZDFMaXVmdXdVS0Jla1hOSXhHWVhkaS9iY3RCdUE4RTBEU21h?= =?utf-8?B?OU9ONWM0UEd0dWRCcFhzTkpUY2MxQTViQXVMOEM5ZUJmWHV0bTVvbjZYYlRL?= =?utf-8?B?anVxSFhVdVk3ZTRSWEo2SE1QZ3U1YzJpd1h5dERtcDFlQml2SHBLYlZIdDFO?= =?utf-8?B?bVpnMjQvTklxZ2dKL3FXVmVhazl4dERrT2pReGJUUzVLUjE2c2YzY3hqUFVp?= =?utf-8?B?blJqMmcwTm56OURvclZUK3ZYQnVCaE9lSkpmRFNWQ0pQNVoxT2xCMVMyemFL?= =?utf-8?B?NXRETHVHeDlNYVN6VVpSaGtWeWhIN0pNQ2tVLzZPSFF4Y1ZrRWFGcGhDNGlo?= =?utf-8?B?dXNDV083L1B3K2tZSnBMZzd0RzloWkQ0SitXREpONUFsa2dNeG9CbDZDV2R2?= =?utf-8?B?SEY3NndibGRIc1h6M0VjaUF2ZGYvajlUR0E1cE5pNzVPdXdHMHFiMVdycWFx?= =?utf-8?Q?qsbwXgTAfS9wM6my/WVorP6q7?= X-Microsoft-Antispam-Message-Info: OdMlBCKpRNQFkzz2qwjr955PbhIgJXheERdKnQLDpaE8LN8zgEiXGutMt1MhsrdfbE1qSad4nuUJMwz5OGul46Uej1srhXTH4cbqm8RGzrHx/iG3hkFuv7QV/XO8Q3IvH+QPDeNrX6oce3AvrAE60jL0cwCN1TmWqPVAA2CyeQY/gPMbJshnJcRLfcywkwHo/pluu/pUhIj4VJrSa3RzKqpJVRskfssNeMsvOpsdghj3KT8BBZvCx49AWdGqyR8ViDHaaG+1taFqktG4IP60RsD2n6dCjXjpulCOY3vYLcRV2NzUcat34o5GdKAqPotooqPFLSG40tb3Pb2p+w8lfw== X-Microsoft-Exchange-Diagnostics: 1; AM3PR04MB1378; 6:ekrAzGYENH+mWO/UtJBiecb6hxcjFoDiumdy1F0UbrpbJUhnoIRJd1vtRfaCmGRexnWtjOeiBvXpvNzEyqOh14Tt8l6YdQMqm+OFo6xiynIAEhMDI3aQqt7avqeVZ4/lzvaVUTqr4tcRwSNUXC819JC27JZZzLcnX695L0UHniQX1i4gBVQ9TO3BA/PVyLeSfV2itkkDmTCHMrSxR6FgK6NjxJ+FXcZEyfWORGi6Faeob5sDVco10U6xL1XE3z1UIl5C6Afy9029vLqQVDf0C6Xz1npNk17tuypgIDI/4z6kEuVZdcofboSBfYxgvxTzwlHGcGGB/Ap07JnwO8G/shzgrXA6ekj18ZONQJbRDGZD8au5zrOQplsnjr1uQVvWYb508Pp00sB038XekmzTxVrrcOBJ8mOyXa3qlMsLfyfQlusJsciJsq36hNT1MVZnl6DPBxS1+d+Le1GBfcW7Cw==; 5:JRfWNPSKP4Ex6/mldQXu9R1Z4FOMVjEHLbwn/oBt+DJfCRjlEFH0H7WEiwCxApeDN33fOnB6GgHUZ1StkVCr+Qao4N7UzYFou/fmsKTYxzwJtTA+43JWlRyyNx8zuc8ZbYCKGuGjHFXPtDt9+3axHPgLKTPdqse5IBraHdjBFP4=; 24:XSlTFcsTTuP7IH7vCUTn/GtWJE20IPM809in73Ha561OEu5SVtrZg/RBH8F+yVpwKa3LdwED6sZ4wZdC63Bz0hlp/ryPVTU0l3NjqtmsWGI= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; AM3PR04MB1378; 7:0vPsf+6QCfa9ZLZa55SZ6aRglquwjXw1YDy5rYK5ts7s7WSgWqWKMurs1KUwcpi9sSyyvYv4DSznbYbJvx0IIHe+ruafS9Sym+8kzgPFq66ce1aomDgN87XZXohvPEU1HcBm3KWJipNqBjK4IMk77TPcJSgay6f7Vy1V2drT2MAyg9UEA8X8Bs2WHj/sKLMMON/bIDBcYkl5SeIJnTOkFv+3GWDKxmhZqI2Ti9pi100buTuBL8xINs75FVHK8YyP X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jun 2018 14:11:22.3772 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 427f900e-1b5a-42ba-8968-08d5d780dea2 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM3PR04MB1378 Subject: Re: [dpdk-dev] [PATCH] lib/cryptodev: remove RTE_LIBRTE_CRYPTODEV_DEBUG X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Jun 2018 14:11:26 -0000 Hi Jananee, On 6/12/2018 12:08 PM, Jananee Parthasarathy wrote: > For librte_cryptodev dynamic logging, > conditional compilation of debug logs would not be required anymore. I believe this shall also be removed from config/common_base and lib/librte_eal/common/include/rte_dev.h as nobody is using it. -Akhil > > Signed-off-by: Jananee Parthasarathy > Reviewed-by: Reshma Pattan > --- > lib/librte_cryptodev/rte_cryptodev.h | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/lib/librte_cryptodev/rte_cryptodev.h b/lib/librte_cryptodev/rte_cryptodev.h > index 92ce6d49a..229712ebf 100644 > --- a/lib/librte_cryptodev/rte_cryptodev.h > +++ b/lib/librte_cryptodev/rte_cryptodev.h > @@ -65,7 +65,6 @@ extern const char **rte_cyptodev_names; > RTE_FMT(RTE_FMT_HEAD(__VA_ARGS__,) "\n", \ > RTE_FMT_TAIL(__VA_ARGS__,))) > > -#ifdef RTE_LIBRTE_CRYPTODEV_DEBUG > #define CDEV_LOG_DEBUG(...) \ > RTE_LOG(DEBUG, CRYPTODEV, \ > RTE_FMT("%s() line %u: " RTE_FMT_HEAD(__VA_ARGS__,) "\n", \ > @@ -76,13 +75,6 @@ extern const char **rte_cyptodev_names; > RTE_FMT("[%s] %s: " RTE_FMT_HEAD(__VA_ARGS__,) "\n", \ > dev, __func__, RTE_FMT_TAIL(__VA_ARGS__,))) > > -#else > -#define CDEV_LOG_DEBUG(...) (void)0 > -#define CDEV_PMD_TRACE(...) (void)0 > -#endif > - > - > - > /** > * A macro that points to an offset from the start > * of the crypto operation structure (rte_crypto_op)