From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D8F2DA00C2; Fri, 14 Oct 2022 11:41:29 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CA69B42CF8; Fri, 14 Oct 2022 11:41:29 +0200 (CEST) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2082.outbound.protection.outlook.com [40.107.92.82]) by mails.dpdk.org (Postfix) with ESMTP id D1365410F2 for ; Fri, 14 Oct 2022 11:41:27 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dsuz2gh82uKxpwQE02QOOGrHMHoeU0Jwfn++4R1iZtKPwirGnNd60g/ocoGjeCEaXPfyIDq9Nkgpltg3bB0O5eY1lnDJ2yE5DWJ/9yvBcBNF5+0oHTVebagXZnPqbN5Bc0E4OPys6/WpUMslnTH9veV3gOALmDnqfkw+egSHC0eck3Hayx7KPee+8ggm7BTZRU26s2GvZzCXfCMvpOf0ZOMAZlCr/fwKmkPo5nKHlwnqeM8fRrJneENdJB8U089qqKfb0CZMgmL/v4JW619prfsSRubNwymAT5T8yHWIBXdY7eazksdGW3uY0EebCcKrvSsVtWCCUf+SeA4arRm86g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fpUrSmBpt5RLENOTrlBZdoXbEjWJVpMOrTeAdbXTZwY=; b=QmoXM1h7GUN27cetucmG+ZKqgEOgoYz1hlM7+hcxCZcUlKCfMpkUGjHSyBs+TQuaVtgSR5sALJmoWe8oOB3nMXtvOyHURYFN8qIosr0W/Sw4ABEhoTDLomPXoUZzA1PllH43XsCGWHAiq4W1lo6Y16gxL6icdBweHzrjrplN1XHKyRwTtD6LedK5KjzVtzGzvEqLhvPy5YEdmJpXSqtOUQPuEeKadyek72brflcTRorip1sZxBMVMHFZBQ10ogEf7mRZc8/fHPMl/FBSgsedJZX+JtjYW3kbosZjGgPGlqn5fPgMTNi3SP/7k+uKgD24CihcWYJheNoUkSWMF31GVQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fpUrSmBpt5RLENOTrlBZdoXbEjWJVpMOrTeAdbXTZwY=; b=eKSiiJQuFsYmF56nWHGOJSHiQRBa0Uy0TgXFpLPfbcrm0BnXpRh3pbW7I5WzuLOh4tc+mZimTZOyj9D2Ox3dBDFYZwH07m/1s1WCvNKORLVGxPzM3xAhZf92on0797jEQCm/XNOleTGlppzNxdv+3EytTy8VNbVQMdIFi8EBGUI= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from MN2PR12MB4301.namprd12.prod.outlook.com (2603:10b6:208:1d4::22) by PH8PR12MB7134.namprd12.prod.outlook.com (2603:10b6:510:22d::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29; Fri, 14 Oct 2022 09:41:26 +0000 Received: from MN2PR12MB4301.namprd12.prod.outlook.com ([fe80::7900:1b25:bc:104c]) by MN2PR12MB4301.namprd12.prod.outlook.com ([fe80::7900:1b25:bc:104c%9]) with mapi id 15.20.5723.026; Fri, 14 Oct 2022 09:41:26 +0000 Message-ID: <32ffac90-4762-7ad1-eb49-ccb448db5e9c@amd.com> Date: Fri, 14 Oct 2022 10:41:22 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.2 Subject: Re: [PATCH v2] net/nfp: add the feature of RSS based on VXLAN inner layer Content-Language: en-US From: Ferruh Yigit To: Chaoyong He , dev@dpdk.org Cc: oss-drivers@corigine.com, niklas.soderlund@corigine.com References: <1665738548-20974-1-git-send-email-chaoyong.he@corigine.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO6P123CA0024.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:313::16) To MN2PR12MB4301.namprd12.prod.outlook.com (2603:10b6:208:1d4::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MN2PR12MB4301:EE_|PH8PR12MB7134:EE_ X-MS-Office365-Filtering-Correlation-Id: be32bc83-98c7-4e83-7aee-08daadc84325 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QvRaKMyMqd1+KGLc8YbpukVjC2FspUJEStj6bGSS9SqReJAOsS4u+cO9Bm1S80wCnJSmzBy5USe1ke7Tbd0MKAP0ynxxy05h/ZugH27lvRzUeGVsf7H5NNRcjCOnAk2M5ys5Kebd5+fuVsOdqPAvvvXm/vHWJK2q+n/NTD5XDDP2QhsUUwNd9Spi/51uVc0lE7HlRuyxOytgKM/AQ1zLDodl+gLsNsNu/ojl+vludx4cAyrmnvrRYtq6IOhlHzw5nNWNBacI05mxylXuSYSOBG2m1th/yIuWz9mZ9fiSTcU0r6lGxNjyJQkYLq735YWM85ojVItmvQN9ccGgFPj9aKEU1LoUy35fJM4ovrTTNJtYVirbceoOBuPWyOzOecWEhpPLhaC9TcAEb6xeKPu6WcNrFyxYQFJ9B++AO0ITnRREKt7p5KqYMjW2mby9/fKFLqxzsCeSGLbv0rWgb70V82BpDtY5VIp7hmEK+RdPUt2GCIdWVsYx8a3VRNbXsDJF0kIrvkko94bW8nWJrsaVhjp7iEqNn8k0OX+37LZ+DgFJpYPDG+9+4XAfSvXLpVavnhCkuTMKSoNMlWGdDfJBKUmMd0B53ERSjl4wntSsPw2Vo0H8lyEaieRG50Iqg0W6Dcj4INzpxJPrluwg4eF1ZK0zxLYr8pmkfVYW7HyDlV31qVhseJfq5vpHEM07t50V/VQgXtUXwgSyss9Re2isCj3r+EsiPV02BFM4fMU9S0K3YF0SLC/cyUQXOhjQpQ7FMQpi4Fxmwf7Pz15Vnb8XS9fEeQR14G74YA3NTrmIEJ/JoOKzSezxnpNTjQhtuB/R X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR12MB4301.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(346002)(366004)(376002)(39860400002)(136003)(396003)(451199015)(5660300002)(186003)(8936002)(26005)(6512007)(2906002)(6486002)(2616005)(966005)(86362001)(6506007)(41300700001)(36756003)(31696002)(53546011)(478600001)(38100700002)(316002)(31686004)(83380400001)(66556008)(4326008)(8676002)(66946007)(44832011)(6666004)(66476007)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dTVvMDJwQ1JWaVhhazE0M3h2bXJNZHB6T3lUZVNxR1FsRjM0dmVCVWl0NjJB?= =?utf-8?B?T0xiRXR1S1JYZDZJNE9vUS9Cc3dXbGhpNVp6UDFsSW04LzdsWk1DdWFZcWNu?= =?utf-8?B?YjB6M0JCSVN6VGdua2pYRjBQckQyeC9WbkZyc3V2ZjYyVmlGQ1d3dTRaWHJ5?= =?utf-8?B?NXFCQWF3RnNEbzlrTGJ2Q3JwZTBzdFliYmRQQTRzWVhxUzhYQWVOdWwwQUM0?= =?utf-8?B?aXd4MVJienRNMkszZzlGY1F6T3lPcFBxcTFmNEYrWXhTWUhBT1k3QS9sQVdi?= =?utf-8?B?cnEzOUErQzIxZlNTZXg0VDBOSVVYVVRCTk1HcVBsankrNXVQYTdHS29JeVpW?= =?utf-8?B?TlZadDRUbGxiREdldXU3U2F0WUlCY3FOa1ZXbW8wTHFCZjRpRThPZ0tOTlFL?= =?utf-8?B?RWkwN0lxSTZyS2ZBRHRoWE1INGRZd2Q5ZHBaSWNOYW1OVUNZTU82RlpzUjV1?= =?utf-8?B?UlkxeTlhcXByRGkyek5vM2ltTVlVQ0Vhb0h1cXVEWU9vdDE5Y2wwampsc1Vy?= =?utf-8?B?MFZzWUVZdWVWamx3UUZORVRDcU9oUitXOCtZQ3cyeXlUc1BESEhRUXN2SGN5?= =?utf-8?B?NlpxQk0ySzRsb0xvL0lhS0RUUGErUTdQckxoSkgxSnpldG1QQjY5ZjA2ZmZn?= =?utf-8?B?TldnZWUrdHFIV1RHV1d2OFZBdnQ1S0ZBZGpQam5ZdFErK2Q2VUIzQk5PU1VL?= =?utf-8?B?MXkwUHZ5S3VVU1lsSXZPVmEyZ3crMy8wbUszSnI1Zk1sRXh5UnFSdDlIZHZF?= =?utf-8?B?d29ZbkRjYVoyY0l0SW4vcUFIZ3g5RnlRbUdMUjN2cUY2QnQwK2laazhjNjY1?= =?utf-8?B?cHBLbUpabDdDU2tVWEN5SGhhTVVGT2U0VTFMWnVzVnBKQTZPYUFJaFhnbUM4?= =?utf-8?B?QmdLY1kvbS9IUVJHNENlU0xIUXpoNDkwZ2RHTlVzbnR5RjdPdUY5UWJBQTJX?= =?utf-8?B?MDJ6UmhhbXZSclJRQXY0QmFIbzgxNi8xV2xaN1RETGoyaTlBZHpEQnVKY0FZ?= =?utf-8?B?M3hwTmRzcTIyV3Z5bk9PTmRTTFFDL1RaNlIyczNYU3BvZjdPVnplMU1XaTZz?= =?utf-8?B?L25DY0RRSExkRlJ0eUF3M3BCMlVZNktoQVk0RkhXbC9ydjNtL0lLaTdxTkRO?= =?utf-8?B?UTdhN2o0eEpEc3RhdkxKNWg1eS9mU0ZSenNjRjBpZS9SQ0VuKzdPSnJWR2pT?= =?utf-8?B?aDhydjRPaSttcTRQaHp5TjFrdVJRMkJqc21kQWNzeE8yRDdqRDlWZFM5dkJS?= =?utf-8?B?TkNzZlFSRy9WN2p5c1h5MVVPeEQwTk1PTGM5Ui94RjhiZVF2Z1VKZWJTYkI0?= =?utf-8?B?K2ZTR2F4ZmhXUGYwSGJiMjVtbVVFQkhETlRnWXBUOHpYNFUxVTZFd2JyaGU3?= =?utf-8?B?OS8rQ24yTis1NkYrcDZHMFZUN0F3dmJVbGJGYXlsQVR2a25FM200bzRKM3Za?= =?utf-8?B?UUNNM0ZRRmplK1FJV1BudFlRVXJxMjYzcStHU1FYOTdTWU81d2YwOFkxS2hY?= =?utf-8?B?bnFTUVhGMzE2T1hXZFdxaUVJZnBtS0o3SWdCUGpvNnFVRHdWdENRdXlxQmk2?= =?utf-8?B?dTlDclhhUDlxS3d5MVpNVHNSRCtkWnl2UC9SWGpWWFFSbDFMQ3RxaER4dVRy?= =?utf-8?B?VUsrSkgxU2Q3Z2FwbjRqN2M1cUlwUjlTN2ZERU5vSkZmOVdhUVBIVGhjd3pi?= =?utf-8?B?VWYrbnBmTVAvUUFOSlRReTZKSS9RM05WWEoxVExEWTI5eWVQd0MxdDF0RmV1?= =?utf-8?B?QmRmai9RVVRaNVF5dHN3UTRseExJb0t1bXF3QWw4eVBJZ1NvWmQvVWVMb1Np?= =?utf-8?B?bStFQnQrU0MzVFkwQlAreVM2dmREaEVldVkyM3k5S29pR2dqUW5WRElCdDYy?= =?utf-8?B?ZlRVKzRJMVA4dG1BV0gvQmlRRGprZzZFejkxOWErblBtUEV2VnlyVTllSmRB?= =?utf-8?B?cU1aUWpWdDVpaGlCZytvdzhqYUVjNHZvVEZaZzhKQUNqT1NMVjJjemxMT0lm?= =?utf-8?B?VXUvZlloZ1NtY3QyUHRGWUkwWGhBUzdCYjRKeDllWlFhQ2VnYU1xRkNiRkQr?= =?utf-8?B?akJicTU0Tjg2b0JMT0M2V3dJV09nUmNwM2RXY1llT0xMLzQraFlxYmFpSDJI?= =?utf-8?Q?FuEwbg1NAh0ysoqTW0goTd0hy?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: be32bc83-98c7-4e83-7aee-08daadc84325 X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4301.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2022 09:41:25.9814 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: y9X9+MRHTkL74vYLcRDEmTPd2VnU09MebjJZrh012fkM5JaHLpqLXkPv53k/KAkC X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB7134 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 10/14/2022 10:40 AM, Ferruh Yigit wrote: > On 10/14/2022 10:09 AM, Chaoyong He wrote: >> diff --git a/drivers/net/nfp/nfp_ethdev.c b/drivers/net/nfp/nfp_ethdev.c >> index e131021..d938e01 100644 >> --- a/drivers/net/nfp/nfp_ethdev.c >> +++ b/drivers/net/nfp/nfp_ethdev.c >> @@ -33,7 +33,6 @@ >>   #include "nfpcore/nfp_nsp.h" >>   #include "nfp_common.h" >> -#include "nfp_ctrl.h" >>   #include "nfp_rxtx.h" >>   #include "nfp_logs.h" >>   #include "nfp_cpp_bridge.h" >> @@ -138,6 +137,10 @@ >>       update |= NFP_NET_CFG_UPDATE_GEN | NFP_NET_CFG_UPDATE_RING; >> +    /* Enable vxlan */ >> +    new_ctrl |= NFP_NET_CFG_CTRL_VXLAN; >> +    update |= NFP_NET_CFG_UPDATE_VXLAN; >> + >>       if (hw->cap & NFP_NET_CFG_CTRL_RINGCFG) >>           new_ctrl |= NFP_NET_CFG_CTRL_RINGCFG; > > Hi Chaoyong, > > Thanks for the update. > > Although practically you don't need to include 'nfp_ctrl.h' since it is > included by 'nfp_common.h', > 'nfp_ethdev.c' uses symbols from 'nfp_ctrl.h'. > > What do you think to explicitly include a header when source file uses > symbols from that header as a principal? > This helps to document what is required externally for source file > clearly, also protects against changes, like you may move 'nfp_ctrl.h' > include out of 'nfp_common.h' in the future. > > According above, would you be OK to include 'nfp_ctrl.h' in > 'nfp_common.h' (as already done), but not remove 'nfp_ctrl.h' from files > that use symbols from it? also can you please use '--in-reply-to' for next version? Following documentation has details: https://doc.dpdk.org/guides/contributing/patches.html#sending-patches