From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0E916454F1; Tue, 25 Jun 2024 16:52:10 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CD94042DFA; Tue, 25 Jun 2024 16:52:08 +0200 (CEST) Received: from fhigh7-smtp.messagingengine.com (fhigh7-smtp.messagingengine.com [103.168.172.158]) by mails.dpdk.org (Postfix) with ESMTP id 4FABF402D0 for ; Tue, 25 Jun 2024 16:46:54 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailfhigh.nyi.internal (Postfix) with ESMTP id C9A6A1140138; Tue, 25 Jun 2024 10:46:53 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Tue, 25 Jun 2024 10:46:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1719326813; x=1719413213; bh=rwAKFXs0/DE7ekf6mwtKXYkSQCGlx2YxQigLPjzdj5A=; b= Jy4caMYjBSLnjznEGDG1THSHSItSZu/KC9wLLHnHLNIcf/Xl/6sP4WS0f0K216pB oO3qXujwLgO0EG1+X2TGIWDbkiV2Ln+JoJbMfBR7xljQdZPHCHqPIKOAYeQyeRKf M2i3diIEoVJbcxFmvbt3O3G/L5xGU5nNRuHr49A9xxwhLp+tZQ7y6udJr/5Czc9G DRtX9eiYY5lrgTFpjJgDWOtmK1EHtpUjEKcqj+356KdBWTqQoB6miGMvs//MTXUk E6d4EmXzAH6tGPZvFuaNxVi6fyyCzyRnr/yU9+JwETn6g2MP0BzP80Cv+WJxbuPN lqMJDoTmLbw42SnoloRlPQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1719326813; x= 1719413213; bh=rwAKFXs0/DE7ekf6mwtKXYkSQCGlx2YxQigLPjzdj5A=; b=f Qg/3HIcCfiZgLMZyfGcdFfjAEWrmlUP7TUGj+wSpHDjKz16zqNfsMZZ02+UaD1Mh rnohJaWoMw0zz25LWc9ZlM+164LPCUOn+v1yFITO3Rfnwfh+2ahPNhHaAftrP9Dd pll/w1VDb7CG8CKYMcgsyuhPcikur+qnshRxTPuLOANFhzC/5M4VfX67Ge6toaE4 ZSeG84lNbfTQKz23dAG5I7BYFsku2B6/AZpZLZuEe4kYTRUZ5Kp49ViJ0Y2fjhnP us2vEexStM6QLlq2qUPBIcXVaQXoEHSys3zQHV/t7mIeLB1x/b3PUacS77PSt4cp bIDcAPg/wHCmnnOyZGbyw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrtddtgdegjecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkfgjfhgggfgtsehtufertddttdejnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepjeduveehieevuddutdevfffgtdegkeeuveejffejgedtgeegkefg vdeugfefkeejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 25 Jun 2024 10:46:50 -0400 (EDT) From: Thomas Monjalon To: Ferruh Yigit , rongwei liu Cc: "dev@dpdk.org" , Matan Azrad , Slava Ovsiienko , Ori Kam , Suanming Mou , Andrew Rybchenko , Dariusz Sosnowski , Aman Singh , Yuying Zhang , jerin.jacob@caviumnetworks.com, bruce.richardson@intel.com, david.marchand@redhat.com, ajit.khaparde@broadcom.com Subject: Re: [PATCH v8 2/3] ethdev: add VXLAN last reserved field Date: Tue, 25 Jun 2024 16:46:48 +0200 Message-ID: <3302562.ciBtUerH68@thomas> In-Reply-To: References: <2909053.FA0FI3ke8A@thomas> <560e87e1-30ec-424b-bd88-19ef2a6ce057@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 12/06/2024 03:25, rongwei liu: > From: Ferruh Yigit > > On 6/7/2024 3:02 PM, Rongwei Liu wrote: > > > @@ -41,7 +41,10 @@ struct rte_vxlan_hdr { > > > uint8_t flags; /**< Should be 8 (I flag). */ > > > uint8_t rsvd0[3]; /**< Reserved. */ > > > uint8_t vni[3]; /**< VXLAN identifier. */ > > > - uint8_t rsvd1; /**< Reserved. */ > > > + union { > > > + uint8_t rsvd1; /**< Reserved. */ > > > + uint8_t last_rsvd; /**< Reserved. */ > > > + }; > > > > > > > Is there a plan to remove 'rsvd1' in next ABI break release? > > We can keep both, but I guess it is not logically necessary to keep it, to prevent > > bloat by time, we can remove the old one. > > If decided to remove, sending a 'deprecation.rst' update helps us to remember > > doing it. > > > I think it should. @NBU-Contact-Thomas Monjalon (EXTERNAL) @Andrew Rybchenko@Ori Kam what do you think? >From user perspective, there is no benefit in removing an aliased field, except for simplicity. The drawback is a potential API compatibility breakage. We may mark it as deprecated in the comment and plan for removal in a long time, let's say 25.11? Is there anyone against removing "rsvd1" in VXLAN header for compatibility purpose?