DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Andrew Boyer <aboyer@pensando.io>
Cc: dev <dev@dpdk.org>, Alfredo Cardigliano <cardigliano@ntop.org>,
	ferruh.yigit@intel.com, john.mcnamara@intel.com
Subject: Re: [dpdk-dev] [PATCH v2 6/13] net/ionic: clean up Tx queue version support
Date: Fri, 05 Feb 2021 21:34:02 +0100	[thread overview]
Message-ID: <3305567.JaTTae7b9o@thomas> (raw)
In-Reply-To: <45998836-B694-4B87-8EFC-C02B3AE9885F@pensando.io>

05/02/2021 21:26, Andrew Boyer:
> > On Feb 5, 2021, at 3:20 PM, Thomas Monjalon <thomas@monjalon.net> wrote:
> > 29/01/2021 23:44, Andrew Boyer:
> >> The ionic PMD only supports Tx queue version 1 or greater.
> >> Version 1 introduced a new SGL format with support for more
> >> fragments per descriptor.
> >> 
> >> Add release notes and an explanation to the docs.
> >> 
> >> Signed-off-by: Andrew Boyer <aboyer@pensando.io>
> >> ---
> >> +* **Updated the Pensando ionic driver.**
> >> +
> >> +  Updated the Pensando ionic driver with new features and improvements, including:
> >> +
> >> +  * Fixed bugs related to link autonegotiation.
> >> +  * Fixed bugs related to port start/stop and queue start/stop.
> >> +  * Added support for probing the supported queue versions. Note that
> >> +    extremely old (pre-1.0) firmware will no longer be usable with the PMD.
> >> +  * Removed unused code.
> >> +  * Reduced device startup time.
> > 
> > Most of these items are unrelated to the rest of the patch.
> > And in general we don't mention cleanup and fixes in "New Features".
> > Actually we don't mention such minor things in the release notes.
> 
> It describes all of the changes that went in for this release.

It is recommended to add items in the release notes in the relevant patch
so it allows easy finding of the code mentioned in the release notes.

> Please feel free to remove any you feel are inappropriate - or send me a list and I will send a patch.

It's not a big deal. I am just informing you as you are still quite new :)
The most important is to avoid the release notes becoming a long list of fixes.

Eventually we could remove the lines "Fixed bugs ..." and
"Removed unused code" while doing the last cleanup.




  reply	other threads:[~2021-02-05 20:34 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-18 20:34 [dpdk-dev] [PATCH 00/13] net/ionic: fixes and optimizations Andrew Boyer
2021-01-18 20:34 ` [dpdk-dev] [PATCH 01/13] net/ionic: strip out unneeded interrupt code Andrew Boyer
2021-01-18 20:34 ` [dpdk-dev] [PATCH 02/13] net/ionic: observe endianness in firmware commands Andrew Boyer
2021-01-18 20:34 ` [dpdk-dev] [PATCH 03/13] net/ionic: observe endianness in Rx filter code Andrew Boyer
2021-01-18 20:34 ` [dpdk-dev] [PATCH 04/13] net/ionic: add an array-size macro Andrew Boyer
2021-01-27 17:22   ` Ferruh Yigit
2021-01-27 17:40     ` Andrew Boyer
2021-01-29 22:44   ` [dpdk-dev] [PATCH v2 4/13] net/ionic: use the existing " Andrew Boyer
2021-02-02 12:45     ` Ferruh Yigit
2021-01-18 20:35 ` [dpdk-dev] [PATCH 05/13] net/ionic: query firmware for supported queue versions Andrew Boyer
2021-01-18 20:35 ` [dpdk-dev] [PATCH 06/13] net/ionic: clean up Tx queue version support Andrew Boyer
2021-01-27 17:30   ` Ferruh Yigit
2021-01-27 17:46     ` Andrew Boyer
2021-01-29 22:44   ` [dpdk-dev] [PATCH v2 6/13] " Andrew Boyer
2021-02-02 12:46     ` Ferruh Yigit
2021-02-05 20:20     ` Thomas Monjalon
2021-02-05 20:26       ` Andrew Boyer
2021-02-05 20:34         ` Thomas Monjalon [this message]
2021-01-18 20:35 ` [dpdk-dev] [PATCH 07/13] net/ionic: inline queue flush function Andrew Boyer
2021-01-27 17:36   ` Ferruh Yigit
2021-01-27 17:43     ` Andrew Boyer
2021-01-27 17:50       ` Ferruh Yigit
2021-01-18 20:35 ` [dpdk-dev] [PATCH 08/13] net/ionic: inline queue space function Andrew Boyer
2021-01-18 20:35 ` [dpdk-dev] [PATCH 09/13] net/ionic: observe endiannness in ioread/iowrite Andrew Boyer
2021-01-18 20:35 ` [dpdk-dev] [PATCH 10/13] net/ionic: fix to allow separate L3 and L4 csum offload Andrew Boyer
2021-01-18 20:35 ` [dpdk-dev] [PATCH 11/13] net/ionic: convert per-queue offloads into queue flags Andrew Boyer
2021-01-18 20:35 ` [dpdk-dev] [PATCH 12/13] net/ionic: fix up function attribute tags Andrew Boyer
2021-01-18 20:35 ` [dpdk-dev] [PATCH 13/13] net/ionic: fix address handling in transmit code Andrew Boyer
2021-01-27 18:02 ` [dpdk-dev] [PATCH 00/13] net/ionic: fixes and optimizations Ferruh Yigit
2021-01-27 18:10   ` Andrew Boyer
2021-01-27 22:23     ` Ferruh Yigit
2021-01-27 22:25       ` Ferruh Yigit
2021-01-29 22:44 [dpdk-dev] [PATCH] net: redefine array size macros Andrew Boyer
2021-02-01 22:28 ` Thomas Monjalon
2021-02-01 22:32   ` Andrew Boyer
2021-02-02 12:30     ` Ferruh Yigit
2021-02-22 17:09       ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3305567.JaTTae7b9o@thomas \
    --to=thomas@monjalon.net \
    --cc=aboyer@pensando.io \
    --cc=cardigliano@ntop.org \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=john.mcnamara@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).