From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id F1A48A2E1B
	for <public@inbox.dpdk.org>; Wed,  4 Sep 2019 19:26:10 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 254D91BEB5;
	Wed,  4 Sep 2019 19:26:10 +0200 (CEST)
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by dpdk.org (Postfix) with ESMTP id 514B81BE91;
 Wed,  4 Sep 2019 19:26:08 +0200 (CEST)
Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com
 [10.5.11.13])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.redhat.com (Postfix) with ESMTPS id 50FAB10C051D;
 Wed,  4 Sep 2019 17:26:07 +0000 (UTC)
Received: from [10.36.117.52] (ovpn-117-52.ams2.redhat.com [10.36.117.52])
 by smtp.corp.redhat.com (Postfix) with ESMTP id A93F36060D;
 Wed,  4 Sep 2019 17:26:05 +0000 (UTC)
To: Jasvinder Singh <jasvinder.singh@intel.com>
Cc: Thomas Monjalon <thomas@monjalon.net>, dev@dpdk.org,
 cristian.dumitrescu@intel.com, stable@dpdk.org
References: <20190731113322.135053-1-jasvinder.singh@intel.com>
 <20190806114951.62131-1-jasvinder.singh@intel.com> <3667816.tTLe76bmax@xps>
From: Kevin Traynor <ktraynor@redhat.com>
Message-ID: <33062748-95a6-a9d5-ae32-3b792117b4f9@redhat.com>
Date: Wed, 4 Sep 2019 18:26:04 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.7.0
MIME-Version: 1.0
In-Reply-To: <3667816.tTLe76bmax@xps>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2
 (mx1.redhat.com [10.5.110.65]); Wed, 04 Sep 2019 17:26:07 +0000 (UTC)
Subject: Re: [dpdk-dev] [PATCH v2] examples/ip_pipeline: fix wrong value of
 tc ov weight
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 06/08/2019 14:26, Thomas Monjalon wrote:
> 06/08/2019 13:49, Jasvinder Singh:
>> The sched library checks the subport tc ov weight value regardless
>> of whether RTE_SCHED_SUBPORT_TC_OV flag is enabled or not.
>>
>> This fix allows application to always set valid tc ov weight value.
>>
>> Fixes: 25961ff3bcb9 ("examples/ip_pipeline: add traffic manager object")
>>

FYI, tc_ov_weight is not visible without the RTE_SCHED_SUBPORT_TC_OV until

Fixes: ca4d5915b877 ("sched: add config flexibility to TC queue sizes")

so this will not build on 18.11 stable.

>> error log
>> SCHED: pipe_profile_check: Incorrect value for tc ov weight
>> SCHED: rte_sched_port_check_params: Pipe profile check failed(-22)
>> Command "tmgr" failed.
>>
>> Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
>> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
>> ---
>> v2:
>> - add fix line
>> - change title
> 
> "tc ov" is not that obvious.
> I changed the title to "examples/ip_pipeline: fix TC oversubscription weight"
> 
> +Add Cc stable
> 
> Applied, thanks
> 
>