[dpdk-dev] [PATCH] examples/ip_pipeline: remove tc ov flag from pipe profile cli

[dpdk-dev] [PATCH] examples/ip_pipeline: remove tc ov flag from pipe profile cli

[Jasvinder Singh]

Since sched library always check the non-zero value of subport tc
ov weight. Therefore, it is necessary to set right value of tc ov
weight even if RTE_SCHED_SUBPORT_TC_OV is disabled.

Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
---
 examples/ip_pipeline/cli.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/examples/ip_pipeline/cli.c b/examples/ip_pipeline/cli.c
index f4c2be8b8..c6cf4204e 100644
--- a/examples/ip_pipeline/cli.c
+++ b/examples/ip_pipeline/cli.c
@@ -469,12 +469,10 @@ cmd_tmgr_pipe_profile(char **tokens,
 		return;
 	}
 
-#ifdef RTE_SCHED_SUBPORT_TC_OV
 	if (parser_read_uint8(&p.tc_ov_weight, tokens[19]) != 0) {
 		snprintf(out, out_size, MSG_ARG_INVALID, "tc_ov_weight");
 		return;
 	}
-#endif
 
 	for (i = 0; i < RTE_SCHED_BE_QUEUES_PER_PIPE; i++)
 		if (parser_read_uint8(&p.wrr_weights[i], tokens[20 + i]) != 0) {
-- 
2.21.0

Re: [dpdk-dev] [PATCH] examples/ip_pipeline: remove tc ov flag from pipe profile cli

[Dumitrescu, Cristian]

> -----Original Message-----
> From: Singh, Jasvinder
> Sent: Wednesday, July 31, 2019 12:33 PM
> To: dev@dpdk.org
> Cc: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>
> Subject: [PATCH] examples/ip_pipeline: remove tc ov flag from pipe profile
> cli
> 
> Since sched library always check the non-zero value of subport tc
> ov weight. Therefore, it is necessary to set right value of tc ov
> weight even if RTE_SCHED_SUBPORT_TC_OV is disabled.
> 
> Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
> ---
>  examples/ip_pipeline/cli.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/examples/ip_pipeline/cli.c b/examples/ip_pipeline/cli.c
> index f4c2be8b8..c6cf4204e 100644
> --- a/examples/ip_pipeline/cli.c
> +++ b/examples/ip_pipeline/cli.c
> @@ -469,12 +469,10 @@ cmd_tmgr_pipe_profile(char **tokens,
>  		return;
>  	}
> 
> -#ifdef RTE_SCHED_SUBPORT_TC_OV
>  	if (parser_read_uint8(&p.tc_ov_weight, tokens[19]) != 0) {
>  		snprintf(out, out_size, MSG_ARG_INVALID,
> "tc_ov_weight");
>  		return;
>  	}
> -#endif
> 
>  	for (i = 0; i < RTE_SCHED_BE_QUEUES_PER_PIPE; i++)
>  		if (parser_read_uint8(&p.wrr_weights[i], tokens[20 + i]) != 0)
> {
> --
> 2.21.0

Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>

We should check that this macro does not show up anymore in any of our apps.

Re: [dpdk-dev] [PATCH] examples/ip_pipeline: remove tc ov flag from pipe profile cli

[Thomas Monjalon]

31/07/2019 14:19, Dumitrescu, Cristian:
> From: Singh, Jasvinder
> > Subject: [PATCH] examples/ip_pipeline: remove tc ov flag from pipe profile
> > cli
> > 
> > Since sched library always check the non-zero value of subport tc
> > ov weight. Therefore, it is necessary to set right value of tc ov
> > weight even if RTE_SCHED_SUBPORT_TC_OV is disabled.

If I understand well, this is fixing something, but what?
Please could you propose a better title and a "Fixes" line?
Thanks

Re: [dpdk-dev] [PATCH] examples/ip_pipeline: remove tc ov flag from pipe profile cli

[Singh, Jasvinder]

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Tuesday, August 6, 2019 11:43 AM
> To: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>; Singh, Jasvinder
> <jasvinder.singh@intel.com>
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] examples/ip_pipeline: remove tc ov flag from
> pipe profile cli
> 
> 31/07/2019 14:19, Dumitrescu, Cristian:
> > From: Singh, Jasvinder
> > > Subject: [PATCH] examples/ip_pipeline: remove tc ov flag from pipe
> > > profile cli
> > >
> > > Since sched library always check the non-zero value of subport tc ov
> > > weight. Therefore, it is necessary to set right value of tc ov
> > > weight even if RTE_SCHED_SUBPORT_TC_OV is disabled.
> 
> If I understand well, this is fixing something, but what?
> Please could you propose a better title and a "Fixes" line?
> Thanks
> 

Sent v2 version. Thank you.

[dpdk-dev] [PATCH v2] examples/ip_pipeline: fix wrong value of tc ov weight

[Jasvinder Singh]

The sched library checks the subport tc ov weight value regardless
of whether RTE_SCHED_SUBPORT_TC_OV flag is enabled or not.

This fix allows application to always set valid tc ov weight value.

Fixes: 25961ff3bcb9 ("examples/ip_pipeline: add traffic manager object")

error log
SCHED: pipe_profile_check: Incorrect value for tc ov weight
SCHED: rte_sched_port_check_params: Pipe profile check failed(-22)
Command "tmgr" failed.

Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
---
v2:
- add fix line
- change title

 examples/ip_pipeline/cli.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/examples/ip_pipeline/cli.c b/examples/ip_pipeline/cli.c
index f4c2be8b8..c6cf4204e 100644
--- a/examples/ip_pipeline/cli.c
+++ b/examples/ip_pipeline/cli.c
@@ -469,12 +469,10 @@ cmd_tmgr_pipe_profile(char **tokens,
 		return;
 	}
 
-#ifdef RTE_SCHED_SUBPORT_TC_OV
 	if (parser_read_uint8(&p.tc_ov_weight, tokens[19]) != 0) {
 		snprintf(out, out_size, MSG_ARG_INVALID, "tc_ov_weight");
 		return;
 	}
-#endif
 
 	for (i = 0; i < RTE_SCHED_BE_QUEUES_PER_PIPE; i++)
 		if (parser_read_uint8(&p.wrr_weights[i], tokens[20 + i]) != 0) {
-- 
2.21.0

Re: [dpdk-dev] [PATCH v2] examples/ip_pipeline: fix wrong value of tc ov weight

[Thomas Monjalon]

06/08/2019 13:49, Jasvinder Singh:
> The sched library checks the subport tc ov weight value regardless
> of whether RTE_SCHED_SUBPORT_TC_OV flag is enabled or not.
> 
> This fix allows application to always set valid tc ov weight value.
> 
> Fixes: 25961ff3bcb9 ("examples/ip_pipeline: add traffic manager object")
> 
> error log
> SCHED: pipe_profile_check: Incorrect value for tc ov weight
> SCHED: rte_sched_port_check_params: Pipe profile check failed(-22)
> Command "tmgr" failed.
> 
> Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> ---
> v2:
> - add fix line
> - change title

"tc ov" is not that obvious.
I changed the title to "examples/ip_pipeline: fix TC oversubscription weight"

+Add Cc stable

Applied, thanks

Re: [dpdk-dev] [PATCH v2] examples/ip_pipeline: fix wrong value of tc ov weight

[Kevin Traynor]

On 06/08/2019 14:26, Thomas Monjalon wrote:
> 06/08/2019 13:49, Jasvinder Singh:
>> The sched library checks the subport tc ov weight value regardless
>> of whether RTE_SCHED_SUBPORT_TC_OV flag is enabled or not.
>>
>> This fix allows application to always set valid tc ov weight value.
>>
>> Fixes: 25961ff3bcb9 ("examples/ip_pipeline: add traffic manager object")
>>

FYI, tc_ov_weight is not visible without the RTE_SCHED_SUBPORT_TC_OV until

Fixes: ca4d5915b877 ("sched: add config flexibility to TC queue sizes")

so this will not build on 18.11 stable.

>> error log
>> SCHED: pipe_profile_check: Incorrect value for tc ov weight
>> SCHED: rte_sched_port_check_params: Pipe profile check failed(-22)
>> Command "tmgr" failed.
>>
>> Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
>> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
>> ---
>> v2:
>> - add fix line
>> - change title
> 
> "tc ov" is not that obvious.
> I changed the title to "examples/ip_pipeline: fix TC oversubscription weight"
> 
> +Add Cc stable
> 
> Applied, thanks
> 
>