From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 662D2A0471 for ; Thu, 18 Jul 2019 23:35:40 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E56B62BA8; Thu, 18 Jul 2019 23:35:38 +0200 (CEST) Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by dpdk.org (Postfix) with ESMTP id 5D42A28EE for ; Thu, 18 Jul 2019 23:35:37 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 0DEC74E9; Thu, 18 Jul 2019 17:35:35 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 18 Jul 2019 17:35:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=w9GTdhmkxzS1i73qC7YZj1TOOFXOGzTnA/n1pi4atWg=; b=KPVDHfedWXVM OiiWE92YnxtxsyUtAEPYvsui4dhpfthwL048WIl+eaxXlj1DkF283C2tI2Q7t40/ s2zlehjeDXT53tJWwKpp4hcu2dMyFJhGdtGuTEy8upUMBEI66tZ0rcOu+E6RILMU M/GLR8a9suiM08Km6hGfsPTWdaRi2Jo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=w9GTdhmkxzS1i73qC7YZj1TOOFXOGzTnA/n1pi4at Wg=; b=W4WanOEZwZ9gp4UTz7AeK91p9i+jQ3HhVMR8s87tJFEE/HS8PvsgdaHIB kM9pMy20pe/oePsS3pXXw3hTbMyiEpo+fh7tECWzH3dEt8ZUm/9iLYHAqetVTnLh lc8eDaa0RZMcU3POkhNhd0H6qA7uzBQ9sHfykFUEsOfrCXjdy15/c/rntdYqmuZT t/lZpbDONz7EROmcoVdddfIh+kFkyd4gsLw8JEzzOZt4c9AefDL1i0pBR5j6KEXA CnOeW0pyA3DPoWJuQLtmUjmHqk5+bLBPJ9W2CteJume9Nw1XyeZpD8C37ri2tJXG 7PnWoamlxT72CTV2uEAYLGxul0vLw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrieeiucetufdoteggodetrfdotffvucfrrh hofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgenuceurghi lhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurh ephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgrshcuofho nhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukfhppeejje drudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghs sehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 80CD180059; Thu, 18 Jul 2019 17:35:34 -0400 (EDT) From: Thomas Monjalon To: Ferruh Yigit Cc: dev@dpdk.org, Stephen Hemminger , Yangchao Zhou Date: Thu, 18 Jul 2019 23:35:33 +0200 Message-ID: <3307247.H1C8Hm2GdE@xps> In-Reply-To: <1846983.CBm7lp9OS6@xps> References: <20190711123508.45219-1-ferruh.yigit@intel.com> <20190711083335.55356aeb@hermes.lan> <1846983.CBm7lp9OS6@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] kni: fix possible buffer overflow X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 18/07/2019 23:24, Thomas Monjalon: > 11/07/2019 17:33, Stephen Hemminger: > > On Thu, 11 Jul 2019 13:35:07 +0100 > > Ferruh Yigit wrote: > > > > > 'kni_net_rx_lo_fifo()' can get segmented buffers, using 'pkt_len' for > > > that case will be wrong and some values can cause buffer overflow > > > in destination mbuf data. > > > > > > Signed-off-by: Ferruh Yigit > > > > Acked-by: Stephen Hemminger > > Applied, thanks I hope these lines are correct: Fixes: d89a58dfe90b ("kni: support chained mbufs") Cc: stable@dpdk.org