From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wg0-f54.google.com (mail-wg0-f54.google.com [74.125.82.54])
 by dpdk.org (Postfix) with ESMTP id 2AB31C60A
 for <dev@dpdk.org>; Mon, 22 Jun 2015 22:05:24 +0200 (CEST)
Received: by wgqq4 with SMTP id q4so25706494wgq.1
 for <dev@dpdk.org>; Mon, 22 Jun 2015 13:05:24 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=x+khuL9wJkCqqI8CUxw4R8Y4vp/37tr8MY5E5nDLEf8=;
 b=V0IFzzK/fyCuWnxTjQYlxSoQ8w7+7bo3957XrVSUELPebUnbVP2O1BWZ3lhBGnerny
 VVF2b2mS12FXbuBSweq7RfmGfZlad84/xd9uAT4jGnDuQX7OSs60+ysfYg1n7+p2vUsM
 KtmytBENspMODd5Qx5h9WWayWglFKYAKXKExliZj5XGHfz4xECb0XtvzznePSF9WjKE9
 DlhBqnuKw3nPyGaJpme4THQvjpicjqbeR/F1eET76pMSZvAP3SUbeWE9h3lzoCwx8IbF
 NDDyXslwju1iOmW3kku6UNLfpEt0XUnzpCBFw4ct6OOOUxTMpWKT95fFIwqJlS4cdoLR
 cKpw==
X-Gm-Message-State: ALoCoQke9U9gWVKdwKxT23Zj7b814MjFxUa/nbI5PocRRJ6vlWbIfANjwanda+6FsPRd70PZAqMC
X-Received: by 10.180.228.6 with SMTP id se6mr34812381wic.33.1435003523476;
 Mon, 22 Jun 2015 13:05:23 -0700 (PDT)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by mx.google.com with ESMTPSA id jy6sm27253905wjc.4.2015.06.22.13.05.21
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Mon, 22 Jun 2015 13:05:22 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Keith Wiles <keith.wiles@intel.com>
Date: Mon, 22 Jun 2015 22:04:20 +0200
Message-ID: <3312075.8iRd6T9neT@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; )
In-Reply-To: <CALwxeUvvWmhT_P=-1ARVMnLEP7CDA-3H0S46mxc2CD_UzMyQBA@mail.gmail.com>
References: <1433635446-78275-1-git-send-email-keith.wiles@intel.com>
 <1433800552-90338-1-git-send-email-keith.wiles@intel.com>
 <CALwxeUvvWmhT_P=-1ARVMnLEP7CDA-3H0S46mxc2CD_UzMyQBA@mail.gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] eal:Fix log messages always being printed
	from rte_eal_cpu_init
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 22 Jun 2015 20:05:24 -0000

2015-06-19 11:54, David Marchand:
> On Mon, Jun 8, 2015 at 11:55 PM, Keith Wiles <keith.wiles@intel.com> wrote:
> > The RTE_LOG(DEBUG, ...) messages in rte_eal_cpu_init() are printed
> > even when the log level on the command line was set to INFO or lower.
> >
> > The problem is the rte_eal_cpu_init() routine was called before
> > the command line args are scanned. Setting --log-level=7 now
> > correctly does not print the messages from the rte_eal_cpu_init() routine.
> >
> > Signed-off-by: Keith Wiles <keith.wiles@intel.com>
> 
> We could have a different solution, but this patch is the quickest answer
> to the described problem.
> Please, fix the checkpatch error / warnings, then, ack.

I fixed the checkpatch warnings.

Applied, thanks

I would prefer avoiding such copy/paste for bsdapp and linuxapp.
Ravi Kerur worked on factorizing EAL code but we never found the right time
to apply them and there are some concerns about the organizations of some
code areas. I suggest to try to apply these ideas just after 2.1.0-rc1, when
most of the pending EAL patches will be merged.
We'll have to do it piece by piece to avoid a "big review" effect.