From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id A589ACFC6 for ; Tue, 17 Apr 2018 20:59:17 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 4ABD121DE4; Tue, 17 Apr 2018 14:59:17 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 17 Apr 2018 14:59:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=oyemRGAIgpB6/1mmyoO1Ti0U4f oTOI8puKnQV8zBHbM=; b=NgayBUkHUHRR5fq5tC3JfgP1E4yMYw8Z8JzFeghmgM EmnLWGrlRb2Ju+uSmdU1y6yn1+zU/E3ftp22QHH0jpg0HBktqdcRAx9WPWYNLkGT Q9p1ZfuBoEtehV7FVSxQkRtJ+1xK/aJa9CqzA9WshcSXhGzAw18uKENHyRdp1kfx o= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=oyemRG AIgpB6/1mmyoO1Ti0U4foTOI8puKnQV8zBHbM=; b=Hrn3lVNfu2u6i1aqNSvnNp aYssVzjwUJiazRAL2EODIs4A3OiUH5AjOgARnFLVrfkHhf81TgNbjb9ibfhkHrFB 7dyVimj8YoyjroKPSqf6RQwjcyjHfyEAh7FNEN3uUAP9MGPDNpHBlPkTRbn8QbOT ROfK1uXDrg+nws7C/ZWFgXx/81kmlLynkuopIvpS3JWuwYVsmrf6sh83EXkPmLFT XFqQZMiWo3M28gKKB1581DOsNPELIzgHeyUK8jQ+ywZMxwVk0fPENYJGOqPETt7G OKcx/atSz8TTUfWt8qwx+xMAavle8TKNi3vXzW1EHssgkx6pym4movDZlcsX4euQ == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 7BFBBE4D6D; Tue, 17 Apr 2018 14:59:16 -0400 (EDT) From: Thomas Monjalon To: "Burakov, Anatoly" Cc: dev@dpdk.org Date: Tue, 17 Apr 2018 20:59:14 +0200 Message-ID: <33130999.IW4UYd3WLM@xps> In-Reply-To: <1f840947-c8ab-3fe1-4b00-3fd4a14e135b@intel.com> References: <2822934.JnSj6TxSKo@xps> <1f840947-c8ab-3fe1-4b00-3fd4a14e135b@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 00/10] Coverity fixes for EAL memory X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Apr 2018 18:59:17 -0000 17/04/2018 18:09, Burakov, Anatoly: > On 17-Apr-18 4:56 PM, Thomas Monjalon wrote: > > 17/04/2018 17:50, Anatoly Burakov: > >> This patchset fixes a host of coverity issues in memory subsystem > >> introduced with recent DPDK memory hotplug patchset. > >> > >> Coverity issues fixed: > >> - 272601 - leaking fd > >> - 272560 - double close fd > >> - 272568 - leaking fd > >> - 272570 - leaking fd > >> - 272589 - dereference before null check > >> - 272602 - freeing wrong pointer > >> - 272608 - expression does nothing > >> - 272577 - negative return not handled > >> - 272578 - negative return not handled > >> - 272584 - use after free > > > > Looks like you should buy a Coverity license > > to run it locally before submitting ;) > > Well, in fairness, most of these issues (and similar issues submitted in > another patchset) will not ever manifest themselves under normal > circumstances, so it's not as bad as it perhaps might present itself. Just kidding :) Thanks for the reactivity.