DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Gagandeep Singh <g.singh@nxp.com>
Cc: dev@dpdk.org, Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [v2 3/3] examples/l3fwd: enhance valid ports checking
Date: Tue, 19 Nov 2024 18:13:17 +0100	[thread overview]
Message-ID: <3316748.N7aMVyhfb1@thomas> (raw)
In-Reply-To: <20241113113907.62b4cafe@hermes.local>

13/11/2024 20:39, Stephen Hemminger:
> On Tue,  6 Aug 2024 09:11:20 +0530
> Gagandeep Singh <g.singh@nxp.com> wrote:
> 
> > The current port ID validation logic in the routes add code has
> > two issues:
> > 
> >  - It can pass if port ID in route is 31+.
> >  - It silently skips rules with disabled or invalid
> >    port IDs
> > 
> > This patch is:
> >  - Improving the enabled port IDs check logic.
> >  - Introducing a user option, "exit_on_failure", to control
> >    the behavior when attempting to add rules for disabled or
> >    invalid port IDs (either exit or skip)
> >  - Creating a port ID validation function for use across
> >    various setup functions
> > 
> > Signed-off-by: Gagandeep Singh <g.singh@nxp.com>
> 
> Patch looks fine, but other changes in the intervening time have
> caused conflicts with this patch. Needs to be rebased.

Waiting for a rebase please?



      reply	other threads:[~2024-11-19 17:13 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-15 10:14 [PATCH 1/3] examples/l3fwd: support single route file Gagandeep Singh
2024-07-15 10:14 ` [PATCH 2/3] examples/l3fwd: fix return value on rules add Gagandeep Singh
2024-07-16  6:55   ` Hemant Agrawal
2024-07-15 10:14 ` [PATCH 3/3] examples/l3fwd: fix maximum acceptable port ID in routes Gagandeep Singh
2024-07-17 10:17   ` Konstantin Ananyev
2024-07-18  6:30     ` Gagandeep Singh
2024-07-18 10:01       ` Konstantin Ananyev
2024-07-22  3:28         ` Gagandeep Singh
2024-07-22  4:27           ` Gagandeep Singh
2024-07-23 16:22             ` Konstantin Ananyev
2024-07-24  8:02               ` Konstantin Ananyev
2024-08-02 10:13                 ` Gagandeep Singh
2024-08-06  3:41 ` [v2 0/3] L3fwd changes Gagandeep Singh
2024-08-06  3:41   ` [v2 1/3] examples/l3fwd: support single route file Gagandeep Singh
2024-08-06  3:41   ` [v2 2/3] examples/l3fwd: fix return value on rules add Gagandeep Singh
2024-08-06  3:41   ` [v2 3/3] examples/l3fwd: enhance valid ports checking Gagandeep Singh
2024-11-13 19:39     ` Stephen Hemminger
2024-11-19 17:13       ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3316748.N7aMVyhfb1@thomas \
    --to=thomas@monjalon.net \
    --cc=dev@dpdk.org \
    --cc=g.singh@nxp.com \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).