From: Thomas Monjalon <thomas@monjalon.net>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Igor Russkikh <igor.russkikh@aquantia.com>,
Pavel Belous <pavel.belous@aquantia.com>,
Ajit Khaparde <ajit.khaparde@broadcom.com>,
Somnath Kotur <somnath.kotur@broadcom.com>,
Hemant Agrawal <hemant.agrawal@nxp.com>,
Sachin Saxena <sachin.saxena@nxp.com>,
Beilei Xing <beilei.xing@intel.com>, Jeff Guo <jia.guo@intel.com>,
Wei Zhao <wei.zhao1@intel.com>,
Andrew Rybchenko <arybchenko@solarflare.com>,
Shreyansh Jain <shreyansh.jain@nxp.com>,
dev@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com>,
stable@dpdk.org, David Marchand <david.marchand@redhat.com>
Subject: Re: [dpdk-dev] [PATCH v7 1/3] drivers/net: fix build with internal API usage
Date: Sat, 11 Jul 2020 00:07:31 +0200 [thread overview]
Message-ID: <3317109.Kn5D4eCups@thomas> (raw)
In-Reply-To: <20200710214343.1407419-1-ferruh.yigit@intel.com>
10/07/2020 23:43, Ferruh Yigit:
> Using '__rte_internal' tag in 'rte_ethdev_driver.h' causing build error
> for applications and examples. Because they don't define
> 'ALLOW_INTERNAL_API' flag and '__rte_internal' causes the error.
> This patch is preparation for future '__rte_internal' usage.
>
> At first place, applications/examples should not include
> 'rte_ethdev_driver.h', this is happening because of PMD public header
> files include 'rte_ethdev_driver.h' by mistake.
>
> Updated PMD public header files to not include internal header files.
>
> But for unit test application, 'app/test', enable accessing internal
> APIs, since some unit tests need them.
>
> Fixes: ffc905f3b856 ("ethdev: separate driver APIs")
> Fixes: ec0dec44ecb9 ("net/atlantic: enable MACsec configuration")
> Cc: stable@dpdk.org
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
Not sure to understand the title but I have no better proposal.
For the explanations and the code,
Acked-by: Thomas Monjalon <thomas@monjalon.net>
next prev parent reply other threads:[~2020-07-10 22:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-23 13:42 [dpdk-dev] [PATCH v5 0/4] Memory corruption due to HW rings allocation Renata Saiakhova
2020-06-23 13:42 ` [dpdk-dev] [PATCH v5 1/4] ethdev: add function to release HW rings Renata Saiakhova
2020-06-23 13:52 ` Ferruh Yigit
2020-06-23 15:49 ` Andrew Rybchenko
2020-06-23 13:42 ` [dpdk-dev] [PATCH v5 2/4] drivers/net: fix in igb and ixgbe HW rings memory Renata Saiakhova
2020-06-23 13:42 ` [dpdk-dev] [PATCH v5 3/4] drivers/net: fix in i40e HW rings memory overlap Renata Saiakhova
2020-06-23 13:42 ` [dpdk-dev] [PATCH v5 4/4] drivers/net: fix in em and ice " Renata Saiakhova
2020-06-23 13:53 ` [dpdk-dev] [PATCH v5 0/4] Memory corruption due to HW rings allocation Ferruh Yigit
2020-07-10 14:42 ` [dpdk-dev] [PATCH v6 1/2] ethdev: add function to release HW rings Ferruh Yigit
2020-07-10 14:42 ` [dpdk-dev] [PATCH v6 2/2] drivers/net: delete HW rings while freeing queues Ferruh Yigit
2020-07-10 21:43 ` [dpdk-dev] [PATCH v7 1/3] drivers/net: fix build with internal API usage Ferruh Yigit
2020-07-10 21:43 ` [dpdk-dev] [PATCH v7 2/3] ethdev: add function to release HW rings Ferruh Yigit
2020-07-10 21:43 ` [dpdk-dev] [PATCH v7 3/3] drivers/net: delete HW rings while freeing queues Ferruh Yigit
2020-07-10 22:07 ` Thomas Monjalon [this message]
2020-07-10 23:17 ` [dpdk-dev] [PATCH v7 1/3] drivers/net: fix build with internal API usage Ferruh Yigit
2020-07-11 0:19 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3317109.Kn5D4eCups@thomas \
--to=thomas@monjalon.net \
--cc=ajit.khaparde@broadcom.com \
--cc=arybchenko@solarflare.com \
--cc=beilei.xing@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=hemant.agrawal@nxp.com \
--cc=igor.russkikh@aquantia.com \
--cc=jia.guo@intel.com \
--cc=pavel.belous@aquantia.com \
--cc=sachin.saxena@nxp.com \
--cc=shreyansh.jain@nxp.com \
--cc=somnath.kotur@broadcom.com \
--cc=stable@dpdk.org \
--cc=wei.zhao1@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).