From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DC319A052A; Sat, 11 Jul 2020 00:07:40 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 930721DB7F; Sat, 11 Jul 2020 00:07:39 +0200 (CEST) Received: from new1-smtp.messagingengine.com (new1-smtp.messagingengine.com [66.111.4.221]) by dpdk.org (Postfix) with ESMTP id 3F2911D995; Sat, 11 Jul 2020 00:07:38 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailnew.nyi.internal (Postfix) with ESMTP id AD7EF58030B; Fri, 10 Jul 2020 18:07:36 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Fri, 10 Jul 2020 18:07:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= JhFshXnTwYf2bmDlAoyskYpH2HKihDTJGKaTBYDAMRs=; b=w7l6j0jI7GKVRnad RVYwMSa5B+FGQCBLCCBh7oIWjQotxubzTRHRUEfJSG9koz2ksImMTVGp9Se/1dEN +4RIlR5yBvNORA+mpYqwcktyTwAnBnebKaHc/nkbTcllisXDRf4hoATWK0UtMT55 J8ne3OeRnBv7FrWaMxuXYOcM8ZEuYmVM1kMuFybJW+0xnIAzELgtIVgbKxiqLf45 +ojoLq8hpk5PAaihCYZbc99XyP2+KOsAq8/z8fif7Q+ldQY4Fqz31h3mUaRm9bYB 786x7W8GboZy6Tszp9pKsG9m7Br5Luz+vtjRVHYId8KpsllglLothBFSUYKGkW1n oxKiPg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=JhFshXnTwYf2bmDlAoyskYpH2HKihDTJGKaTBYDAM Rs=; b=CGhdUBUrC1wboCJmtJuOzae5Ajshs8sDv6MNm6EJdqxauo6t/5q9ABW1k 2P+1DG+cvAzkmaJvASu4cieDdy7uXz6gQ96S3dof3oE/wa+w3PoD01nLm9eapFcM dFuq8Yzrsdhha+pDUiVyuMJRAARO26Ie1ygCwOszxIbX/eixmKogcx/69oBUlW8Z 74Vaxpm7cf056dtrUoFpXzn526x4RcnYPsfaQVVCSRQul3RKENiZ2an+vPZFIwlP zfpAwCjB8qKwm0JNV5ZsKxo2JFGZlSe1OISSSQ5qjzRjD2O8ZMFtM9sZSLhmFaAX phW7/P6H0NC1m0g/1eondqPt3iGtA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrvddvgddtiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 37D8530600B1; Fri, 10 Jul 2020 18:07:33 -0400 (EDT) From: Thomas Monjalon To: Ferruh Yigit Cc: Igor Russkikh , Pavel Belous , Ajit Khaparde , Somnath Kotur , Hemant Agrawal , Sachin Saxena , Beilei Xing , Jeff Guo , Wei Zhao , Andrew Rybchenko , Shreyansh Jain , dev@dpdk.org, Ferruh Yigit , stable@dpdk.org, David Marchand Date: Sat, 11 Jul 2020 00:07:31 +0200 Message-ID: <3317109.Kn5D4eCups@thomas> In-Reply-To: <20200710214343.1407419-1-ferruh.yigit@intel.com> References: <20200710144208.499544-1-ferruh.yigit@intel.com> <20200710214343.1407419-1-ferruh.yigit@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v7 1/3] drivers/net: fix build with internal API usage X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 10/07/2020 23:43, Ferruh Yigit: > Using '__rte_internal' tag in 'rte_ethdev_driver.h' causing build error > for applications and examples. Because they don't define > 'ALLOW_INTERNAL_API' flag and '__rte_internal' causes the error. > This patch is preparation for future '__rte_internal' usage. > > At first place, applications/examples should not include > 'rte_ethdev_driver.h', this is happening because of PMD public header > files include 'rte_ethdev_driver.h' by mistake. > > Updated PMD public header files to not include internal header files. > > But for unit test application, 'app/test', enable accessing internal > APIs, since some unit tests need them. > > Fixes: ffc905f3b856 ("ethdev: separate driver APIs") > Fixes: ec0dec44ecb9 ("net/atlantic: enable MACsec configuration") > Cc: stable@dpdk.org > > Signed-off-by: Ferruh Yigit Not sure to understand the title but I have no better proposal. For the explanations and the code, Acked-by: Thomas Monjalon