* Re: [PATCH] doc: announce dmadev new capability addition
2024-07-29 12:49 [PATCH] doc: announce dmadev new capability addition Vamsi Attunuru
@ 2024-07-29 15:20 ` Jerin Jacob
2024-07-29 17:17 ` Morten Brørup
2024-07-31 10:24 ` Thomas Monjalon
2024-07-30 12:10 ` [PATCH v2] doc: announce changes to dma device structures Amit Prakash Shukla
2024-07-30 12:53 ` [PATCH v3] " Amit Prakash Shukla
2 siblings, 2 replies; 10+ messages in thread
From: Jerin Jacob @ 2024-07-29 15:20 UTC (permalink / raw)
To: Vamsi Attunuru, Morten Brørup
Cc: fengchengwen, dev, kevin.laatz, bruce.richardson, jerinj, anoobj
On Mon, Jul 29, 2024 at 6:19 PM Vamsi Attunuru <vattunuru@marvell.com> wrote:
>
> Announce addition of new capability flag and fields in
The new capability flag won't break ABI. We can mention only fields
update rte_dma_info and rte_dma_conf structures.
Another option is new set APIs for priority enablement. The downside
is more code. All, opinions?
> rte_dma_info and rte_dma_conf structures.
>
> Signed-off-by: Vamsi Attunuru <vattunuru@marvell.com>
> ---
> RFC:
> https://patchwork.dpdk.org/project/dpdk/patch/20240729115558.263574-1-vattunuru@marvell.com/
>
> doc/guides/rel_notes/deprecation.rst | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index 6948641ff6..05d28473c0 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -147,3 +147,8 @@ Deprecation Notices
> will be deprecated and subsequently removed in DPDK 24.11 release.
> Before this, the new port library API (functions rte_swx_port_*)
> will gradually transition from experimental to stable status.
> +
> +* dmadev: A new flag ``RTE_DMA_CAPA_QOS`` will be introduced to advertise
> + dma device's QoS capability. Also new fields will be added in ``rte_dma_info``
> + and ``rte_dma_conf`` structures to get device supported priority levels
> + and to configure the required priority level.
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* RE: [PATCH] doc: announce dmadev new capability addition
2024-07-29 15:20 ` Jerin Jacob
@ 2024-07-29 17:17 ` Morten Brørup
2024-07-31 10:24 ` Thomas Monjalon
1 sibling, 0 replies; 10+ messages in thread
From: Morten Brørup @ 2024-07-29 17:17 UTC (permalink / raw)
To: Jerin Jacob, Vamsi Attunuru
Cc: fengchengwen, dev, kevin.laatz, bruce.richardson, jerinj, anoobj
> From: Jerin Jacob [mailto:jerinjacobk@gmail.com]
> Sent: Monday, 29 July 2024 17.20
>
> On Mon, Jul 29, 2024 at 6:19 PM Vamsi Attunuru <vattunuru@marvell.com>
> wrote:
> >
> > Announce addition of new capability flag and fields in
> > rte_dma_info and rte_dma_conf structures.
>
> The new capability flag won't break ABI. We can mention only fields
> update rte_dma_info and rte_dma_conf structures.
>
> Another option is new set APIs for priority enablement. The downside
> is more code. All, opinions?
I think that this feature should be simple enough to expand the rte_dma_info and rte_dma_conf structures with a few new fields, rather than adding a new set of APIs for it.
It seems to become 1-level weighted priority scheduling of a few QoS classes, not hierarchical or anything complex enough to justify a new set of APIs. Just a simple array of per-class properties.
The max possible number of QoS classes (i.e. the array size) should be build time configurable. Considering Marvell hardware, it seems 4 would be a good default.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] doc: announce dmadev new capability addition
2024-07-29 15:20 ` Jerin Jacob
2024-07-29 17:17 ` Morten Brørup
@ 2024-07-31 10:24 ` Thomas Monjalon
1 sibling, 0 replies; 10+ messages in thread
From: Thomas Monjalon @ 2024-07-31 10:24 UTC (permalink / raw)
To: Vamsi Attunuru, Morten Brørup, dev
Cc: fengchengwen, kevin.laatz, bruce.richardson, jerinj, anoobj, Jerin Jacob
29/07/2024 17:20, Jerin Jacob:
> On Mon, Jul 29, 2024 at 6:19 PM Vamsi Attunuru <vattunuru@marvell.com> wrote:
> >
> > Announce addition of new capability flag and fields in
>
> The new capability flag won't break ABI. We can mention only fields
> update rte_dma_info and rte_dma_conf structures.
>
> Another option is new set APIs for priority enablement. The downside
> is more code. All, opinions?
>
> > rte_dma_info and rte_dma_conf structures.
I'm fine with just updating these structs.
> > Signed-off-by: Vamsi Attunuru <vattunuru@marvell.com>
Acked-by: Thomas Monjalon <thomas@monjalon.net>
Any other opinions?
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v2] doc: announce changes to dma device structures
2024-07-29 12:49 [PATCH] doc: announce dmadev new capability addition Vamsi Attunuru
2024-07-29 15:20 ` Jerin Jacob
@ 2024-07-30 12:10 ` Amit Prakash Shukla
2024-07-30 12:53 ` [PATCH v3] " Amit Prakash Shukla
2 siblings, 0 replies; 10+ messages in thread
From: Amit Prakash Shukla @ 2024-07-30 12:10 UTC (permalink / raw)
Cc: dev, jerinj, vattunuru, mb, Amit Prakash Shukla
A new flag ``RTE_DMA_CAPA_QOS`` will be introduced to advertise dma device's QoS
capability. In order to support the parameters for this flag, new fields will be
added in ``rte_dma_info`` and ``rte_dma_conf`` structures to get device supported
priority levels and to configure the required priority level.
Signed-off-by: Vamsi Attunuru <vattunuru@marvell.com>
Signed-off-by: Amit Prakash Shukla <amitprakashs@marvell.com>
---
v2 changes:
- Add more description to commit log.
- Add more description to deprecation.rst.
doc/guides/rel_notes/deprecation.rst | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index 6948641ff6..87f2dfc648 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -147,3 +147,8 @@ Deprecation Notices
will be deprecated and subsequently removed in DPDK 24.11 release.
Before this, the new port library API (functions rte_swx_port_*)
will gradually transition from experimental to stable status.
+
+* dmadev: A new flag ``RTE_DMA_CAPA_QOS`` will be introduced to advertise
+ dma device's QoS capability. In order to support the parameters for this flag,
+ new fields will be added in ``rte_dma_info`` and ``rte_dma_conf`` structures
+ to get device supported priority levels and to configure the required priority level.
--
2.34.1
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v3] doc: announce changes to dma device structures
2024-07-29 12:49 [PATCH] doc: announce dmadev new capability addition Vamsi Attunuru
2024-07-29 15:20 ` Jerin Jacob
2024-07-30 12:10 ` [PATCH v2] doc: announce changes to dma device structures Amit Prakash Shukla
@ 2024-07-30 12:53 ` Amit Prakash Shukla
2024-07-30 14:46 ` [PATCH v4] " Amit Prakash Shukla
2 siblings, 1 reply; 10+ messages in thread
From: Amit Prakash Shukla @ 2024-07-30 12:53 UTC (permalink / raw)
To: fengchengwen, kevin.laatz, bruce.richardson, conor.walsh,
gmuthukrishn, vvelumuri, g.singh, sachin.saxena, hemant.agrawal
Cc: dev, jerinj, vattunuru, anoobj, mb, Amit Prakash Shukla
A new flag ``RTE_DMA_CAPA_QOS`` will be introduced to advertise dma device's QoS
capability. In order to support the parameters for this flag, new fields will be
added in ``rte_dma_info`` and ``rte_dma_conf`` structures to get device supported
priority levels and to configure the required priority level.
Signed-off-by: Vamsi Attunuru <vattunuru@marvell.com>
Signed-off-by: Amit Prakash Shukla <amitprakashs@marvell.com>
---
v3 changes:
- Add maintainers in email list.
v2 changes:
- Add more description to commit log.
- Add more description to deprecation.rst.
doc/guides/rel_notes/deprecation.rst | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index 6948641ff6..87f2dfc648 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -147,3 +147,8 @@ Deprecation Notices
will be deprecated and subsequently removed in DPDK 24.11 release.
Before this, the new port library API (functions rte_swx_port_*)
will gradually transition from experimental to stable status.
+
+* dmadev: A new flag ``RTE_DMA_CAPA_QOS`` will be introduced to advertise
+ dma device's QoS capability. In order to support the parameters for this flag,
+ new fields will be added in ``rte_dma_info`` and ``rte_dma_conf`` structures
+ to get device supported priority levels and to configure the required priority level.
--
2.34.1
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v4] doc: announce changes to dma device structures
2024-07-30 12:53 ` [PATCH v3] " Amit Prakash Shukla
@ 2024-07-30 14:46 ` Amit Prakash Shukla
2024-07-30 17:27 ` Jerin Jacob
0 siblings, 1 reply; 10+ messages in thread
From: Amit Prakash Shukla @ 2024-07-30 14:46 UTC (permalink / raw)
To: fengchengwen, kevin.laatz, bruce.richardson, conor.walsh,
gmuthukrishn, vvelumuri, g.singh, sachin.saxena, hemant.agrawal
Cc: dev, jerinj, vattunuru, anoobj, mb, Amit Prakash Shukla
A new flag RTE_DMA_CAPA_QOS will be introduced to advertise dma
device's QoS capability. In order to support the parameters for this
flag, new fields will be added in rte_dma_info and rte_dma_conf
structures to get device supported priority levels and to configure the
required priority level.
Signed-off-by: Vamsi Attunuru <vattunuru@marvell.com>
Signed-off-by: Amit Prakash Shukla <amitprakashs@marvell.com>
---
v4 changes:
- Fix checkpatch warning.
v3 changes:
- Add maintainers in email list.
v2 changes:
- Add more description to commit log.
- Add more description to deprecation.rst.
doc/guides/rel_notes/deprecation.rst | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index 6948641ff6..87f2dfc648 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -147,3 +147,8 @@ Deprecation Notices
will be deprecated and subsequently removed in DPDK 24.11 release.
Before this, the new port library API (functions rte_swx_port_*)
will gradually transition from experimental to stable status.
+
+* dmadev: A new flag ``RTE_DMA_CAPA_QOS`` will be introduced to advertise
+ dma device's QoS capability. In order to support the parameters for this flag,
+ new fields will be added in ``rte_dma_info`` and ``rte_dma_conf`` structures
+ to get device supported priority levels and to configure the required priority level.
--
2.34.1
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v4] doc: announce changes to dma device structures
2024-07-30 14:46 ` [PATCH v4] " Amit Prakash Shukla
@ 2024-07-30 17:27 ` Jerin Jacob
2024-07-31 11:01 ` Thomas Monjalon
0 siblings, 1 reply; 10+ messages in thread
From: Jerin Jacob @ 2024-07-30 17:27 UTC (permalink / raw)
To: Amit Prakash Shukla
Cc: fengchengwen, kevin.laatz, bruce.richardson, conor.walsh,
gmuthukrishn, vvelumuri, g.singh, sachin.saxena, hemant.agrawal,
dev, jerinj, vattunuru, anoobj, mb
On Tue, Jul 30, 2024 at 8:25 PM Amit Prakash Shukla
<amitprakashs@marvell.com> wrote:
>
> A new flag RTE_DMA_CAPA_QOS will be introduced to advertise dma
> device's QoS capability. In order to support the parameters for this
> flag, new fields will be added in rte_dma_info and rte_dma_conf
> structures to get device supported priority levels and to configure the
> required priority level.
>
> Signed-off-by: Vamsi Attunuru <vattunuru@marvell.com>
> Signed-off-by: Amit Prakash Shukla <amitprakashs@marvell.com>
Acked-by: Jerin Jacob <jerinj@marvell.com>
> ---
> v4 changes:
> - Fix checkpatch warning.
>
> v3 changes:
> - Add maintainers in email list.
>
> v2 changes:
> - Add more description to commit log.
> - Add more description to deprecation.rst.
>
> doc/guides/rel_notes/deprecation.rst | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index 6948641ff6..87f2dfc648 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -147,3 +147,8 @@ Deprecation Notices
> will be deprecated and subsequently removed in DPDK 24.11 release.
> Before this, the new port library API (functions rte_swx_port_*)
> will gradually transition from experimental to stable status.
> +
> +* dmadev: A new flag ``RTE_DMA_CAPA_QOS`` will be introduced to advertise
> + dma device's QoS capability. In order to support the parameters for this flag,
> + new fields will be added in ``rte_dma_info`` and ``rte_dma_conf`` structures
> + to get device supported priority levels and to configure the required priority level.
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v4] doc: announce changes to dma device structures
2024-07-30 17:27 ` Jerin Jacob
@ 2024-07-31 11:01 ` Thomas Monjalon
2024-07-31 16:06 ` Thomas Monjalon
0 siblings, 1 reply; 10+ messages in thread
From: Thomas Monjalon @ 2024-07-31 11:01 UTC (permalink / raw)
To: Amit Prakash Shukla
Cc: dev, fengchengwen, kevin.laatz, bruce.richardson, conor.walsh,
gmuthukrishn, vvelumuri, g.singh, sachin.saxena, hemant.agrawal,
dev, jerinj, vattunuru, anoobj, mb, Jerin Jacob
30/07/2024 19:27, Jerin Jacob:
> On Tue, Jul 30, 2024 at 8:25 PM Amit Prakash Shukla
> <amitprakashs@marvell.com> wrote:
> >
> > A new flag RTE_DMA_CAPA_QOS will be introduced to advertise dma
> > device's QoS capability. In order to support the parameters for this
> > flag, new fields will be added in rte_dma_info and rte_dma_conf
> > structures to get device supported priority levels and to configure the
> > required priority level.
> >
> > Signed-off-by: Vamsi Attunuru <vattunuru@marvell.com>
> > Signed-off-by: Amit Prakash Shukla <amitprakashs@marvell.com>
>
>
> Acked-by: Jerin Jacob <jerinj@marvell.com>
Acked-by: Thomas Monjalon <thomas@monjalon.net>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v4] doc: announce changes to dma device structures
2024-07-31 11:01 ` Thomas Monjalon
@ 2024-07-31 16:06 ` Thomas Monjalon
0 siblings, 0 replies; 10+ messages in thread
From: Thomas Monjalon @ 2024-07-31 16:06 UTC (permalink / raw)
To: Amit Prakash Shukla
Cc: dev, fengchengwen, kevin.laatz, bruce.richardson, conor.walsh,
gmuthukrishn, vvelumuri, g.singh, sachin.saxena, hemant.agrawal,
dev, jerinj, vattunuru, anoobj, mb, Jerin Jacob
31/07/2024 13:01, Thomas Monjalon:
> 30/07/2024 19:27, Jerin Jacob:
> > On Tue, Jul 30, 2024 at 8:25 PM Amit Prakash Shukla
> > <amitprakashs@marvell.com> wrote:
> > >
> > > A new flag RTE_DMA_CAPA_QOS will be introduced to advertise dma
> > > device's QoS capability. In order to support the parameters for this
> > > flag, new fields will be added in rte_dma_info and rte_dma_conf
> > > structures to get device supported priority levels and to configure the
> > > required priority level.
> > >
> > > Signed-off-by: Vamsi Attunuru <vattunuru@marvell.com>
> > > Signed-off-by: Amit Prakash Shukla <amitprakashs@marvell.com>
> >
> >
> > Acked-by: Jerin Jacob <jerinj@marvell.com>
>
> Acked-by: Thomas Monjalon <thomas@monjalon.net>
The RFC and the deprecation notices are sent a bit late.
We cannot conclude there is consensus.
I propose to raise it to the techboard if an ABI breakage is still required for 24.11.
As dmadev is quite new, I don't think it is big issue.
^ permalink raw reply [flat|nested] 10+ messages in thread