From: Thomas Monjalon <thomas@monjalon.net>
To: Ferruh Yigit <ferruh.yigit@intel.com>,
Jasvinder Singh <jasvinder.singh@intel.com>
Cc: dev@dpdk.org, cristian.dumitrescu@intel.com
Subject: Re: [dpdk-dev] [PATCH 1/2] net/softnic: enable flow classification function
Date: Thu, 07 Dec 2017 23:16:48 +0100 [thread overview]
Message-ID: <3321524.KpWgZ7mKTU@xps> (raw)
In-Reply-To: <f42ee212-c7f1-a5b9-c70c-e555da346a38@intel.com>
07/12/2017 22:02, Ferruh Yigit:
> On 11/30/2017 12:08 PM, Jasvinder Singh wrote:
> > _LDLIBS-$(CONFIG_RTE_LIBRTE_FLOW_CLASSIFY) += -lrte_flow_classify
> > _LDLIBS-$(CONFIG_RTE_LIBRTE_PIPELINE) += -lrte_pipeline
> > +_LDLIBS-$(CONFIG_RTE_LIBRTE_TABLE) += --whole-archive
> > _LDLIBS-$(CONFIG_RTE_LIBRTE_TABLE) += -lrte_table
> > +_LDLIBS-$(CONFIG_RTE_LIBRTE_TABLE) += --no-whole-archive
>
> I think it is better to move rte_table between whole-archive flags, but I
> vaguely remember Thomas preferred this in the past, so adding him for comment.
Yes it is good to keep the order, and insert whole-archive flags
where necessary.
Ideally we should not require these flags.
Just checking: you need them for static link of libs
while dynamically linking the PMDs, right?
next prev parent reply other threads:[~2017-12-07 22:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-30 20:08 [dpdk-dev] [PATCH 0/2] net/softnic: add flow classification support Jasvinder Singh
2017-11-30 20:08 ` [dpdk-dev] [PATCH 1/2] net/softnic: enable flow classification function Jasvinder Singh
2017-12-07 21:02 ` Ferruh Yigit
2017-12-07 22:16 ` Thomas Monjalon [this message]
2017-12-08 9:53 ` Singh, Jasvinder
2017-11-30 20:08 ` [dpdk-dev] [PATCH 2/2] net/softnic: add flow classification ops Jasvinder Singh
2017-12-07 21:02 ` [dpdk-dev] [PATCH 0/2] net/softnic: add flow classification support Ferruh Yigit
2017-12-08 9:50 ` Singh, Jasvinder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3321524.KpWgZ7mKTU@xps \
--to=thomas@monjalon.net \
--cc=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jasvinder.singh@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).