From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 35F367CBD
 for <dev@dpdk.org>; Thu,  7 Dec 2017 23:16:53 +0100 (CET)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id 2377320C25;
 Thu,  7 Dec 2017 17:16:50 -0500 (EST)
Received: from frontend2 ([10.202.2.161])
 by compute1.internal (MEProxy); Thu, 07 Dec 2017 17:16:50 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc; s=mesmtp; bh=dY9hZbDG2PMB52s/BVj+4W66ss
 KEb/uk8zVfJGnjMBg=; b=s3DdWywL78warQrfypKZ7KL5Gpm7Ndr3m8sYo5CW+a
 3lP0od5ErO5Zn3dVjJMm2/84Yk0aQOZZkXmW3TYN/Z3pbAKPqrWGMvQHiZXO/mHR
 7DUMPvECHMxXm4pR/ugLglLx6rib1Iok0XbDkOWn9Pz3Gl5HwEXZEFhWtzUYnh0a
 g=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=dY9hZb
 DG2PMB52s/BVj+4W66ssKEb/uk8zVfJGnjMBg=; b=rditgpCSs+KqlkhMibzBmp
 SONYVqZnNVCyql78YuJheSsQp6DHmYhBSy8M/A9UWZzuAHZ7s8fXaylshX0R1SKK
 77Y4xQBNO3qyKwilXxeN9d1h0eq/Hh2ayGYZ3URr42wG0bim8cCiEKWeRo9/ZUgA
 MRTIAEtF9Z3Qn2069KB0okzJKPDuFXv8KffuMz8bnLxW7BjiPXLN19DWvTqNaDtP
 /hf+yNATK8kaX+9R1rLWh/VxgvQAIza+Y6z4Vj8CCADj88qIbW7M296gWUcMziln
 /i3BlSEWOGnXABx872lbi/NaqSCMOaOkj67+SQS3qGptd8ciTy16qlH9SbrSX7Ww
 ==
X-ME-Sender: <xms:0r0pWu2KO5mjOe2-677BXhBXp7SBkKcoCxGQNMpPFIQ3N-UAiO996Q>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id C276224136;
 Thu,  7 Dec 2017 17:16:49 -0500 (EST)
From: Thomas Monjalon <thomas@monjalon.net>
To: Ferruh Yigit <ferruh.yigit@intel.com>,
 Jasvinder Singh <jasvinder.singh@intel.com>
Cc: dev@dpdk.org, cristian.dumitrescu@intel.com
Date: Thu, 07 Dec 2017 23:16:48 +0100
Message-ID: <3321524.KpWgZ7mKTU@xps>
In-Reply-To: <f42ee212-c7f1-a5b9-c70c-e555da346a38@intel.com>
References: <20171130200843.98621-1-jasvinder.singh@intel.com>
 <20171130200843.98621-2-jasvinder.singh@intel.com>
 <f42ee212-c7f1-a5b9-c70c-e555da346a38@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH 1/2] net/softnic: enable flow classification
	function
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 07 Dec 2017 22:16:53 -0000

07/12/2017 22:02, Ferruh Yigit:
> On 11/30/2017 12:08 PM, Jasvinder Singh wrote:
> >  _LDLIBS-$(CONFIG_RTE_LIBRTE_FLOW_CLASSIFY)  += -lrte_flow_classify
> >  _LDLIBS-$(CONFIG_RTE_LIBRTE_PIPELINE)       += -lrte_pipeline
> > +_LDLIBS-$(CONFIG_RTE_LIBRTE_TABLE)            += --whole-archive
> >  _LDLIBS-$(CONFIG_RTE_LIBRTE_TABLE)          += -lrte_table
> > +_LDLIBS-$(CONFIG_RTE_LIBRTE_TABLE)            += --no-whole-archive
> 
> I think it is better to move rte_table between whole-archive flags, but I
> vaguely remember Thomas preferred this in the past, so adding him for comment.

Yes it is good to keep the order, and insert whole-archive flags
where necessary.

Ideally we should not require these flags.
Just checking: you need them for static link of libs
while dynamically linking the PMDs, right?