From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5C52DA0546; Thu, 16 Jul 2020 13:31:53 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2C27B1BF71; Thu, 16 Jul 2020 13:31:53 +0200 (CEST) Received: from new3-smtp.messagingengine.com (unknown [66.111.4.229]) by dpdk.org (Postfix) with ESMTP id 9E1191BED7 for ; Thu, 16 Jul 2020 13:31:51 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailnew.nyi.internal (Postfix) with ESMTP id 473455800F4; Thu, 16 Jul 2020 07:31:42 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Thu, 16 Jul 2020 07:31:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= LVFHicxd/O7NzautuLQljnA/iSWAln41Rgy9MqY7Pcg=; b=vzRFjnP2DPvPoGWS TlzVOlluXdzEGSCHI/DydMpfXhTv+ZsShyYQECisPTYJkYe0lEowSAfRX7j/SRHh aEbVJ+Szt0m68PMrDyIRv3rI1+v5uH2UxYGJroVZO59o4q/vQJv4bYEPG3kEXkYr TpDM+jYLblmzJtjOJr9dt05M5cnrZOLG+HEhdDNgjbz15SWRdidxp4ukhDYxzap0 4Agzw37FeZV/oPCbleFNpbnnMW2eUvE/uqELe549z1OPAHFCsKbPDipmmyJ99rEU hFq1o1CqPpKXN0BA1b5Pf1Jk2SPsoJokROfaG6u9nkK3OudDG4eNlj40K1/DC5d/ OufA3w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=LVFHicxd/O7NzautuLQljnA/iSWAln41Rgy9MqY7P cg=; b=e4zUGCFeMTXrRj6OO5CL7ntRgXNoOFAFtA7vMXmjoDOnujJdePpMPHVGg 4Cb4DgOd4hnQdVD4X4G3zOH6d6hAQeNBBwBaN/KDnnZyw8M9BcF41ldItggtrMAJ k/0MDFrPjGZkxV0PLAV4mpKPwlwDiIWmAlCt4u9+g7dgB1Oev2F7D0YTvFteqqM1 XfAdotVfyc4bJzrAurGmCYpCqrigTAThRTwBTF4clHLWTOt3gkFqH8NWx5RvgUXx UNe4AsLxV2XsOUileotKEFSSidoDSq03VUWmBVpRk2yyZNEuBGsnugbxv57ddLSz 5XCt9E4sFYhXhImwMwEoBKrmleFBg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrfeeggdegudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id A06043280059; Thu, 16 Jul 2020 07:31:40 -0400 (EDT) From: Thomas Monjalon To: Phil Yang , Honnappa Nagarahalli Cc: dev@dpdk.org, "Mcnamara, John" , David Christensen , dev , Jerin Jacob Kollanukkaran , "Ananyev, Konstantin" , Ola Liljedahl , Bruce Richardson , "Ruifeng Wang (Arm Technology China)" , nd , David Marchand Date: Thu, 16 Jul 2020 13:31:38 +0200 Message-ID: <3325015.uBoaBXitGU@thomas> In-Reply-To: References: <1594621423-14796-1-git-send-email-phil.yang@arm.com> <1594875225-5850-3-git-send-email-phil.yang@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v8 2/3] devtools: prevent use of rte atomic APIs in future patches X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 16/07/2020 12:48, David Marchand: > On Thu, Jul 16, 2020 at 6:58 AM Phil Yang wrote: > > check_forbidden_additions() { # > > res=0 > > + c11_atomics_dir="lib/librte_distributor lib/librte_hash lib/librte_kni > > + lib/librte_lpm lib/librte_rcu lib/librte_ring > > + lib/librte_stack lib/librte_vhost > > + drivers/event/octeontx drivers/event/octeontx2 > > + drivers/event/opdl drivers/net/bnx2x drivers/net/hinic > > + drivers/net/hns3 drivers/net/memif drivers/net/thunderx > > + drivers/net/virtio examples/l2fwd-event" > > I prefer a form like: > > + c11_atomics_dir="" > + c11_atomics_dir="$c11_atomics_dir drivers/event/octeontx" > + c11_atomics_dir="$c11_atomics_dir drivers/event/octeontx2" > + c11_atomics_dir="$c11_atomics_dir drivers/event/opdl" > + c11_atomics_dir="$c11_atomics_dir drivers/net/bnx2x" > + c11_atomics_dir="$c11_atomics_dir drivers/net/hinic" > + c11_atomics_dir="$c11_atomics_dir drivers/net/hns3" > + c11_atomics_dir="$c11_atomics_dir drivers/net/memif" > + c11_atomics_dir="$c11_atomics_dir drivers/net/thunderx" > + c11_atomics_dir="$c11_atomics_dir drivers/net/virtio" > + c11_atomics_dir="$c11_atomics_dir examples/l2fwd-event" > + c11_atomics_dir="$c11_atomics_dir lib/librte_distributor" > + c11_atomics_dir="$c11_atomics_dir lib/librte_hash" > + c11_atomics_dir="$c11_atomics_dir lib/librte_kni" > + c11_atomics_dir="$c11_atomics_dir lib/librte_lpm" > + c11_atomics_dir="$c11_atomics_dir lib/librte_rcu" > + c11_atomics_dir="$c11_atomics_dir lib/librte_ring" > + c11_atomics_dir="$c11_atomics_dir lib/librte_stack" > + c11_atomics_dir="$c11_atomics_dir lib/librte_vhost" > > Easier to read and update. Why do we need this list at all? Are we allowed to add new code with old atomics in other directories? How bad it is to have a warning on non-converted libs?